From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f47.google.com (mail-dl1-f47.google.com [74.125.82.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32AB234DCD2 for ; Sun, 28 Jun 2026 23:03:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782687794; cv=none; b=P4n3QgiLnxCcowJNHqtG2fZT7veqkJsSnmOKlrSBdU6bFPys3ort6pcIRPswdp2UaLPcb6A4L9FvJVGDyLUMi7PSNIwikMXaJRJdeBxKTJ7/f81fA84LA0dmZqztvIXfOh78pVjiAOMZhv/fEHPlVuswyQZns7mVpRVhXDOKHLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782687794; c=relaxed/simple; bh=FQj8ckGZysNfiJUSLqBXvUF99XsO/lnSAXbrD2QnJQw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AXbX7QVCUz4++//7aMThpoC2WfTd++L9fqRbre88g9Y/zBQklUzTJUK5LJB8Zkj3eZ9rIC6XvdNmdh9mk9gSrrwEogS7sMnDWskvHmxxhCMYNWyD0gW60c0K8f7ZwAeS9wtuvQVlMhe5zUd/C7hE2UfT8iBXIFw4xMCHJ5tWraE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l5b5qGz3; arc=none smtp.client-ip=74.125.82.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l5b5qGz3" Received: by mail-dl1-f47.google.com with SMTP id a92af1059eb24-139f1dfc9faso1633962c88.0 for ; Sun, 28 Jun 2026 16:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782687792; x=1783292592; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=O3JHfzlaEWeCBPq/GnkthTuQ06HXnVphKOSwXmVpV54=; b=l5b5qGz3FNRJ2TzYz/wgvuxi9hEH1YZqzpyKM/E0RInH/gM1y3VJNtpMXnXhsm+xTU Zyaf5nyYiFk1wxjQ0leKtEpMwuFqjPxiSYlWIbaO8i16FibJUGrivneMYORB/Enc3TLc oZEX7ohqDMCccoM//rDmzvvkqM1upMyxPyBHqQPMuCu4qUfx+OfqN3mjqLnVzBASx9ms PJdfdxAO2F8tBY37+G9m+ORoJVPjg9LNjBhPxKZap4YeloKixsUz6bpEHi97dWZ3XdyV gqT1uDHSUujfuO+CzgP5YvqeQGLtmLLjKEygD8lAsnaTl9jNyMVmj7Xm23qqJCr/TDeg tTYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782687792; x=1783292592; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O3JHfzlaEWeCBPq/GnkthTuQ06HXnVphKOSwXmVpV54=; b=OlQTmOeJYCrosUKPqH8nJwy8P1g3fu1YTSlkGooZXsyTUlE/id6dfcuPdXbNXLCLaN vLYLcrdbXjQbGsdgt4hhP8pbxunRTa337vvd2YDBKvRGHhYUzFGmE4L6h3OS3KtA7tb9 Khq88+2X/j4787N70DZxkqJ5AfDzNsAtdULu++fxurPzvdE5WvCBiuiUvx+gEIYEP/jE NYWYyIIet1kpgtnO9odkJXRx/7HWXmBfnyGGbg85Xi4hNl2L8fP1NmaYAnNz839bZ5wf TD2Lvz5y+bSlhn3pJu5qdE0KMZNIYfMg55nv0xwk0RXzIc4NLiq1q7OvzZj5WLqslCGI h1xA== X-Forwarded-Encrypted: i=1; AFNElJ/ufzsXfpkjClCJTq/ShwGDxwggEY1No1Ly+tKBt8lPw0L72uvR6otgXqwWWDD6WpGYki1I1EtIk4mytgY=@vger.kernel.org X-Gm-Message-State: AOJu0YzTrUo+8cZYA18DgqC8dDdIQWplrxeI7e6Zd4N9xr3OCzgNs5n7 uDNHzNrBQ6XMYsinH6il2SAPXujrCufTTNSuRHjBVW3LE4YMgrLDPIQbJFixxA== X-Gm-Gg: AfdE7ckm+m1GhiQFCpTxhg18lHmg2URrsQvn7kkcdipK8ijq6P/yf/1uNpeE9xZaKoY Xfd4nBIZYbc453pRmGKWvCi3/Vy7c8CXLVuw4+YHHT25ePIYjG1cK0Jkg6fna6dsOrogPx7Aebq W4qB6epewxWSoc8cGXB7PudS4Rk64Pd8z5x4AardDwh9/NB+f3ntwpPu111vgYixAFaELnjFELQ 1xEuu98va9NNJ3Jhq7fjZdSmz4Wj7DWg4D2Bfabcfu3BWxKCSBoXXfxnr7Z/dzsISxNHn4wJGSg S5BbFQUOluWZHQR93GJIdeOpf5NSgbWgfYb8CixD+b0U0fkcU16BSTtfLsksUcIi389LmEoMv2M Vx4CV3xHTGtuen5Gmg1FhEZMGobnPignTw7UttTtAR+uVPNDt4dLzCVvapLliWbmkMEhGK2JPwi 7wuqMj0Sajz83MtTMIXv0EZtyzgJFVw8PWlk+FiZ7rP93ySk3eSsyORd5DcyY2N6AZmpwFAt7cL L7o+hxcCQ== X-Received: by 2002:a05:7022:6885:b0:138:177c:b971 with SMTP id a92af1059eb24-139dbab88fdmr11636945c88.29.1782687792205; Sun, 28 Jun 2026 16:03:12 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-139d8f6d2e4sm39140513c88.7.2026.06.28.16.03.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 16:03:11 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] ata: sata_dwc_460ex: use platform_get_irq() Date: Sun, 28 Jun 2026 16:03:10 -0700 Message-ID: <20260628230310.1214770-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace irq_of_parse_and_map() with platform_get_irq() in both sata_dwc_dma_init_old() and sata_dwc_probe(). This is the preferred way to obtain IRQs for platform devices and provides better error reporting. Remove the now-unnecessary #include . irq_of_parse_and_map() requires irq_dispose_mapping(), which is missing. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/ata/sata_dwc_460ex.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c index 4fc22ce4bd9a..35aa7f9acdf7 100644 --- a/drivers/ata/sata_dwc_460ex.c +++ b/drivers/ata/sata_dwc_460ex.c @@ -19,7 +19,6 @@ #include #include #include -#include #include #include #include @@ -226,7 +225,6 @@ static int sata_dwc_dma_init_old(struct platform_device *pdev, struct sata_dwc_device *hsdev) { struct device *dev = &pdev->dev; - struct device_node *np = dev->of_node; hsdev->dma = devm_kzalloc(dev, sizeof(*hsdev->dma), GFP_KERNEL); if (!hsdev->dma) @@ -236,11 +234,9 @@ static int sata_dwc_dma_init_old(struct platform_device *pdev, hsdev->dma->id = pdev->id; /* Get SATA DMA interrupt number */ - hsdev->dma->irq = irq_of_parse_and_map(np, 1); - if (!hsdev->dma->irq) { - dev_err(dev, "no SATA DMA irq\n"); - return -ENODEV; - } + hsdev->dma->irq = platform_get_irq(pdev, 1); + if (hsdev->dma->irq < 0) + return hsdev->dma->irq; /* Get physical SATA DMA register base address */ hsdev->dma->regs = devm_platform_ioremap_resource(pdev, 1); @@ -1173,11 +1169,9 @@ static int sata_dwc_probe(struct platform_device *ofdev) sata_dwc_enable_interrupts(hsdev); /* Get SATA interrupt number */ - irq = irq_of_parse_and_map(np, 0); - if (!irq) { - dev_err(dev, "no SATA DMA irq\n"); - return -ENODEV; - } + irq = platform_get_irq(ofdev, 0); + if (irq < 0) + return irq; #ifdef CONFIG_SATA_DWC_OLD_DMA if (!of_property_present(np, "dmas")) { -- 2.54.0