From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC456372EF1 for ; Sun, 28 Jun 2026 23:09:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782688190; cv=none; b=dtSfQGMgl5oAg9XfyBLtmSq+ob9tT9HGw30Oa4I8ILinDl8O0015aNoV8HRHZVp4xqp86CO5s6ujv6ya8dswK3HfgQXNUx5/i78XxcjniuL8kyOnHDvB8x1R4ln5oEw1dCvCkdgyZ4BdDt+Tj7Bk/njVCF1dUDf58dD+7907sXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782688190; c=relaxed/simple; bh=wHzJ07thjGcb23pK5OSEFKM5WhNdv0RAe3FLxmBcy5c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oaYGa3mSfEic/N0KUZzR1UHcBSS3UaHpl67QOcBl7dmbuMvCpjaZIyWq6cWowMKF8/R2uofO6D4tK86f3Y2U1eHSjQJh2CLqu9tYR1j9pmGfdKFjrjoKEEJrckq8u8CDpeuMpfE969gdplp7wLBzyOn/fWefq3Q3d4tz0vpXlds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JIZQUKvn; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JIZQUKvn" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-37defb2f231so1311293a91.2 for ; Sun, 28 Jun 2026 16:09:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782688188; x=1783292988; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tizSwas8YHcypZL2dVhET/Zc9jaBNCk/iG8Mcm3/l0I=; b=JIZQUKvnswpqRkixfn8TzuWKM3wrmRJWy01hz3nCwv9Xr5Y2nIW5JBOPT3AOkgLSGU AVZ+qD59KhDJiapAJIzxEl9z4q/S+5bsCH0HDnby9t4J5jwDTJq+VRnG4OwSNrjJsVFv wRxGZuNkdPeddUGIRNlRcsxft4Gw+OE53/6P4wPnYf7YWwG0WBzug3KWHXpfAdZL72da KxFEftFna2LtxGvAA8zz2pp6AA26yljfEAt/r8Dus1ZK7/CMj6ZTrxV+353X/19Ro8Mp HMgaGOjdgwS+lRcJwlMLzes+dSsmVBa/dz0Tk5galQE5QAJX2Im7llysb8IiE0ptRG6y vHYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782688188; x=1783292988; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tizSwas8YHcypZL2dVhET/Zc9jaBNCk/iG8Mcm3/l0I=; b=Fv+Zx8CAqR9f4ihkn39EjTXCvwnMVA+J3MBPOwHA26nzEXl3XsHl91mt4NZEt0WXmP jbQVkZGvoFYgbzCMm2ssGl6Xk0//9xbDp8sA6uP3y/ej1MVhb7mZ47CH2MTEoTyJC0hy b6Mgy23h595Hbgm5sZBEZ1vimJoJ0Qy3u1dbhUDwFu4Hg2vax6H0oh3ASNNI7WiD4sHe i+r1T1MVEexLHjQS0Ry0Qe1J3il3kc++SMKNo3Con8TiIvvv1CYRjixKIMTaTJu2TxWe xezKl59oeAbvO4R1Nfum4R8vz/hEPBVb7Bfhi5V7QgBjTixJaA6Dp8bBgtshn7gHAm7f /EWw== X-Forwarded-Encrypted: i=1; AHgh+RrVBATn5VSwwiI7a0jerWmAhQ+PU7mCg9yn3LAvNWYVVT2ROcVCvvZdNSP1wDfu18T6DK9NxYsxzthaEFw=@vger.kernel.org X-Gm-Message-State: AOJu0YwvDa3wwDcKsXFsnfQeBytISqU3unLJbEFvvjcTP1ccAFj8LVea p2PIFTFQyFTePvVuJqULAq7PgafuJxxVF34B0GZvsP4JRHFV70KFapN1 X-Gm-Gg: AfdE7cn29nAoiHlbUvC01dkf4Mi9D+EzMDsUBI6zmKPHMfqDD380Gd9aBcfKmup36Mo vA4yzvmyQ+korE0Fal25JB2gMNr6xWDO2uMyhBxSgHEBAf8SwH+rmhS54Uq2IAsnZb4T2tNyigq y4MDeV1Cj5RO63/2HVB8ipasBgaX8HXhxfXI2Mo+HzVRcjnzZ6j6hEBAhmg1H8+dJLV8RayBk2K yy06yhFVlB9cbSLgJrQQqH5MsoK+745KQ1GK6YLac+jDz7dQ5Bcu0mL71esVPb+AQlGPm37tGXo B4z0zcenGkV41d9047evxK/VCmc74AoGb9eRJbrW1LobrB17P6uFfnWVRmv2gsARpz5Yv488AXp vW1N+2aiQqeoCsJfV95BOnq6ogMi7jsZ0IVED8wO+QCqGMbbz9KrQAea90p23QLFFJG4Zt8m4Yt SBDiHCH0kXiWtUvVnN6PH+ff3Jr+FUaev6hh37O/p/WfQ59F9pwaGGebPFizTKPtwJfAAySlHit /2ZQDkMwvbtvurFtdxY X-Received: by 2002:a17:90b:4c4d:b0:37f:ed70:cc30 with SMTP id 98e67ed59e1d1-37fed70ccf3mr2331009a91.26.1782688187936; Sun, 28 Jun 2026 16:09:47 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3800b9c834dsm606960a91.6.2026.06.28.16.09.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 16:09:47 -0700 (PDT) From: Rosen Penev To: netdev@vger.kernel.org Cc: Chris Snook , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/3] net: ag71xx: Use default NAPI weight Date: Sun, 28 Jun 2026 16:09:42 -0700 Message-ID: <20260628230944.1244501-2-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260628230944.1244501-1-rosenp@gmail.com> References: <20260628230944.1244501-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Drop the custom NAPI weight and let netif_napi_add() use the core default. The old comment claimed larger weights wasted cycles and cache, but recent RX and TX path changes altered those tradeoffs. Keep the driver on the standard default unless measurements show a device-specific value is needed. iperf3: Before: [ ID][Role] Interval Transfer Bitrate Retr [ 5][TX-C] 0.00-10.00 sec 327 MBytes 274 Mbits/sec 31 sender [ 5][TX-C] 0.00-10.00 sec 325 MBytes 273 Mbits/sec receiver [ 7][RX-C] 0.00-10.00 sec 170 MBytes 143 Mbits/sec 0 sender [ 7][RX-C] 0.00-10.00 sec 170 MBytes 143 Mbits/sec receiver After: [ ID][Role] Interval Transfer Bitrate Retr [ 5][TX-C] 0.00-10.00 sec 341 MBytes 286 Mbits/sec 30 sender [ 5][TX-C] 0.00-10.00 sec 338 MBytes 284 Mbits/sec receiver [ 7][RX-C] 0.00-10.00 sec 184 MBytes 154 Mbits/sec 0 sender [ 7][RX-C] 0.00-10.00 sec 184 MBytes 154 Mbits/sec receiver Assisted-by: Codex:GPT-5.5 Signed-off-by: Rosen Penev --- drivers/net/ethernet/atheros/ag71xx.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c index ac4eadb9190a..1def2ad4c5ce 100644 --- a/drivers/net/ethernet/atheros/ag71xx.c +++ b/drivers/net/ethernet/atheros/ag71xx.c @@ -40,11 +40,6 @@ #include #include -/* For our NAPI weight bigger does *NOT* mean better - it means more - * D-cache misses and lots more wasted cycles than we'll ever - * possibly gain from saving instructions. - */ -#define AG71XX_NAPI_WEIGHT 32 #define AG71XX_OOM_REFILL (1 + HZ / 10) #define AG71XX_INT_ERR (AG71XX_INT_RX_BE | AG71XX_INT_TX_BE) @@ -1913,8 +1908,7 @@ static int ag71xx_probe(struct platform_device *pdev) return err; } - netif_napi_add_weight(ndev, &ag->napi, ag71xx_poll, - AG71XX_NAPI_WEIGHT); + netif_napi_add(ndev, &ag->napi, ag71xx_poll); ag71xx_wr(ag, AG71XX_REG_MAC_CFG1, 0); -- 2.54.0