From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 628A53749F1 for ; Sun, 28 Jun 2026 23:09:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782688194; cv=none; b=oRemXRZ750JJ0x7rNJiLwbq2sf0shNx5DrMYVhDZtNXoLykRpc2Fov7+f1bMTakVqWh2D2AhULavpS9BJfocyDm0HP8uWSBPleRi8kBg4z0bbUeMCQnd2WpSqUXsGj0e5bnDquwBDg5XbjCEalLJItP+IIvdWiRiaobDkp/szxk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782688194; c=relaxed/simple; bh=8hxuXTTZXT6Wc4B3sIsuemeGr47k4Dd+hEsKaSACrTk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P8pNvOcZYvUVPQPswGimmqvkSvQNbofvna3aRsWB5Hsd+Qrok93Obiukpgkt9krcix9u5XoIoaal2SvU0Yslp1psH0EtDWcdqonciiZC8j5RnpplDNqUMzZn1eh98Deu6g8ZWJZdHb7VOUjLMlUJz5qgh3YGLsQhy44HqwOckGc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XHF4ywJu; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XHF4ywJu" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-38005a36edbso141600a91.1 for ; Sun, 28 Jun 2026 16:09:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782688191; x=1783292991; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xd+9YCaMMJY0u/th5I1l3CpeHyUJ3UN/zpLGzdMsshE=; b=XHF4ywJuugBj/ap8zKG5rOrl5nQQx6ttwUEJvQlRIdXxvLoAs9eLElmrLxZ/QCHoex b/2dPmdnZogZ2wSh6r87BetrD46rYBbpBliGHcHNz1Qtkoiv8QaJ96xMo4Hscsw7Det7 Su35eyWLVN/DmglVH+W8JedNXNfXYhhz6dY603x/PU7SqhpcpMT2gqGdIyk0honXe6sO JsI6i6edvW6qpXken0uQUYugfaD+KeTfttomK3zKyTf+csd5g5vraLB3o7sehmXtmh1d Baqucp3zkm9eDgEU98zm4liENhWCQobpIcMxLkreJPaq7rMIbipg28xDgq33XMAakjq4 yRSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782688191; x=1783292991; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xd+9YCaMMJY0u/th5I1l3CpeHyUJ3UN/zpLGzdMsshE=; b=jzn7yaEMgL3/ikrK7N6/zU9mMXwG+z8ng15EEpU/HmChNx2tMSRQSMveS8FWED3Ir6 o6lTY5pdpaAZ976UsXLfC7e5Qi3yB8xG4cnX3AkmuPDtbI5J9WSkOPFPhhbkBIsDgLNl iBI5HUoUlAYULpnJ5YoL8VvzBkXCbwQUXWkmYU7XRbrXZ5nhku5a4FekrKitvmkniNsY vNduPi4+PeDNSyGJGnmheKBDxKtsABM8D7ZNV54QuUZN1eAI6hYD5V70aYlGR455bM8O BNPiokI+OHotbY8ASlEiNmVgovIiA9ZOrQ4wNey0oyU3GuYtm2j0g2MUhfe8+Shp0fWl Lg0Q== X-Forwarded-Encrypted: i=1; AHgh+RqMex/UHiuNDO4qrj2dXnrhiBilq0KwBk+XMfkuDtslxlnAH4xeMq3M7VX5RL/VR+Bm8hlAILf5Hb+Pfko=@vger.kernel.org X-Gm-Message-State: AOJu0Ywaak6HawWr7eeEZoExETx9U6YqEN3pV5F9SbpFfv2DjBZQ3Ne4 bHkPV+Bia6fFF2gpen5Ea7Grqadr5XEutLAurdmOTTqOelIHlt3w00jn X-Gm-Gg: AfdE7ckaebos9uc3vdNJNXDOtoP0/uDSH/UqEmk09SWdQNSAuNll2MeWCDDA+LJyT0g QOPY7HjTF8QghOqbTjJ9xnE0TTzovFgRVqBy0u217VWll0wnxmwRNqkQRdz7v1yG788lZ8GnpQj vCJ66YtseRCarv1DKSYxRM5AuOuST7Fu2aybT+fP8r2A+gvraQj3umFwmfH0SPdA33CwJ0hiGFe W9DwTHRVqwtaQYRni7e/DvjlnE6U+Z3riL90PT2nXKv5N778zFyeOoNEb732wcjHnyU2qt/2LEf CLxcJpWBaAEo0BK6CTax2jpWI0ZvVN6zg04ZtZpuyyoub9qrifpL86Lcqvhj/BixK3cnCxvSHgU 86D4nmYyMSbZBgzVHfbrUTFgr4xKTlE2aCTgtDwy+bsj0ug+GjgJrgAHlx0VHPnhI6L4IJ+249M ERpfw9utqP8XuTkC3kBVQw4OtiCQx8D7juRbMkfEfdypof0mrIChFqwUk2/iubyiREKxcWUOjPQ p6xu+2m/A== X-Received: by 2002:a17:90b:380d:b0:380:1481:3b3f with SMTP id 98e67ed59e1d1-38014813ef8mr587232a91.3.1782688190707; Sun, 28 Jun 2026 16:09:50 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3800b9c834dsm606960a91.6.2026.06.28.16.09.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 16:09:49 -0700 (PDT) From: Rosen Penev To: netdev@vger.kernel.org Cc: Chris Snook , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 3/3] net: ag71xx: re-enable TX interrupts on RX OOM Date: Sun, 28 Jun 2026 16:09:44 -0700 Message-ID: <20260628230944.1244501-4-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260628230944.1244501-1-rosenp@gmail.com> References: <20260628230944.1244501-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When the RX ring runs out of buffers the OOM path calls napi_complete() but does not re-enable interrupts. Because INT_POLL masks both RX and TX events, TX completions are blocked until the OOM timer fires (~100 ms), which can cause TX ring exhaustion and dropped packets. Restore TX interrupt delivery so the engine can drain completed descriptors while NAPI waits for RX buffer memory. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/net/ethernet/atheros/ag71xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c index 77f8e75e98ac..a4e52bc42091 100644 --- a/drivers/net/ethernet/atheros/ag71xx.c +++ b/drivers/net/ethernet/atheros/ag71xx.c @@ -1720,6 +1720,7 @@ static int ag71xx_poll(struct napi_struct *napi, int limit) mod_timer(&ag->oom_timer, jiffies + AG71XX_OOM_REFILL); napi_complete(napi); + ag71xx_int_enable(ag, AG71XX_INT_TX); return 0; } -- 2.54.0