From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC64A35674A for ; Sun, 28 Jun 2026 23:20:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782688803; cv=none; b=VMLj5nnmK42TqLqvhwB/lrxG0bjuz9S1aj1cmJajFBSKv2TzKSVpbEL5ujtMviLFLUcV/U6SQdgyPkbNj5svYPltbmp1XkuOHCI2EmxbEO8I/C4SYi4f+yND65wrH0gAxfZ5XpuZPUjKVpZKHjt2CokKxqc4V7fkpXjNtmDEoqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782688803; c=relaxed/simple; bh=TFh52Z3aYd0ikbblTiHAbY7mMw+49K+zzSQUsYqlNE8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LNDKrBpC8fbSoKNSKpp3eynzPUc4l/s1zcViqpcwbLgUsZb57mZbIMJkpXVE3TG/i3a16xRU6BYHxv1Qfs9YzFkQ/jD7doVlZ9h/V+xERz/p4VnySjIu2BoOrveBLJEsi3wrESNfkNtTj31cmWqMz0C+MUbe2NIUWxnkzsOMhMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ci9efz4M; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ci9efz4M" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c892a0ef503so1197985a12.2 for ; Sun, 28 Jun 2026 16:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782688802; x=1783293602; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UcVzp6hS2wbilTH9sWD8SVsexr892ADQOI78SGhqqdA=; b=Ci9efz4Mx4ek8ZBf1TIptrow7Xmyv2tRtuPLA4mxH4kq0JTnANeAYHfJn44exquuAs oG0T2EUp1vWnAJ+mWL2JHeg+DWe5KEHtrJPhhosAbGxlYLgnV1p6C3ih6UEwyQv5jukh Wi9IM6xSFqP3q311zHLDcKGt6XyMpEnch7o210FH4x5wOwvg9lqQ7qqqxR7EiJJgcGuj bTUCnpAsz++QfqxZauh8AUdxPJdpoCc7jHoDGeLpb4cAIXOMTGTBUgmodzuwhKDrLnwp wyzW/N+9d5Ypuda6BMNvJbjeL0X0pB6l8j1O6DXrSCmLAF6KLbqU9jciHNi8ysy7V+jf 8H7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782688802; x=1783293602; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UcVzp6hS2wbilTH9sWD8SVsexr892ADQOI78SGhqqdA=; b=iJ0X+VDuG/7YBFmnfGEECJZGDLY7xGQ7gAyWV2Vh+6ljaEs3QCXWwCZJ7f2sguJJii 4VfEcqQ2V5O298zePxC7LYhrmNDdWEW5ocCpDxIjNQaeyWbD8wBRMqgizt4W15KxUd62 2GWs0EZPpIAR2Z4CSFszq+j/X+bB0X8iqVorOy4mhbBpfN9j/ACtVryGCEM5WqNi3hdk zbwP40vS65eUaNMCyNBABM+C36OmwjeWfW+/zgkwm1BHTeYj/2DsYtbd+LUTRtivxRnH TltLASf6byFMv6XuAAIUTsMYarCtGEQ0a07UnkJ8EHgWyUaRUBYFP4vL7nfgWIyhg3M8 j6kg== X-Forwarded-Encrypted: i=1; AFNElJ/i277p9s67z39T5AB11xib66etlNdKjULDcgYCJ692wxtqgNUhW4qoLBHshkA99NUd4osX/WSoU5uplMA=@vger.kernel.org X-Gm-Message-State: AOJu0YwtxNw5JjHcxeDpysSZgDglV3AGMshMgcaSdCEuujZLVW+EXoud OAbEsxfXS4RrhrmDxUgJKVPyPQARQLgqVOvpvomLdojSUCHfMDDpkK9j X-Gm-Gg: AfdE7cnqnNHEIeuFbXd/zXiZiQkFrKTceGdJxeYJwkUmVz36/qM66MNK/XH/35kdaMo r0f2W2Q78HUB52rACi97LTDlRvbRH+3hWko6FyxQXAy82kFUqExVGk+cwFWlvkMZDmi3Noq6kkQ pvQ/HUfb9m3hi3cLlyZtEdyp+fETQzUun8rDBA25zhZWBV0VPgB6HAml1VqRRp8dYzqIMTeEd06 cOS/+DsClrfqKaOap5S1Y4xGOPwZchY/tVN2jNodBSTWg19kHSJwRNokgJ9MXs25SKtbnfOW9Fe ireB0uxe0OskJ6A5mZL4Yx907tXKhewLdvGnAHJa9fIvxKNrx5gc9wTulmsrywCzKbv5HwxV7lG 5tuEl4c+Q08yBRQEQzuhWk2T1swJ7WHUQZtjukchCeuLDtZYQ6dfvzbe7ruaPPiIWgpeZX34VSu s+qvcz702wELThNicBYr2gW+3wOKESGwLibNCO6cfWKXm8P74+X7Z9LURXu/Vb1joCtzoLvszAX Bd/xKA7Fg== X-Received: by 2002:a05:6a21:3a45:b0:3bf:a26e:3dbc with SMTP id adf61e73a8af0-3bfa26e4986mr859526637.19.1782688802070; Sun, 28 Jun 2026 16:20:02 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c92bcc91f6dsm6643007a12.27.2026.06.28.16.20.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Jun 2026 16:20:01 -0700 (PDT) From: Rosen Penev To: linux-crypto@vger.kernel.org Cc: Srujana Challa , Bharat Bhushan , Herbert Xu , "David S. Miller" , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] crypto: cesa: add missing free_irq() calls Date: Sun, 28 Jun 2026 16:20:00 -0700 Message-ID: <20260628232000.1287439-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the missing free_irq() calls, along with irq_set_affinity_hint(NULL) to clear the affinity hint set during probe. Fixes: 5bbf25419f8e ("crypto: marvell/cesa - use request_threaded_irq instead of devm variant") Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/crypto/marvell/cesa/cesa.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/marvell/cesa/cesa.c b/drivers/crypto/marvell/cesa/cesa.c index 75d8ba23d9a2..57c9295be711 100644 --- a/drivers/crypto/marvell/cesa/cesa.c +++ b/drivers/crypto/marvell/cesa/cesa.c @@ -511,7 +511,7 @@ static int mv_cesa_probe(struct platform_device *pdev) writel(engine->sram_dma & CESA_SA_SRAM_MSK, engine->regs + CESA_SA_DESC_P0); - ret = devm_request_threaded_irq(dev, irq, NULL, mv_cesa_int, + ret = request_threaded_irq(irq, NULL, mv_cesa_int, IRQF_ONESHOT, dev_name(&pdev->dev), engine); @@ -540,6 +540,10 @@ static int mv_cesa_probe(struct platform_device *pdev) return 0; err_cleanup: + while (i--) { + irq_set_affinity_hint(cesa->engines[i].irq, NULL); + free_irq(cesa->engines[i].irq, &cesa->engines[i]); + } for (i = 0; i < caps->nengines; i++) mv_cesa_put_sram(pdev, i); @@ -553,8 +557,13 @@ static void mv_cesa_remove(struct platform_device *pdev) mv_cesa_remove_algs(cesa); - for (i = 0; i < cesa->caps->nengines; i++) + for (i = 0; i < cesa->caps->nengines; i++) { + struct mv_cesa_engine *engine = &cesa->engines[i]; + + irq_set_affinity_hint(engine->irq, NULL); + free_irq(engine->irq, engine); mv_cesa_put_sram(pdev, i); + } } static const struct platform_device_id mv_cesa_plat_id_table[] = { -- 2.54.0