From: Jakub Kicinski <kuba@kernel.org>
To: Samuel Moelius <sam.moelius@trailofbits.com>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"Jiri Pirko" <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"moderated list:CAKE QDISC" <cake@lists.bufferbloat.net>,
"open list:TC subsystem" <netdev@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v2] net/sched: cake: reject overhead values that underflow length
Date: Mon, 29 Jun 2026 15:42:27 -0700 [thread overview]
Message-ID: <20260629154227.741f2051@kernel.org> (raw)
In-Reply-To: <CAE+C+Da2-t1t76M6T9p=s6frGgOwj8LpOtVxBnmWa6kVHx9kpw@mail.gmail.com>
On Mon, 29 Jun 2026 14:44:28 -0400 Samuel Moelius wrote:
> On Mon, Jun 29, 2026 at 1:24 PM Samuel Moelius
> <sam.moelius@trailofbits.com> wrote:
> >
> > On Sat, Jun 13, 2026 at 5:26 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > >
> > > On Tue, 9 Jun 2026 23:29:36 +0000 Samuel Moelius wrote:
> [...]
> > >
> > > Both Sashiko's complain - these values are neither safe nor sufficient.
> > >
> > > How was the -64 chosen? It looks suspiciously close the min ethernet
> > > frame length.
> >
> > That's how it was chosen. But as you've shown, it was not a good choice.
> >
> > I would like to submit a revised patch that does the check on the
> > datapath, as you suggested. Should I send that patch? Or would you
> > prefer to wait for a response from Toke?
>
> Apologies. I just noticed Toke did reply. Should I send a patch
> consistent with what he suggested?
Yes please
prev parent reply other threads:[~2026-06-29 22:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 23:29 [PATCH net v2] net/sched: cake: reject overhead values that underflow length Samuel Moelius
2026-06-10 0:45 ` Jakub Kicinski
2026-06-10 0:55 ` Samuel Moelius
2026-06-10 1:46 ` Jakub Kicinski
2026-06-10 8:06 ` Toke Høiland-Jørgensen
2026-06-13 21:26 ` Jakub Kicinski
2026-06-15 11:21 ` Toke Høiland-Jørgensen
2026-06-29 17:24 ` Samuel Moelius
2026-06-29 18:44 ` Samuel Moelius
2026-06-29 22:42 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260629154227.741f2051@kernel.org \
--to=kuba@kernel.org \
--cc=cake@lists.bufferbloat.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sam.moelius@trailofbits.com \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox