From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F28743E9D2 for ; Tue, 30 Jun 2026 18:38:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782844692; cv=none; b=mGuMbcuOASdcKPxR9V9PVAYewHTe3d7ePL9XbobZo1XdVeM3xznVegMCiHKJ2pQUrBZJ5pWaCkhV/jHqiRZBFVEh57nU7vtT2jmRY7Nz2tD1MSP6B9mfh/s22Pq3n9LbtWr7e0FPa8enS7r/mATv7uqjJ2Cjl2OTPM/LeZufToE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782844692; c=relaxed/simple; bh=hoC09ruaTFT69doGplUgeUIsoPbyQFsimJQmBj3k34c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AequGUie+KfH2DUcqqhrzhYs9edJ+stjh50cRAyxGbXVXXCoiHihflMhlcOq53/COqj8DnD9F0bD2K9k/FZX8uFhlJCLQdf2AJBuFb+rIiCc0mcEWFJN46UyakoIb8KTQopECmTvXykVa11w8zWVghglPBqFfH3RiJFEA9tw6Cw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dzu50aqz; arc=none smtp.client-ip=209.85.210.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dzu50aqz" Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-7e9fa42f08cso446537a34.1 for ; Tue, 30 Jun 2026 11:38:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782844686; x=1783449486; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=b65anD9BuvaOJmgxeV/E8/NGlo1JDwrV2r97bE3ThlM=; b=dzu50aqzEfLU+c+tFooIZzoOCR7p2LS3UZktfURRIee1gIfIoXorjPB7WenSNkVcU5 ocCZXRseTXELT900UJt1fmFp2Yp3JxQbaCUPvWlRzHFe2RLRN32Tf7/nT2XAv73zVNM8 87M6GC5C6AN38NEHDDaecXg9JccQ7Xtxe7OrHbpaeVtyfijWpSeVQPfiLoKInBw0z7+o wFogbVKqBYROYNFBcP0p3rAqHRtVQu+JXToP2uVIYwKofLZ+cYr5De+uiKn+8zgSKtne SIUMZxSv1uEkaG9mNLXFzeQoVTHBTmi0ytMLdeCrgAeTAkKV1cIrQM6gHSksCEPl8hyh IbDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782844686; x=1783449486; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=b65anD9BuvaOJmgxeV/E8/NGlo1JDwrV2r97bE3ThlM=; b=IjPxWDiA/5ELZL1hUIl9VUzBiGaPHE13hzI2TtGqa3MNFGehl3zi3Wb61tdmzdfBfY jgCOtPZEkp2AAH9mSvLj5jSkMVd57VfGn4YiJZGTJ59OqybGXGdwjDENAh4+y15+Gh0k /nrTCmc4yf3Q8GPrCIU0gAZk1m4WqzWc+igD8zQtBr4q18xNCc7TCt5T8ivdQ2F648Gj XCkeC7+19kwT6UVDbkhMpAwpd3urybvVdXr5VWQqzOm6aEfcxoht74HGWQuI5GVdOCAc 5em/+4uj2OasPgnuFKlVwxilLlKwdw8CwYIkfmcOyiRgtM6PKFcQVo27z5WG74x7WK1X swqQ== X-Gm-Message-State: AOJu0YxcnBAuMoBwe9WJ+/r63w9/RPjTAyiRdBsh2K+o3vgm32dHBMHk B+lFLsMffhqSEyV6YdsdtJiW5KtjvX8kts52kjrFnPcEL0ziduCz8h6v X-Gm-Gg: AfdE7cldoduafjgk0OdzleeiJhuip6IHV7L1nR43A2Ur1lxd+Y2ooEOYRexoq0HDWc3 HBUDUzwC1FRBrzFkGXEHNIcJouj3lUuT8MlDuCRSGcwAh/bMIcGgfKvNrag1vsX6ff/Ag9KIRO1 aKFrR9jeYNbNj7gXhdtXPc8m2kJvWQHjh5+AzQ2/fN2UpU4EslzXfPRQtF3/ffb11J0UJs/ePfZ v8ZeNYhOo9NE3JHe4BEe8z03chhXAxY0jE+qV0H8XLwn/H8RiN0p4k50m3XTAVSIG6/sNpt9b+y CwAn1yVDCe0Jk75n/12Q+J6SajLwoeSMXvHM3y4p8JmGvgqQgCUF1vJOGeioAWr7elJaTey1pdP ObeAxUKP2hujDpgQG20+mQqPXKIwfukGtot6TCShVYRSlrA4CTK5zooFUrJPCU6wbEmDY4lBViV ovK/FNlrcmoes7rvw3IZvs+zRTplQlL8w4O1bUU5yMIme6VJcqing= X-Received: by 2002:a05:6830:61c5:b0:7dc:d2ad:fb17 with SMTP id 46e09a7af769-7e9ec71820fmr4379028a34.20.1782844686104; Tue, 30 Jun 2026 11:38:06 -0700 (PDT) Received: from [192.168.0.245] (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 46e09a7af769-7e9ebfd6ccfsm2940025a34.11.2026.06.30.11.38.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 11:38:05 -0700 (PDT) From: Jim Cromie Date: Tue, 30 Jun 2026 12:37:54 -0600 Subject: [PATCH v4 5/5] dyndbg.lds.S: fix lost dyndbg sections in modules Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260630-fix-align-v4-5-42e6ec883342@gmail.com> References: <20260630-fix-align-v4-0-42e6ec883342@gmail.com> In-Reply-To: <20260630-fix-align-v4-0-42e6ec883342@gmail.com> To: Arnd Bergmann , Jason Baron , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, Andrew Morton , Jim Cromie X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782844678; l=5103; i=jim.cromie@gmail.com; s=20260203; h=from:subject:message-id; bh=hoC09ruaTFT69doGplUgeUIsoPbyQFsimJQmBj3k34c=; b=JqM++F8Z5lD89pPJJlwRxqb15MODc0Eml/zw43zB31ivt3aYcSusufSMz8JwZ8ZNgQBTXu7UJ f3hbthilk8rDMSnPQsasbcBPxv+d0HqlTxywE1nV0dvdNg1RZo+WcSo X-Developer-Key: i=jim.cromie@gmail.com; a=ed25519; pk=C6E5ODlPQo7ZBynATXH9wg7K6HxP0pIXyf4s38Qw0XE= With CONFIG_DRM_USE_DYNAMIC_DEBUG=y, several build configs had problems with __dyndbg* sections getting lost in drm drivers. Fix this by following the model demonstrated in codetag.lds.h. Introduce include/asm-generic/dyndbg.lds.h, to bundle dynamic-debug's multiple sections together, into 2 macros: vmlinux.lds.h DATA_DATA: move the 2 BOUNDED_SECTION_BY(__dyndbg*) calls into dyndbg.lds.h DYNDBG_SECTIONS(). vmlinux.lds.h now includes the new file and calls the new macro. MOD_DYNDBG_SECTIONS keeps the 2 sections by name, aligns them and sets the output address to 0 when the sections are empty. dyndbg.lds.h includes (reuses) bounded-section.lds.h scripts/module.lds.S: now calls MOD_DYNDBG_SECTIONS right before the CODETAG macro (consistent with their placements in vmlinux.lds.h), and also includes dyndbg.lds.h This isolates vmlinux.lds.h from further __dyndbg section additions. CC: Arnd Bergmann Signed-off-by: Jim Cromie Reviewed-by: Petr Pavlu --- v3: move #includes to top, drop extra ALIGN(8) in DYNDBG_SECTIONS, add RvBy v2: Address linker script review feedback for relocatable modules. MOD_DYNDBG_SECTIONS() used the BOUNDED_SECTION_BY() macro, which proved problematic for kernel modules for two reasons: 1. Unwanted Empty Sections: BOUNDED_SECTION_BY() automatically generates `__start` and `__stop` symbols. When applied to `MOD_DYNDBG_SECTIONS()`, the linker assumes the sections are populated due to the symbol definitions, forcing an empty `__dyndbg` and `__dyndbg_classes` output section in every compiled module, even those without dynamic debug configuration. Since the module loader uses `section_objs()` to locate data via ELF headers instead of relying on `__start`/`__stop` symbols, these assignments are completely unnecessary. 2. Non-zero Output Addresses: During relocatable linking (e.g., `ld.bfd -r`), omitting an explicit base address causes the section to inherit the current location counter. This results in non-zero sh_addr values in `.ko` files, which is confusing, degrades compressibility, and can cause issues with external tools parsing the ELF. Fix both issues by dropping `BOUNDED_SECTION_BY()` in favor of a simple `KEEP(*(...))` constraint and explicitly defining the sections with a `0` base address: `__dyndbg 0 : ALIGN(8) { ... }`. fixup-inc-vml --- MAINTAINERS | 1 + include/asm-generic/dyndbg.lds.h | 18 ++++++++++++++++++ include/asm-generic/vmlinux.lds.h | 6 ++---- scripts/module.lds.S | 2 ++ 4 files changed, 23 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 15011f5752a9..cfc2695d9bbe 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9178,6 +9178,7 @@ DYNAMIC DEBUG M: Jason Baron M: Jim Cromie S: Maintained +F: include/asm-generic/dyndbg.lds.h F: include/linux/dynamic_debug.h F: lib/dynamic_debug.c F: lib/test_dynamic_debug.c diff --git a/include/asm-generic/dyndbg.lds.h b/include/asm-generic/dyndbg.lds.h new file mode 100644 index 000000000000..9d8951bef688 --- /dev/null +++ b/include/asm-generic/dyndbg.lds.h @@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __ASM_GENERIC_DYNDBG_LDS_H +#define __ASM_GENERIC_DYNDBG_LDS_H + +#include +#define DYNDBG_SECTIONS() \ + BOUNDED_SECTION_BY(__dyndbg, ___dyndbg) \ + BOUNDED_SECTION_BY(__dyndbg_classes, ___dyndbg_classes) + +#define MOD_DYNDBG_SECTIONS() \ + __dyndbg 0 : ALIGN(8) { \ + KEEP(*(__dyndbg)) \ + } \ + __dyndbg_classes 0 : ALIGN(8) { \ + KEEP(*(__dyndbg_classes)) \ + } + +#endif /* __ASM_GENERIC_DYNDBG_LDS_H */ diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h index 3758a79d0430..bd60f278f762 100644 --- a/include/asm-generic/vmlinux.lds.h +++ b/include/asm-generic/vmlinux.lds.h @@ -52,6 +52,7 @@ #include #include +#include #ifndef LOAD_OFFSET #define LOAD_OFFSET 0 @@ -344,10 +345,7 @@ *(.data..do_once) \ STRUCT_ALIGN(); \ *(__tracepoints) \ - /* implement dynamic printk debug */ \ - . = ALIGN(8); \ - BOUNDED_SECTION_BY(__dyndbg_classes, ___dyndbg_classes) \ - BOUNDED_SECTION_BY(__dyndbg, ___dyndbg) \ + DYNDBG_SECTIONS() \ CODETAG_SECTIONS() \ LIKELY_PROFILE() \ BRANCH_PROFILE() \ diff --git a/scripts/module.lds.S b/scripts/module.lds.S index b62683061d79..2e62dc5bd5d4 100644 --- a/scripts/module.lds.S +++ b/scripts/module.lds.S @@ -10,6 +10,7 @@ #endif #include +#include SECTIONS { /DISCARD/ : { @@ -61,6 +62,7 @@ SECTIONS { *(.rodata..L*) } + MOD_DYNDBG_SECTIONS() MOD_SEPARATE_CODETAG_SECTIONS() } -- 2.54.0