From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D67FE223DE5 for ; Tue, 30 Jun 2026 01:09:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782781770; cv=none; b=LVBYgeowZYy+CerWOrl7zV2FPcjyhXN0vlrGDHrfjvKP4jdYUoYHXQrLZ8QXULKheQe26DNL05k2GL/cZJ/dWoebNjrzvlZ6PQb82jXviCVuNUbbz9IGPhY1fN8UMyK3Wy38BO6ebEBKOLs/MYlUZej1TCr5hNxXYIeB6Mk4x0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782781770; c=relaxed/simple; bh=VIYVEeqg5Uru7TpS/SsXJahR9C8vMWAkOIUv367sfj0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LDN9jkZhH8S0Vzu9sXcbWmb3seorOL2PGII8/hS9u1+4vQpTQh5m2NQRxo6W5iqVeVxwiucKN4S3kGyPFgLewvt5UxhZW/RKmgcjGiYtpWCCkrGD2DzERr12ezpPK2kqAaEOsXUo+LoUNOclRrjZf/lffCEW3Frs6PxXkqHGyXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qk4Ou1DF; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qk4Ou1DF" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-474560436c3so1090869f8f.0 for ; Mon, 29 Jun 2026 18:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782781767; x=1783386567; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Um9ErCcdf49zk6uB2lU45UAxhDbw8UL4WZ7Z0MeU9XQ=; b=Qk4Ou1DF5HVj2+H02aHBc0FqMeQTyGB/Z/RhvXWpkhj5t6VIUn885r3foUlflUWiwF gEh+Ae8XPQ+AK4vCePGmZuZrf+49koFGj5KIhr8FsnKVcEyyLXFbOR9L882+of5icfOm IIrn81sVtcTzyS6rHbSNoGCc71ao+VlqrEkE1i+pyMHADnzVmtnUb+EAPMbZnK2PhEIL Ovd4l8E8KwAvijZQ61ahF6cgrDYfH7sY2+UHiKdOEor167AKGkKwIPoP2FPQp4pSxbtq 0Q22X0ZD0feYIT/Z2JPkyY5sicikanOHLTG0QhLfzssKP5hZR1KvNfFKVxZxyXQJFYN3 tt4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782781767; x=1783386567; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Um9ErCcdf49zk6uB2lU45UAxhDbw8UL4WZ7Z0MeU9XQ=; b=rn3DsqwtrFVgOxR+sd8cgm3BdrO7IaFxgRNEpSIi4Ji0I4irtvL1aH0KUaMYv14B9c o3Sz7FMTQT/8OMihMpr3E9/J2SHISpWEoxXUrBryJMajcPspjotkZefonXsQmfPb6RXG UXv4R1/bu+ItEo/0hhMC5ulyJz6qlm5sOKjRvjGXqTqsVaTPoBOzLkmDsLPvBsyl2hgu wIY7rty29RBMwh9KBNkE/Sp36jNNJur+754ccWKwijTRzfljcRrEzUuI3F61RGC+Dyzj OB44XzcfSPkkl9eFMSA8/sgnukNLASReS+Op4H+skTV8Q3paYQChh+e6wT5KXqEfKM8W uhJw== X-Forwarded-Encrypted: i=1; AHgh+RrMIUrIalyyaJ0k6lEquoynGCLtmf96gaOqAJtQ298gO7M+DDPtgSjz4sk8/axmMTkV4zm/1MrRe2uf3xY=@vger.kernel.org X-Gm-Message-State: AOJu0YyYp4xr5Xlj9jXWWtI9spjeHa4eM4DoKlGC1Fi2jEtdSkB9inK0 xFFLlz7MEO0dBoZBqil4NvvtRE4ZYXRUZBRQDVI95PVYvS1wuxzIkOsE X-Gm-Gg: AfdE7cnQudWz8OPD8yEEY8aUECRw3XzI0UWbIjoS0HZx/j8YdyjDuEjjBeDxvQ6kyXp LPkgxHAEr92xSUS9EOK35HwKerMuEl0kY8gkmin7U6hGb7bi/F7XMUddBzyHL5rkm+uP7MEEkdM h6BkEDEGNvW2GvMY2qzoKdvCBDNf2s+Vt1o7mJjDXiYbrBHCj/br9MLUgZv6vPuqQdpkQqOce3C JUC1q8WyDZI5oqRaXqhwkxG7h4NffEChuvSsSVnQIVzvUjJbJ6rDFfXXoxGDh+WoTM7MIvfeCtK f+Dd/nBefKJx7fXh/Z/U8+fCG536GNPazJBo7Vn9yk2yyYM+9OjfHRiuyEeFCRZ5Pk0T3MOs+Mp QsXTMLLE5/bN84ENPBly3El9Csulh2UREIScLiJ8OnLoM1YFmxIo0x7ZF3J9XzLQ3jUSXTx3UAX 5C5XVNJFf5TwmIunbx/Qnor+HCRfOVVil1scLuY7a6QFNmbnRwS1VNLxtWd2Ku5rYtE8bKMj70m +VCsQkWV9JBXJRYf5yY1n8= X-Received: by 2002:adf:e011:0:10b0:46f:558:a42a with SMTP id ffacd0b85a97d-47552a6910fmr1364141f8f.34.1782781767303; Mon, 29 Jun 2026 18:09:27 -0700 (PDT) Received: from snakeroot ([2a05:87c3:2001:7400:25e9:cccc:54ef:5829]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-475671d02f5sm2977891f8f.28.2026.06.29.18.09.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2026 18:09:26 -0700 (PDT) From: Stuart Hayhurst To: linux-input@vger.kernel.org Cc: Stuart Hayhurst , linux-kernel@vger.kernel.org, Benjamin Tissoires , Jiri Kosina , stable@vger.kernel.org Subject: [PATCH v2] HID: corsair-void: Check size of status and firmware events before reading them Date: Tue, 30 Jun 2026 02:06:56 +0100 Message-ID: <20260630010656.626157-3-stuart.a.hayhurst@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Malformed status and firmware events could cause an out-of-bounds read since the size wasn't being checked. Check the size and warn on unexpected values to avoid this. Fixes: 6ea2a6fd3872 ("HID: corsair-void: Add Corsair Void headset family driver") Cc: stable@vger.kernel.org Signed-off-by: Stuart Hayhurst --- v1 -> v2: - Ratelimit the warnings - Accept packets larger than the expected size --- drivers/hid/hid-corsair-void.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/hid/hid-corsair-void.c b/drivers/hid/hid-corsair-void.c index 5e9a5b8f7f16..071a663a6c26 100644 --- a/drivers/hid/hid-corsair-void.c +++ b/drivers/hid/hid-corsair-void.c @@ -92,6 +92,9 @@ #define CORSAIR_VOID_STATUS_REPORT_ID 0x64 #define CORSAIR_VOID_FIRMWARE_REPORT_ID 0x66 +#define CORSAIR_VOID_STATUS_REPORT_SIZE 5 +#define CORSAIR_VOID_FIRMWARE_REPORT_SIZE 5 + #define CORSAIR_VOID_USB_SIDETONE_REQUEST 0x1 #define CORSAIR_VOID_USB_SIDETONE_REQUEST_TYPE 0x21 #define CORSAIR_VOID_USB_SIDETONE_VALUE 0x200 @@ -742,6 +745,13 @@ static int corsair_void_raw_event(struct hid_device *hid_dev, /* Description of packets are documented at the top of this file */ if (hid_report->id == CORSAIR_VOID_STATUS_REPORT_ID) { + if (size < CORSAIR_VOID_STATUS_REPORT_SIZE) { + hid_warn_ratelimited(hid_dev, + "unexpected status report of size %d", + size); + return 1; + } + drvdata->mic_up = FIELD_GET(CORSAIR_VOID_MIC_MASK, data[2]); drvdata->connected = (data[3] == CORSAIR_VOID_WIRELESS_CONNECTED) || drvdata->is_wired; @@ -750,6 +760,13 @@ static int corsair_void_raw_event(struct hid_device *hid_dev, FIELD_GET(CORSAIR_VOID_CAPACITY_MASK, data[2]), data[3], data[4]); } else if (hid_report->id == CORSAIR_VOID_FIRMWARE_REPORT_ID) { + if (size < CORSAIR_VOID_FIRMWARE_REPORT_SIZE) { + hid_warn_ratelimited(hid_dev, + "unexpected firmware report of size %d", + size); + return 1; + } + drvdata->fw_receiver_major = data[1]; drvdata->fw_receiver_minor = data[2]; drvdata->fw_headset_major = data[3]; -- 2.53.0