From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC8373E7179; Tue, 30 Jun 2026 09:10:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782810623; cv=none; b=a5wf8IVCdtddMEqKYqQaYZTuKIIvha+UZMt6XWDE4WEeXBC3Ncd2BZax/EQNOPr9c41C2FexIK4XOU9Ye7GVQYLYBIstXN75eHpLsAcSoFYKXHf+w98sB8pCOfIF02KtWqUFZjH1vN26+myeUqViojFEavO2mAdvOQ54S47dphc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782810623; c=relaxed/simple; bh=T7e72CBskmfISEhz++wv4MqzXQUqPw/zu/9p0Fkk/uw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=vFVaRjnzsCv6Wc4VLImGzOISphNEdJEsWRtH5DSQQFgE2DN8qMdnpbco4SSeyjHL162htnW5afHN2DSxJbnNMMJIZp2GuhKgbHfUEytqIAS0ECGR1Io81LFcqca1ZPg/CwxjW4txBXkC+jgEmyKXrNQsB82koySAtSVUeYF+BcU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=o0Z87GWh; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="o0Z87GWh" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Pb2yAbH4dyk/4HbQ8UilLFKHGlvIdyNhvt4uOthzHxw=; b=o0Z87GWh7YMs9ldQ39sqLjHYk9 0lcWfYO2w9r29bG20sImVRbIJQWHD0Ei9e4hmiQ3wdtU3rP1dGYiJANlcpYmIFdToNwMgYf2JcCDu 4KpdWTXp6CyW8iaHGddTf10JSiw3F2FUp4uMNZ23Ccf5FQ51XwAxItXAJz7Y7M/GanZFRg3KFTJDq Wkbz1bUxfawJUE0oc6iGLlT1yo+/g7rL+YwVJkmQGMSk2wdTQdfvp6LYHNyjyjdlWSusu9uPUBy2B lEw1au172zctRfknrKZtm3xzW7ytqSkhKNvBFaiu1syXnK82wMogJxeoEa7KXOTlIM60cV2Xbd5+P i429u0sA==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1weUTx-00000004gl3-0Jxs; Tue, 30 Jun 2026 09:10:17 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 3A35230036F; Tue, 30 Jun 2026 11:10:16 +0200 (CEST) Date: Tue, 30 Jun 2026 11:10:15 +0200 From: Peter Zijlstra To: linux-kernel@vger.kernel.org Cc: linux-tip-commits@vger.kernel.org, Zhan Xusheng , Ingo Molnar , x86@kernel.org Subject: Re: [tip: sched/urgent] sched/fair: Fix stale comments referring to removed CFS concepts Message-ID: <20260630091015.GA651302@noisy.programming.kicks-ass.net> References: <20260629030200.3165589-1-zhanxusheng@xiaomi.com> <178273159419.3843924.17455384806679869461.tip-bot2@tip-bot2> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <178273159419.3843924.17455384806679869461.tip-bot2@tip-bot2> On Mon, Jun 29, 2026 at 11:13:14AM -0000, tip-bot2 for Zhan Xusheng wrote: > The following commit has been merged into the sched/urgent branch of tip: > > Commit-ID: 17fdabfa3aeca3d07846a8d56ac0abf61b58bffd > Gitweb: https://git.kernel.org/tip/17fdabfa3aeca3d07846a8d56ac0abf61b58bffd > Author: Zhan Xusheng > AuthorDate: Mon, 29 Jun 2026 11:02:00 +08:00 > Committer: Ingo Molnar > CommitterDate: Mon, 29 Jun 2026 13:11:52 +02:00 > > sched/fair: Fix stale comments referring to removed CFS concepts > > A few comments still describe the pre-EEVDF CFS world: > > - sysctl_sched_base_slice is documented as "Minimal preemption > granularity for CPU-bound tasks". That was the wording of the old > sysctl_sched_min_granularity, renamed in commit e4ec3318a17f > ("sched/debug: Rename sysctl_sched_min_granularity to > sysctl_sched_base_slice"). Under EEVDF it is the default base time > slice / request size (r_i) used to compute the virtual deadline, as > documented in update_deadline(). > > - Two comments still mention sched_slice(), which was removed when the > fair class committed to EEVDF in commit 5e963f2bd465 ("sched/fair: > Commit to EEVDF"). The dequeue-path comment should simply refer to > the task's slice (se->slice); the forced-idle comment describes the > slice accounting now performed by __entity_slice_used(), which is the > function actually used right below it. > > No functional changes. > > Signed-off-by: Zhan Xusheng > Signed-off-by: Ingo Molnar > Cc: Peter Zijlstra > Link: https://patch.msgid.link/20260629030200.3165589-1-zhanxusheng@xiaomi.com This is comments, cannot be urgent. Also generates non-trivial conflicts against the patches I just stuck in sched/core. So zapped this commit.