From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB1CE3B3BE6 for ; Tue, 30 Jun 2026 09:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782811457; cv=none; b=HL20Gw6dWDMIEzPLHtLQVoqZAvwe0BXjSuEeE1lbu9QoXy/aGE9fWl4iFEzgjPGCIBIlCtavLXn87nK6ODjz8NBI+gTcxasv67kdkQkYoHopz5AgO4DAvqEJmu34VRWLILOkGgCYdGIv8Zfgn4Bv3+gIls3DCxsULDTSM2e/fAo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782811457; c=relaxed/simple; bh=A6EPhTMbS3vjYOiJgMEa8aWR5qZXhqH0UX+pI3asK3U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=kgprE/elJizW55yL4cLfuhILhCyJ8Ci+XpTIcPlbVtCZdyFrMYFzBYzt1jTDiaTuQPmS8S2bKgzltRieNnsnZbXsM7ij9nr0mcIpH9Nzb9pRaUv69Py6qvLySCrqhGIFMOl7e/lCRVrIeRhsTwAq9Vau8I7WylWdMvvZRBHUDJQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GBkQ2Sij; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GBkQ2Sij" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-39b1eb7bde5so5415311fa.2 for ; Tue, 30 Jun 2026 02:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782811452; x=1783416252; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=G5xs4hoErIQ707h1RZp1OKSQ27v7mEF04kyqQffgd8E=; b=GBkQ2SijsCREtcD549KOJT7IC71/uT2xF/OThDM5Cdbea0RGT7kDE803WQzsM1a/Wm KMHORhUCIeMg0X0EjU0/XvpdbK/JF+BTz7hZkTZPKlMqWtagOYKUTlA0CJa0Da4Y20bU t5X61Ledtk3wJlTNhOnf2rPG6v33Hb8OmTvoa09S8OkZgbt9qC8eQ+PwGe7AwVLmWrK5 TpaOfCDYH/nypUF1452n3ZjM0I9F/KnQ/vuV2ZFVBHIPuoema1kc93RWeIa513h/0NjQ /6reK4bSs072lgRnoYhuYnFhnbFsU8qZtCStgMr/lHwONtTlUTTSSvt+8jM3edTaaF8q VgZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782811452; x=1783416252; h=references:in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G5xs4hoErIQ707h1RZp1OKSQ27v7mEF04kyqQffgd8E=; b=bOKNgPE/FCXpf8O8DUqCQI9rNM4Zl9ny05r5ZXKjsHI3VIaqWl/JBt/pYOdAFYwiER FeOIppR3sOYQ4CG5wZEB5NV7tuF+mkNGU1WNSxaBc3zlebT5vqJP/UmnIlqy7kNOc6Vs cZ59GV5q8/CS38kVcKAs8aPU2bTqe4/P+mSVHVYsAldFEFf13q1Lusz5o5aDiPF+MdGV pInjxXMqzUHzPCvco+2V90kZ+63x5AhcFFZRQ4uR/0rTNl9iSsJx/iR3SHwlBVmlSqXV Sv4hQPPMfnMkX8g2NIcF/mpCIhf2pf5+Tj1LFhBY0KlVTtjQPe8VIyzJlx20rgXrohau fm2w== X-Forwarded-Encrypted: i=1; AHgh+RpQvzjYx+PJW9vtXjkTlj40H08+ohUU/pYwxQ3cXQRXGJdcHvD3g7kOMAzACu3l/CYK2QpsP8Sg2KEBcgw=@vger.kernel.org X-Gm-Message-State: AOJu0YyIJt9MpQFBQL/0sbstTFFnqebr54urMUy3BZJGxjwqyzAE/Xhv 5j1rZIpOCbfiPn92AjnxsspHPMyp8E2umtcz1AL9aoXBcmX/HYY+fb8X X-Gm-Gg: AfdE7ckBeUfM6DWzgBM0DGW7CMDbmnhSZGdKn1g9eFo/LA+fEclkKzIyc4Tf+5S98bD Mu3zm6ZOvh7WENrePelj1wF035s0Dge8Q/PKaQ+YAhq641tzeqi8uXh8fff7mitOrqY9/bZl4f8 lhuVi7xtTdNY3XH2BmkFX7k7cSnyZSYe2gKzluAWRRxKM1NbKp5OruyuAGks4lZYIOBOQgboYMh RrklDwhNZl3c6ApQ8kv1xQFM5oIITQxtHEgw4C6ptGFLwnpg6J+4bUFtlZV9c4iwkrrDeLsCyyk 8bJN1a/miu1MBBlU+nohBAPzcg0WLc5rNPYHbhu9QcuyI0bGx0eioWz+ydpyLHmOPROaSEIahk7 qHF4nOfNaMqcbAVNvzH6XQj6y6i+rBtSCMo+SI4ZgmWDVVcY6hGx/t+w2RkGsmAVEVpE9qFwasb gRW+RTFcYNWos+545C/2ruh+igEbcdfT98SUnzPOQy X-Received: by 2002:a05:651c:2203:b0:39b:a75:e8da with SMTP id 38308e7fff4ca-39b1da60a98mr6861121fa.3.1782811451521; Tue, 30 Jun 2026 02:24:11 -0700 (PDT) Received: from localhost (c-85-228-45-68.bbcust.telenor.se. [85.228.45.68]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39b1da1d26esm4364391fa.25.2026.06.30.02.24.08 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Jun 2026 02:24:09 -0700 (PDT) From: Eli Billauer To: gregkh@linuxfoundation.org Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, Eli Billauer Subject: [PATCH 2/7] char: xillybus: Remove duplicate error path code Date: Tue, 30 Jun 2026 11:23:25 +0200 Message-Id: <20260630092330.43534-3-eli.billauer@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20260630092330.43534-1-eli.billauer@gmail.com> References: <20260630092330.43534-1-eli.billauer@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: No need for dedicated code for the error path. The removed dedicated error path code differs only in when the mutex is released, and that makes no difference in this context. Signed-off-by: Eli Billauer --- drivers/char/xillybus/xillyusb.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/char/xillybus/xillyusb.c b/drivers/char/xillybus/xillyusb.c index a28e6416cb01..ab5f9159aa17 100644 --- a/drivers/char/xillybus/xillyusb.c +++ b/drivers/char/xillybus/xillyusb.c @@ -1419,16 +1419,12 @@ static int xillyusb_open(struct inode *inode, struct file *filp) if (filp->f_mode & FMODE_WRITE) chan->open_for_write = 0; +unmutex_fail: mutex_unlock(&chan->lock); kref_put(&xdev->kref, cleanup_dev); return rc; - -unmutex_fail: - kref_put(&xdev->kref, cleanup_dev); - mutex_unlock(&chan->lock); - return rc; } static ssize_t xillyusb_read(struct file *filp, char __user *userbuf, -- 2.34.1