From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A67423392B for ; Tue, 30 Jun 2026 14:25:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782829552; cv=none; b=eWrZe/eSA6ZsbnDZ4ugAcYGnkl83Xt0WVgPj0qX5xZu713oHHaNvXdht04AK+BlKM0wlgnGeN49oMMf2rdj2mdhlJBmSd0vH0jpRatNPaYl0V0Bila/0ahWqeKm1Le+Z5VmEiBZXYmR8MSsZnPmDptPA6+fNz4ngaIOnnM3vs/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782829552; c=relaxed/simple; bh=LyaBlvtzLg3/D7avMailtRtNnHXXt7CQFthCD76A1P8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ASOhh+nhrGb/Q6ptcjgDypXDEEkJ4kT5vzZUg7DWwVEce/8mu8xU1c+Uj26rWmnfXu/FMO0PHb8VHly3DtFjbiBWv15x/53iEgcTf2iyaHtj4eaGPSZtNJ3ltFOrS2qSE/jDLh75+31CpMmBzHdPn+AeQyM+ahNDYdsSMEVu04Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ffX2DPgP; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ffX2DPgP" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5aeb24c0807so2271529e87.0 for ; Tue, 30 Jun 2026 07:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782829549; x=1783434349; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LyaBlvtzLg3/D7avMailtRtNnHXXt7CQFthCD76A1P8=; b=ffX2DPgPu2lj+UsLR/HCW8N6z70nkMU9vCUAjP3gT4A2arYVx+A+3TGDJIePpHtcrh jTq2nmZqB9kxFabBvJCgqbNa5lCU3MrZD0CatgyHQxFivKmRWB1BIF6839uSoiUx6z8C 0PNCe2JlVDcQfuDkpJk07MalDRgtYKALRYl14LJ9KmlTINzQFTExrDFAn+KAiCTsvmgL lWRyM1GeOXpjCStkfdwfafmdkEPYX94NvbqLjIS4j6JFLwk4TvBXp5RqQChRaHxKOJkd E1hYtnf8ie1fvEGT8wJjzf2fYELhx3e/Qk1DgKk5oOlBYHuIZt3dDcHEM0v6voXus7oe 7pOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782829549; x=1783434349; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LyaBlvtzLg3/D7avMailtRtNnHXXt7CQFthCD76A1P8=; b=iUPUn045jS9u9fjGdMFq3K71365SHcgelU6Fd3jMvB4W8d5SOQUn1ZtZqoIE0ah3rt 654GafgHLoUUMiSICRlAtC0w7I9rMz5txEJqoO3BTTNWZqWeZbykOV4GQ/3Lk/84yMFX LBuUBHb06+XuYwvzkR0Lk/vViKDRDzZC1TIWSl8JTGDHeu6zgggoh4JEe4doRvkbm1Xo 1yRHlvNsFWK/V2g2a3LpY3drs3AoDMfALOVPp/dgOwxZndOHKFX1mz9LKtSEqHBW3QSc Tdf3Ip8536qSG5ivVtIiY78NfIeQyvzD+EBXL+BNWlSa/ZO079spitfMrNbklFMURGEA hNrA== X-Forwarded-Encrypted: i=1; AHgh+RqqGNm25gCT1BAxEyt8B58ttgRvX1DvYTHNcPxMWpgXBLBa7v+DxC1bL3ssb52icV3FxlfyJyz8XDasuoQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyWXLaCrPdbd3UZ5Tv5PNsbfAqr8pGIhIku9QGgP8vjj6LcIcJW yMPpddehpC66qQo5gyh4tTjb3hYfgFtkVDTn6U2vdwVq0iBtVkMKx6PGSvQqdusapcY= X-Gm-Gg: AfdE7ckNHkrlTOS6X6MUeANpRgEcoXr4z8wyF0iBzskgZiBi53HK03VhUEqqvP6wwXW 9q/9NhioEaVbTNYpjZpTjjklwngAR8LkIS83tdPWjnQiHqe6hei/o8e7Xy4YafuVjWf8TXoTPgI aWlElP1WrDRkH3vzwYMjtwotFsvpMsFXcaGB31LkyST1E4LjJUR/mwQUqzo5+omVTBQEu9V+n+w Tecj/bLvpoid9jdDQe6j7VkfSuqQGS7yFPTjNXuuoC8Q0rE6YJovSz2SRD8kn83eHVeX6pzX3V7 fYDhExGTSdrq+lf1SO7S1N4N5Pr7Yqqr/5Upuf5NN6YURIUS5eB4uftGdq+Z5F2g6vmlcn/Q1RK nvqs3ymmfDn5WC5GsdrQmBmAV9yHYNoqLSQZ3jtLbO2IuW+ECAizZEA+x7AsE0ISv7SpjTenSNu THg2O35882Rt3P94tqlcxHqFmEVCmMmOHhVO/iIpbqIiN12OytUzRgbPQDbZQPGr6vmVK+8vIjl Snh0JJ+LcqxvDNd+Q== X-Received: by 2002:a05:6512:8050:b0:5aa:6fff:c3e3 with SMTP id 2adb3069b0e04-5aebdbc6e03mr726250e87.33.1782829548247; Tue, 30 Jun 2026 07:25:48 -0700 (PDT) Received: from debian.localdomain (95-25-158-125.broadband.corbina.ru. [95.25.158.125]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aebe4985eesm629795e87.46.2026.06.30.07.25.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 07:25:47 -0700 (PDT) From: Igor Putko To: sj@kernel.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon/vaddr: remove redundant RCU lock Date: Tue, 30 Jun 2026 17:25:22 +0300 Message-ID: <20260630102400.reply-damon@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260629165349.4260-1-igorpetindev@gmail.com> References: <20260629165349.4260-1-igorpetindev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi SJ, Thanks for the reply and the pointers! Regarding the issue Sashiko AI flagged - I dug into damon/vaddr.c, and I think it's a real bug, but it's isolated to __damon_va_three_regions(). damon_va_walk_page_range() is fine here, since lock_vma_under_rcu() handles stability on its own. __damon_va_three_regions() is the problematic one: right after mmap_read_lock(mm) is taken in the caller, it sets up a VMA_ITERATOR and runs for_each_vma(). But mmap_read_lock doesn't stop the OOM reaper from running concurrently, setting MMF_UNSTABLE, and leaving empty markers in the maple tree. Walking the tree in that state without a check_stable_address_space(mm) call could lead to a NULL pointer dereference. Since this looks like a separate issue, I'll prepare a dedicated fix and send it as its own patch thread, so it doesn't hold up the current cleanup. Let me know if that approach works for you. Thanks, Igor