From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2533377006 for ; Tue, 30 Jun 2026 11:08:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782817707; cv=none; b=A6WRc8RO/L8YkSoXidxPZNIIrG4O87wgyzptKpYvNMPU8Vt+Lv7zv4JIbqMW+SiSKcPZfuwBm4kmkqa1ysBdPSos9CbVAACOwUnz+ZMj6seFC9ufvlVPmrgJR6UIh/1sL2POx55u0VWqOYaxtSp4g4n0ntSHdYjrtsnhL8yjHpc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782817707; c=relaxed/simple; bh=UhLHL3u+f8vmIRPpQfw0sweKyA+oiVJlf1tWLCUZqSA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lfqB6nR+KH3aMrRScNOFUt/aEftFWyJj+P1pmvON6X7TOyxhv9NwEeNGihBjDAO1iWZTXguIAL1YW4eBMXpVSuHW3jnOVweON0BaRy6vPGulPrCP+YaGgj+lBjN2HFXLE2jKF/Gm5JbCm4zbx3wAitVckqfxQmT1422O8kf6lwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZsTnNZyH; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZsTnNZyH" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-37fa53bc22dso2893490a91.3 for ; Tue, 30 Jun 2026 04:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782817705; x=1783422505; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6bh4jBEphMG7ihkZ16kaaoOAnDIWxUT6Wo00wnq5q+E=; b=ZsTnNZyHpikj7hzYAVpdFtISYte0zsw2WzOs0o0spHTiJamDcMnRQH1Tfr9440SQEG W1U105LjhmKaaKCMu6JEBgMeNtq5OcaYgSD7cUqzuxC8m2RI6QSX9ey3kWz4Ms3xd76+ ifqmaRcYNdEqp/PpKXhK1YGgUSogsh0at56TbtTZibZGkJY5sAxrKJghbKKFOMXXMcMn dj973p+T0RveLwCEPLaaKk5Tfn9QiQ0RLvmXQJJlUUXlcWw6ieUqAcOE736j4787tOm6 Dig3+/EnmWFem4uETwF5E+i16262WmJDM/1NzF3WgHsESPufIF5hJnHJ2mzDmdlFhsGZ 12eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782817705; x=1783422505; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6bh4jBEphMG7ihkZ16kaaoOAnDIWxUT6Wo00wnq5q+E=; b=YgCJR7F8QBDQ9dylGObKrxBAZ7uJSaEr81H8bFXw2kGItvqk9y1gjj7RQ4XmrSPO+B FP6zSI3PXqBZfWwU4bDJ5WeVtgO81e/67IrL5LWytsIPYT96Wk13FwR2oDGGQGl8AB1N DQsi9JVGoRXE5R8wUIARKskWnaLOg5k+W/yB3FvNN1V+OdH4SS7XIek+wqej7cQ2u/K1 AktOHoRVlsBi8nA68amjcNhUFV0hNdYGm7gHAjVAv3BlOEjRlys51a1Cajg9mxXKP8Um a2Z5EKPH/r98MFCU01TlQK4DctbJxBsWBwnnygMClxGMpxEOf3IC80dRbF7+Lr7EwXRm m0dA== X-Forwarded-Encrypted: i=1; AHgh+RpSM/GksVIkjtn+tsySogtarcsbDn+jBRh4p5bJBJBIKnQxg/9Tm36gVKx34DqtKCibYazIdRh+xzY5Yhs=@vger.kernel.org X-Gm-Message-State: AOJu0YzimTI8aSQ4gSFcKBtDgj6gQbA4r22YJJ+7fiXgQTWrP8tHwz5P Wr5VfOyfJDm1nJup80LbL55SMELnxUjCZr0mZjJ9JxOHFEdeYZ9IKZwT X-Gm-Gg: AfdE7cmt8do6D0xpysXtNv6Uo9qmOfVQhe8k8gDNMZryRJ2lrS1jODHJ533PlgonBYM oPBKl3cZPey7uzst9cU9kwPb0yJfd2xK6TI/y81EZMf/Z4HD+oQRFu3zuktLeGfClb98KeuiHFa 7zpuknrgs5rCUg98qCEs16BJU/OebkfQnJeql4YkuiWjU4HhGdP2k8J5av6b8h7XG2BqSWd7Yjr fsjOItSiBCU0YSglZrBqeNZfE4zklZakSkUaFPByEZuVXYCA/izmqE9lJW7Hk4JNrGcMp1NGNnD NhnpZaRuFa6ls5ddSykE1ZrgCp4OSNcURCPH+GRT/ZDi2TcV7DUcXXGR51puInj6x6n58moBlox 6WW4QXAdNSqG+yULa+94oOkmeTyjj8aN8dhfigXY7Jq5DIQZZptjqoCt4F6VKGXPEMHOzghHEAm puUc12N0oSVHjc+busktog0gWY/T8gkYllX/8tTZhIX3pOOYb0AGVhAdUtsg== X-Received: by 2002:a17:90b:3bc7:b0:37c:6505:e7c3 with SMTP id 98e67ed59e1d1-3805273970amr2295663a91.22.1782817705202; Tue, 30 Jun 2026 04:08:25 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-380532b020fsm1501738a91.1.2026.06.30.04.08.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 04:08:24 -0700 (PDT) From: phucduc.bui@gmail.com To: Stefan Roese , Andi Shyti , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bui duc phuc Subject: [PATCH] i2c: mt7621: Use dev_err_probe() for clock acquisition failures Date: Tue, 30 Jun 2026 18:08:09 +0700 Message-ID: <20260630110809.559134-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Use dev_err_probe() when devm_clk_get_enabled() fails. This correctly handles -EPROBE_DEFER while simplifying the error handling. No functional change intended. Signed-off-by: bui duc phuc --- drivers/i2c/busses/i2c-mt7621.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-mt7621.c b/drivers/i2c/busses/i2c-mt7621.c index 0a288c998419..8b0407d70c4c 100644 --- a/drivers/i2c/busses/i2c-mt7621.c +++ b/drivers/i2c/busses/i2c-mt7621.c @@ -280,10 +280,8 @@ static int mtk_i2c_probe(struct platform_device *pdev) return PTR_ERR(i2c->base); i2c->clk = devm_clk_get_enabled(&pdev->dev, NULL); - if (IS_ERR(i2c->clk)) { - dev_err(&pdev->dev, "Failed to enable clock\n"); - return PTR_ERR(i2c->clk); - } + if (IS_ERR(i2c->clk)) + dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk), "Failed to enable clock\n"); i2c->dev = &pdev->dev; -- 2.43.0