From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A0CF403B0E for ; Tue, 30 Jun 2026 11:20:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782818402; cv=none; b=GYJT2dhhXTcMGOj2UupCc0dwT+JA3GhRtALYjGKeaSdjk1NPKBG8Muo4YN40oaR94ozal1HYZIblzukXMBCc0n9w/2luLimXv5sl9Nq80dG08GbXlWlm5jQd7YlxscvOAh1pUcP2PRPGWWbZwoR/hmsGK+yAsyK0nN1uZaS2WY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782818402; c=relaxed/simple; bh=PMfj8vAoLuXz4nZpWkRMuQeAoDUed2eQZFMQO3i2tNc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FHcrGtBf65LbFsIhU0D1IaLm+YI+JLLrF/6VoKwNJxNxc1cO3BDLb910Hd808I6fCdDiypvAa66Kp59plBQe+vbR0DXvU+a569K/uO4k7fKp9r0npD4p8wf0wiat/C7dHy0YzLdYtW+fFxMlLYNUmJ7Pcixm01crXx1LPGq956Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aR3L4lB9; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aR3L4lB9" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c8894387780so1861860a12.2 for ; Tue, 30 Jun 2026 04:20:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782818401; x=1783423201; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EMc4l7y/58xan7GJe/6NBJgIUEQeEH6NdAFiW8A4ij0=; b=aR3L4lB9EzyFNJYtXbgB22ip3F3ArSEmm4kXkuVflmNVEzdVxxwpj+Aa9A6qs2gf7x lCDeZyCy3rqKPKBGD2plgHsarkxNLQ492cQ6P2Ua5EsSUCMFKZpK9/NN7k1/MuGF/BdN x0E5ZB/Xqckz/lUz1q3oVUqE5KVlZLpD1GGySnKBPs+SIZBvKmTWqDspBO3UT478mzDW oig32x41mHA3X7YInyAZyMkqF1w/RazFIN7AR9rsuiDc/hM6rIBJ6hgf9rjNR+cSsibL 799tXSXe1W/sm7eMg+AcWIhEgO3agXNzZJ5XNvgaDgPJZbhrj7JO1yS6MJOILOq7YMoW Qzwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782818401; x=1783423201; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EMc4l7y/58xan7GJe/6NBJgIUEQeEH6NdAFiW8A4ij0=; b=ZK1iCVprvoUwK4l8ICmp9e0oECD0v/SnXNgfoM0KubHu3B9C0aXkwYcZuLAyoV6hwE Myaf10bSluR7updXgpvbwtf86qhranhPUaJ86dZMFZnI3cbkYERvdRcky0/wz+CIgdtL 4by/EIOIwnpeODK3p7L+pJosXZK+8aCcfsESYJCBLVHGO5PifvFPKBgLsl7DZfjwYpUU rSXgPQynaOwKxgU47mXGf+5fIHyEikdt9UQXpAJqISWnF6fpwo/E3uTx1kimyO9P/R2O QQ2f9VeAc3iPAaHt/+ajgUCo8ZLoSxwExWNsAEBnIMJ/qZ8Bzo/Phc7yDbROWZZpivQR juaQ== X-Forwarded-Encrypted: i=1; AFNElJ/kh4XGETgAjFVX0csvr60f5ORDgklXC2VTkQ6aOS0no3b/4no9/rVt5x4//8jYDRLIZ/M3Npqzo2K66rU=@vger.kernel.org X-Gm-Message-State: AOJu0YwSuMRH9qPl37KTeMKYjDJ2qH3mLlxBm2cEDKBI5JEd+8+rWmLQ xKFBD4M+zabWhn/cxii05gyAkn7jUywsy99dUE4BfipOd/pWLuhTkg0u X-Gm-Gg: AfdE7cl4KPc7BngaWV6Mbpuq2oBl53YdhAEDf3nPJVb3IWELzRtDs7byV7dWvTuGvto p+c7l/3UunvS0vIBpA8b/SdTYhbBHDAfzH7YGRVZnj8e4QIiuDprCKkS3aZxwKpnXru6kbohtzl Wchuzc8uSx9qiJwl8DkAXY3ItG8Mb+tl+1pGmR/j58CX+ruknH581ivnCcvA2bHnKSDWmBWZwQq pGUCE9tx/1VkQien9LrLEZaY/lvKI+yyVcGMAoFSC51KgM6Ke78vw0W5Y2zy5065FlFAOgafeKV tA7Iq3aSNbVULET7Qu7F7e6rQsigBl8Dw3rxz7f/EUha2WlNtDTBdo92VXrKKwNzUdT/SeVmJj2 KqaGSW0NQEWh+F55xTh4J6arpPpeQxzYddWGuIWQppbW7ltb5r0Ag7iFI5U8OAcIthQNB8gABu+ ywXS48y9nyte70LdNCwh2LD8Bbg4U/wtfKwPTCysmZBpLSXBk= X-Received: by 2002:a05:6a20:4304:b0:3bf:6d96:ac40 with SMTP id adf61e73a8af0-3bfc50563efmr2667483637.12.1782818400587; Tue, 30 Jun 2026 04:20:00 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c9bbf95a3e7sm1323781a12.19.2026.06.30.04.19.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 04:20:00 -0700 (PDT) From: phucduc.bui@gmail.com To: Stefan Roese , Andi Shyti , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bui duc phuc Subject: [PATCH v2] i2c: mt7621: Use dev_err_probe() for clock acquisition failures Date: Tue, 30 Jun 2026 18:19:42 +0700 Message-ID: <20260630111942.559932-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Use dev_err_probe() when devm_clk_get_enabled() fails. This correctly handles -EPROBE_DEFER while simplifying the error handling. No functional change intended. Signed-off-by: bui duc phuc --- update in v2 : Add the missing return after dev_err_probe(). drivers/i2c/busses/i2c-mt7621.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-mt7621.c b/drivers/i2c/busses/i2c-mt7621.c index 0a288c998419..8ab7a304a02c 100644 --- a/drivers/i2c/busses/i2c-mt7621.c +++ b/drivers/i2c/busses/i2c-mt7621.c @@ -280,10 +280,9 @@ static int mtk_i2c_probe(struct platform_device *pdev) return PTR_ERR(i2c->base); i2c->clk = devm_clk_get_enabled(&pdev->dev, NULL); - if (IS_ERR(i2c->clk)) { - dev_err(&pdev->dev, "Failed to enable clock\n"); - return PTR_ERR(i2c->clk); - } + if (IS_ERR(i2c->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk), + "Failed to enable clock\n"); i2c->dev = &pdev->dev; -- 2.43.0