From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
Avadhut Naik <avanaik92@gmail.com>
Subject: Re: [PATCH v6 2/3] RAS/AMD/ATL: Translate UMC normalized address to DRAM address using PRM
Date: Tue, 30 Jun 2026 10:48:29 -0400 [thread overview]
Message-ID: <20260630144829.GA4322@yaz-khff2.amd.com> (raw)
In-Reply-To: <20260630053339.GEakNVM7XFpJobZQQ-@fat_crate.local>
On Mon, Jun 29, 2026 at 10:33:39PM -0700, Borislav Petkov wrote:
> On Mon, Jun 29, 2026 at 11:07:30AM -0400, Yazen Ghannam wrote:
> > @@ -210,7 +210,8 @@ static int __init amd_atl_init(void)
> >
> > /* Increment this module's recount so that it can't be easily unloaded. */
> > __module_get(THIS_MODULE);
> > - amd_atl_register_decoder(convert_umc_mca_addr_to_sys_addr);
> > + amd_atl_register_decoder(convert_umc_mca_addr_to_sys_addr,
> > + convert_umc_mca_addr_to_dram_addr);
>
> This thing with passing in a function pointer from mce_amd was a hack back
> then. Now we're doing this here and we're passing in another pointer too.
> Yeah, let's rip it out and have users of the decoding library call the library
> directly.
>
> Oh, and let's shorten those function names somewhat:
> amd_convert_umc_mca_addr_to_dram_addr is an unreadable mouthful.
>
> Diff ontop:
Overall, looks good.
There are some minor formatting and build issues. I can send a v7 with
those fixed.
Thanks,
Yazen
next prev parent reply other threads:[~2026-06-30 14:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 15:07 [PATCH v6 0/3] Incorporate DRAM address in EDAC messages Yazen Ghannam
2026-06-29 15:07 ` [PATCH v6 1/3] EDAC: Remove fake_inject debugfs interface Yazen Ghannam
2026-06-30 5:30 ` Borislav Petkov
2026-06-29 15:07 ` [PATCH v6 2/3] RAS/AMD/ATL: Translate UMC normalized address to DRAM address using PRM Yazen Ghannam
2026-06-30 5:33 ` Borislav Petkov
2026-06-30 14:48 ` Yazen Ghannam [this message]
2026-06-30 18:55 ` Borislav Petkov
2026-06-29 15:07 ` [PATCH v6 3/3] EDAC/amd64: Include DRAM address in output Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630144829.GA4322@yaz-khff2.amd.com \
--to=yazen.ghannam@amd.com \
--cc=avanaik92@gmail.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox