From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3163B229B18 for ; Wed, 1 Jul 2026 01:22:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782868972; cv=none; b=XM6kf8orJRL25pFva3t/oiJhnaLPOgLhZH/pyG9/qwQVymCUMXZ7iEgFz7sPzEshLaKhL5RFV+pfMsEzjHLALvifCQFXWnXwbtqL25OTQK9eLUU2cjdmA5R7AIb1RgYCrWnPddO0Let/XKAq2e6nZxttVkkXLwugowgLELh8BTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782868972; c=relaxed/simple; bh=1KRrvHGEnUziX5xvzsbbNI/GGnMwnQzcmTlVHHBKDcA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Wu7TDKw0RZFzcHi8oO9XlxBhm01pazMr/74NesNRKCHZ9W8cw0Hl5VHH+6V5JYQg4rHbDOuWvZHOqop+2l46TrzCeTdee6Ssy5SRS2H/wSQbjkfhGUb1oWpvXGqzBUbR7LlldluF7sN535P9K2/GH36Turc86VUZVB5bbhbZlD8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=QirvxEdA; arc=none smtp.client-ip=91.218.175.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="QirvxEdA" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782868969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=nXEEcNJTN7FnoR0xBwUMHXMV9u8zlDjses4zEMqvZzg=; b=QirvxEdAvcKJ+K2HLjD+xxB78qJvjmSl+qobEbi4RTwHCHcsSmnHt7VhfeCsJa8C2KR7H8 j+nCBZY8AIl5xcdlQfxCMfSRxccbm7ksU07/NcFi/z79Q8qnSYVHDfYxw2bgyMzABpBg3z Lg767IDHQM2A+X4XrADU4VDxHyCPtyw= From: Ye Liu To: Andrew Morton , Zi Yan Cc: Ye Liu , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 0/7] mm/page_owner: misc cleanups Date: Wed, 1 Jul 2026 09:22:26 +0800 Message-ID: <20260701012239.315262-1-ye.liu@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT v4: - Patch 2: also update scripts/gdb/linux/page_owner.py to use MR_NEVER instead of the hardcoded -1. - https://lore.kernel.org/all/20260630015331.147174-1-ye.liu@linux.dev/ v3: - Patch 2: add MR_NEVER directly to enum migrate_reason instead of using a local MIGRATE_REASON_NONE define (Zi Yan and Vlastimil Babka). - Patch 3 (new): convert all 'int reason' parameters in the migration callchain to 'enum migrate_reason' so the type system reflects the actual semantics. - Patch 7: make threshold_fops a single line. - Link: https://lore.kernel.org/all/20260626020522.28619-1-ye.liu@linux.dev/ v2: - Add cover letter (no code changes). - Link: https://lore.kernel.org/all/20260623065234.31866-2-ye.liu@linux.dev/ This series collects a few cleanups for mm/page_owner.c that have been accumulated while reading through the file. There is no functional change -- the goal is to make the code easier to read and maintain. Patch 1 consolidates three identical PageBuddy skip blocks into a single skip_buddy_pages() helper, eliminating the duplication and keeping the lockless-read comment in one place. Patch 2 replaces the -1 magic number used for "never migrated" with a proper MR_NEVER member in enum migrate_reason, adds the corresponding "never_migrated" string in the MIGRATE_REASON trace macro, and updates the GDB page_owner script to use MR_NEVER so that lx-dump-page-owner correctly detects unmigrated pages. Patch 3 follows up by converting the remaining 'int reason' parameters throughout the migration and hugetlb callchains to 'enum migrate_reason', making the type explicit and gaining compiler checking. The 'short last_migrate_reason' struct field in page_owner is intentionally left as 'short' since it is per-page metadata where size matters. Patch 4 hoists the CONFIG_MEMCG guard out of print_page_owner_memcg()'s body so that the real implementation and the empty stub are two clearly separate definitions, the common kernel idiom. Patch 5 adds a missing \n to the count_threshold debugfs attribute format string so that cat(1) output is properly terminated. Patch 6 moves free_ts_nsec from the allocation summary line to the free section in __dump_page_owner(), grouping it with free_pid and free_tgid where it logically belongs. This also makes the dump output consistent with print_page_owner(). Patch 7 drops the redundant page_owner_ prefix from file-scoped static symbols (stack_fops, threshold_fops, etc.). Since they cannot collide across translation units, the prefix carries no information. The series is based on v6.17-rc1 and has been compile-tested with and without CONFIG_MEMCG. Ye Liu (7): mm/page_owner: extract skip_buddy_pages() helper to unify buddy page skipping mm/page_owner: add MR_NEVER to enum migrate_reason and use it for last_migrate_reason mm: use enum migrate_reason instead of int for migration reason parameters mm/page_owner: hoist CONFIG_MEMCG to function level for print_page_owner_memcg() mm/page_owner: add missing newline to count_threshold format string mm/page_owner: move free_ts_nsec output to free section in __dump_page_owner() mm/page_owner: drop redundant page_owner prefix from static symbols include/linux/hugetlb.h | 9 +-- include/linux/migrate.h | 6 +- include/linux/migrate_mode.h | 1 + include/linux/page_owner.h | 7 +- include/trace/events/migrate.h | 11 +-- mm/hugetlb.c | 3 +- mm/migrate.c | 12 ++-- mm/page_owner.c | 115 +++++++++++++++++--------------- scripts/gdb/linux/page_owner.py | 4 +- 9 files changed, 91 insertions(+), 77 deletions(-) -- 2.43.0