From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4207233956 for ; Wed, 1 Jul 2026 01:23:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782869009; cv=none; b=Ia8bgqcfXW0zuicltdLPZ65HLB4jekGv6haWJxjQVLEhLJRq7g1B27DrBw1MIw2mMyzHUjKTYHFhakF3DtKhF7VYSyqlZv3xFUiH7yd1ov6YuDXoZ45okKSfnkVTEgLHnuPCdhE8R3QluJRwbwTV7NmeI6dD91g41Nk95B7vEec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782869009; c=relaxed/simple; bh=7FBU8wLQenp8S4RfUBTR/9Bb7RAV7+7hhhc02OaqVjo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AvTK+yaC4RoUVBBUzVV5071BYG0UwhEpeQLLUCowRfzcILg0lfFGglXOZBz4EHj3huNER30mrZXcBbaQUxmiDczaeIovOU4oCEgej6YBoVpc/ee7t4CFyMJ59nVPi9V21FFTy6CqdgMSfHNuKCHen8PbvCyZs6nfxcuL2yAn4to= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Om7cdqVR; arc=none smtp.client-ip=91.218.175.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Om7cdqVR" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782869005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hMPk4xo0goYwl32b+O7Fi24CGRO5SYSFgHPQLi10p/I=; b=Om7cdqVR2SQfzLtC/CUOMJu+oOYjf4Nyu27g3QsInJgvk7g2PvJA6l1ACJLmEtRw6F9wO3 33K8l0IQAXfbzRsVjizow4th4jumCuDkN6jBb/fKK8cjObrukLPcQpcGq4ng4TaVI4G8EO SlYAhsWLv5RFgwm5a86p7Uxg0rf1rj0= From: Ye Liu To: Andrew Morton , Vlastimil Babka Cc: Ye Liu , Zi Yan , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 5/7] mm/page_owner: add missing newline to count_threshold format string Date: Wed, 1 Jul 2026 09:22:31 +0800 Message-ID: <20260701012239.315262-6-ye.liu@linux.dev> In-Reply-To: <20260701012239.315262-1-ye.liu@linux.dev> References: <20260701012239.315262-1-ye.liu@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT The DEFINE_SIMPLE_ATTRIBUTE format string for page_owner_threshold_fops is missing a trailing \n. simple_attr_read() uses scnprintf() with the format string, which does not append a newline, so reading /sys/kernel/debug/page_owner_stacks/count_threshold produces output without a terminating newline. Add the missing \n to match the standard debugfs attribute convention. Signed-off-by: Ye Liu Reviewed-by: Zi Yan Reviewed-by: Vlastimil Babka (SUSE) --- mm/page_owner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_owner.c b/mm/page_owner.c index fe2bf2274d8a..7520718f63f1 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -974,7 +974,7 @@ static int page_owner_threshold_set(void *data, u64 val) } DEFINE_SIMPLE_ATTRIBUTE(page_owner_threshold_fops, &page_owner_threshold_get, - &page_owner_threshold_set, "%llu"); + &page_owner_threshold_set, "%llu\n"); static int __init pageowner_init(void) -- 2.43.0