From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C30BE376BF4 for ; Wed, 1 Jul 2026 04:13:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782879220; cv=none; b=odYPrzcefNfjHXDaaS+eXk8+018ZP37ZSZbpjCPBEJfH6jAVsKkaL/IyxsrpEkPRXt/URxgjPMn4iqaDlv4aXQ7DrlLaTy7yA9sJ0dkARMZ3vRhwDZ5sB5wINpBDFhBRoo37rAbmCn3YQXLjDdrWQVr7vz9NKGsg9tVLML9OYjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782879220; c=relaxed/simple; bh=mIP+Yyb2QKE/vHSXauQQFSjnoDFdsnSWaqX8ZrlK7iM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SVjO5Ka1xpYOjw0lKT6DBU/l5HZeu/7Q+sDVKHdamiP5kPR8qVUCdlLUbczgVmZbiDuuEExjeOqcrkW5Yu2mDvRj4tIwvVvyjlnFoPndILJWELmwI3nqNEI9tKqhHgzR2dELUEWizSEpvzLHrefll8FolrMjl4fJtMkGs7CwyNI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lLtbvoTa; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lLtbvoTa" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-3804e42ad5fso218267a91.2 for ; Tue, 30 Jun 2026 21:13:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782879213; x=1783484013; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YhiglAKWEMHFc7lKOMiqzyD+MOB/Txierg5D8N9tqgg=; b=lLtbvoTaKiELhbWnTGL2kbV6iRnLQVAC/DPAQ+mHoTamzdRIZ/c8WD5ASMH6vG1upp EEwxsM+9HoDpkoCNOMhCXZLBmqIbnG3xLrhA/YCLgeJAFiujnyaZjKBZx3EC4tTywM4P fsdqXUZb8nQLyZfUQjCBTRv6+OY6Za/uJLXHKhFyc0634GWIZwWXIoNnPueJtjeo50zF ukb7DUeuI1EvsWBI0MXNwSjYQhst2PyuqC6vwhz7Ll3g1AhyPEnpMebdnBMqixUN/GBq QK6s+PD8Pl2hxl79e0hHkCqcKT+NpThandel9UCgNf3Go5RKXgR+aBnVtwpNg6T5pBhe XxiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782879213; x=1783484013; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YhiglAKWEMHFc7lKOMiqzyD+MOB/Txierg5D8N9tqgg=; b=Myt1S2QEwt4TRXf0Dbx3numYWblFqqElsFvRH+Q3IzbNLAuFsI7HBLChAIs9YBPxeo RE3dapOggiuDG0aEIW3eu3lXAR4B3Bsu1Ca7sgB5RhzDZFtOk/E8SYHZQRydiJBRkWlQ lXJapNVfWsW+MBj2NI1BCiT4HL+pkVOL6KqqH7dwdhNSoWUXNTCvZXXgzqQ0OkIGksRf 9nXRIRmxDM+nnEXcXUc0ppoXcKFLFjMf4kL4mBzCTATF4UPPJBytOvjEifdTN4zf6G5q MB61vewF2V5KrCi3NVwUU3D14X/ABOFhjA6nPshmgwBZjLqdq7Ki4X2f+KgpB7nDneDc jlZw== X-Forwarded-Encrypted: i=1; AHgh+Rpp2DnrHH11nRkmDsPjTeA4jnW1zSwNGOV+IRvuyqnTQAZscVRLrSbpNZHiCWfoRXF8N0+QnWumo96i65I=@vger.kernel.org X-Gm-Message-State: AOJu0YzrYdFTVV+RqsgMUJGkEtr0RCHQm6MiLztQbg07vRKpnlBy26r7 04JoLsXT/ELgae3mE5us4Waexbt4BPLY0nqnfsehCaAPKOzp1s4N/C6InmaLDg== X-Gm-Gg: AfdE7ckFnmiaHZt+WYoix3NFavBcwchNDMGIoTR/Qt/MOA0Dla5irpBdIJc2fdnJd+6 WTmN8dK64DSPcLt798vC4ffZOzJgyXADfMSIhGy5dfQjVbNfj3X1IGeV8XUVHjUi+VI5j+EgWf6 TRWpZ88QqlNm6QrzQOLgoCvkC9l0cLBxkUVsyE6pfvS11MT9TkxHrIbVFWkz1FmMt+HymqJAJSQ CCp8RJOhTH5OPZAFIcz0atPZIKf+idDpL/aBGy9tCGAZlyKf03YrhgdEwoH18vL14PQwe+M9pDo KI7HGy/w162IwQqdH6fR2N18UTMxfGSqdfseLByWsihrdtFj16yjUxiuHz1ulGKgj9iTQt+N7Fo XHV6et3eS515KbX74tSgaL7jWflZW1bxOvNYM9QFQQuX7yuClLZfau/69G8Dg1Y57ETuLn2K5dS ETPwPc+MRkKUiLc1WVN61XULFxpM6StslLx6NEoOizzs/suKU= X-Received: by 2002:a17:90b:35cc:b0:380:7763:3b26 with SMTP id 98e67ed59e1d1-380aa15b525mr99144a91.18.1782879213357; Tue, 30 Jun 2026 21:13:33 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38095e830ddsm963128a91.13.2026.06.30.21.13.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2026 21:13:33 -0700 (PDT) From: phucduc.bui@gmail.com To: Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela Cc: Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Sen Wang , Jarkko Nikula , bui duc phuc Subject: [PATCH 0/2] ASoC: Fix mixed goto and guard() usage Date: Wed, 1 Jul 2026 11:13:08 +0700 Message-ID: <20260701041310.230725-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Hi all, These two patches fix the remaining cases of mixed goto-based error handling and cleanup helpers introduced by the recent guard() conversion patches that have already been merged for the 7.2 development cycle. The cleanup.h guidelines explicitly recommend not mixing goto with cleanup helpers in the same function. Only two functions were left in this state: - sound/soc/samsung/i2s.c: remove the goto-based error path and rely on guard(pm_runtime) for automatic cleanup. - sound/soc/ti/j721e-evm.c: restore mutex_lock()/mutex_unlock() to preserve the existing goto-based error handling. Although these cases do not trigger any build warnings or errors with Clang (W=1), they still violate the cleanup.h guidelines. These patches address those remaining cases and add the appropriate Fixes: tags for the commits that introduced them. Best regards, Phuc bui duc phuc (2): ASoC: samsung: i2s: Avoid mixing goto with guard() ASoC: ti: j721e-evm: Avoid mixing goto with guard() sound/soc/samsung/i2s.c | 25 +++++++++---------------- sound/soc/ti/j721e-evm.c | 4 +++- 2 files changed, 12 insertions(+), 17 deletions(-) -- 2.43.0