From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F95C3A3E87 for ; Wed, 1 Jul 2026 08:43:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782895434; cv=none; b=lAXk0t00gPXuFigYrBdu6R6aZ6CRLIACUrkxYr2ET+wXKrUxTTnh+jqM1JF+jULB3A63DK3Lai2PktW2kmODveUVxUB2LfRAUDmRg7oIDsc+bKJFSoGn0A8RyLhT9A9AcJ5ZSmfsf+umP29LBWgOWrwAHA17Eohhii1WzHYEg8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782895434; c=relaxed/simple; bh=w0te3hTfrZVIIhV7OwHpsQXbSc0kSRbo09l3Nd3rK8g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HiJPx+jGl+B43xrzYBvF1yh9W451xWZCGIyAXtheIdV+uAEH01c7Rh8O4CHTV0aUgTVdUJhiJklseev+EHwkbrKtn3sYj0gnvXHfLkCTdyO1VmoI8cwS5STh9kPE8YyO1hFxp3aexyICRLAygxdU2ckVNsa5edxvGbZnMuz/ldg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pQ1P1ega; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pQ1P1ega" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-38060005f1cso807389a91.0 for ; Wed, 01 Jul 2026 01:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782895432; x=1783500232; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8vY9CqWVGTyfDpNaPewk3sawwCCcX6z0ljhxWV3QdQI=; b=pQ1P1egaJ6MUoVn0OlyEXLhAHrg812awdLWJUewzqEFe8UQRgkbJcw8YPN2WEXSO2J dLOWxaZoSbMD/cokgtTdXvnXwK4CV8OGwJ7HcAdanMD8LhFqSIJs+zO3FC7liIr6xfeq B2GaxZtl/7L6Gbf1qfd0ng6MJW7rboSyXvq98OmR7nPka+6lg0N4uMen7W9TGBIYkWxi +btvrnjMV/CoiHE59Z4VdCeUsnMUJJXF4GcJWImuVaDmfkqjYgEpDBL0aWFm/VKDRgC0 iVSL6+Zb1dMrVZEAw31foH/rl8eSX25Eu6yYZi7NupaBfPuwm5eQY6Df8FMT8zXBz13B CxhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782895432; x=1783500232; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8vY9CqWVGTyfDpNaPewk3sawwCCcX6z0ljhxWV3QdQI=; b=tEV1tbOCntgoUvm/hvTG3VPla4VVTT1MaI/oTVN6X5Y7+O4m7HD0QjAJpe0vGZco6z thB+ovh0vwGUBhfefxbKhgcAWRjSTBVhMrWDnuPnJsae0diiEGbtmv7I6Pui8ZzM5ADd jTYsBmX/l/L/GvGBK0sao+w7vgDKSrgWqmGbjwUrob/GjaIUMOcM0xcWF6+Pb4pB7HW3 cHfp5k3Ps15Jo0jBpRFhLXL8Uqw07opFVx5lwfrESvAc0Idlf+34nOqmJn3uKKfwCJtn DU7HkvTgP+pt4gkPxhZWWD322ubgKe86/HNH17TLQTeTCDMqx59iLwRxw/Tjnc46tB+4 aIjw== X-Forwarded-Encrypted: i=1; AHgh+RoV3AEmZWfzQ0xUbxpTUu3yuVz9eBGCW82YFE5AhX8ymRVdHkvvBHC1wznMM80jIvBeVeXYlRCtl2rfgRI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx36nLQFOZHsA/xCzAcNAEuqi/43ot4jcis5jJ54c+RQWcWaZPT b57ogMkQY2hKCnnGhUmPSf/WqucgqDWrT3wU5EyegQCN+gusZG6sOqtl X-Gm-Gg: AfdE7clhtqixXBCFLBSdmG+Q6mSm0AQ2DLd1mtc7TN10h3EEnwyj9cwWKsMNwG15081 /75kkLlwDUh0ISW6pHmfA5/jiLnOYVN1DoCKyNEgu2ttrGb/eCfHQ4FSThvvWPxFj2PBFMaQwN0 SyV4vmG2F0r3RfHcmLtZreNWHWoFyB4YjVqk6clDyH2F6ynvw2hQdNKl4QqbW+cHRlxux+z0J1Z bBNFfPxCfDtKE4FIiHpDuxta83vLATiATkC+qVLt+1xVxd9FlzXk/krUPYXcUqaRJ0yFcz44d4R GrWhvmwTf4XhyloI+ojz9Jbj8NhSWtMp6bYHlCD/0hacL4K476wS5pOhx+VSOkPbPnJtBHyordT pqsRiIEwbHOk84qfBsFUrHJKF7sXV2ke0r0BHMqgGhs7bXYAiuiu1DwKgF5Xzfgl2SaKwQ4u2bm M9R34wUbt0q9dBKeYiXudBip+fHEn61l7vNEmunwLPoRt8xBs= X-Received: by 2002:a17:90a:f943:b0:380:86d8:8162 with SMTP id 98e67ed59e1d1-38086d88420mr2107320a91.18.1782895432496; Wed, 01 Jul 2026 01:43:52 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ca382b5175sm27965505ad.63.2026.07.01.01.43.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 01:43:52 -0700 (PDT) From: phucduc.bui@gmail.com To: Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela Cc: Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH] ASoC: samsung: i2s: Use dev_err_probe() for iis clock error Date: Wed, 1 Jul 2026 15:43:36 +0700 Message-ID: <20260701084336.308886-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Switch the iis clock error path to dev_err_probe(). This folds the dev_err() and return into a single statement and, when devm_clk_get() returns -EPROBE_DEFER, avoids logging a spurious error on every probe retry while still recording the reason in the deferred-probe debugfs. No functional change other than the demoted log level on deferred probe; the returned error code is unchanged. Signed-off-by: bui duc phuc --- sound/soc/samsung/i2s.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c index f80f697a5d55..68fff67b9660 100644 --- a/sound/soc/samsung/i2s.c +++ b/sound/soc/samsung/i2s.c @@ -1448,10 +1448,10 @@ static int samsung_i2s_probe(struct platform_device *pdev) regs_base = res->start; priv->clk = devm_clk_get(&pdev->dev, "iis"); - if (IS_ERR(priv->clk)) { - dev_err(&pdev->dev, "Failed to get iis clock\n"); - return PTR_ERR(priv->clk); - } + if (IS_ERR(priv->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(priv->clk), + "Failed to get iis clock\n"); + ret = clk_prepare_enable(priv->clk); if (ret != 0) { -- 2.43.0