The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Luis Henriques <luis@igalia.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: fuse-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
	Matt Harvey <mharvey@jumptrading.com>,
	kernel-dev@igalia.com, Luis Henriques <luis@igalia.com>
Subject: [PATCH] fuse: cache POSIX ACLs when setting them
Date: Wed,  1 Jul 2026 12:00:52 +0100	[thread overview]
Message-ID: <20260701110052.5309-1-luis@igalia.com> (raw)

When setting an ACL in an inode we can immediately add it to the cache.
This is a small optimisation, as currently an ACL is only added to the
cache when reading it again, which involves an extra GETXATTR hop into
user-space.

Signed-off-by: Luis Henriques <luis@igalia.com>
---
 fs/fuse/acl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/fuse/acl.c b/fs/fuse/acl.c
index 31fb50e16aed..c2584bb75ec7 100644
--- a/fs/fuse/acl.c
+++ b/fs/fuse/acl.c
@@ -155,6 +155,8 @@ int fuse_set_acl(struct mnt_idmap *idmap, struct dentry *dentry,
 		 */
 		forget_all_cached_acls(inode);
 		fuse_invalidate_attr(inode);
+		if (!ret)
+			set_cached_acl(inode, type, acl);
 	}
 
 	return ret;

             reply	other threads:[~2026-07-01 11:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01 11:00 Luis Henriques [this message]
2026-07-01 11:39 ` [PATCH] fuse: cache POSIX ACLs when setting them Horst Birthelmer
2026-07-01 11:41 ` Amir Goldstein
2026-07-01 11:47   ` Horst Birthelmer
2026-07-01 12:24   ` Luis Henriques
2026-07-01 22:58     ` Amir Goldstein
2026-07-02  8:56       ` Luis Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260701110052.5309-1-luis@igalia.com \
    --to=luis@igalia.com \
    --cc=fuse-devel@lists.linux.dev \
    --cc=kernel-dev@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mharvey@jumptrading.com \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox