From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52A193C09F5 for ; Wed, 1 Jul 2026 15:11:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782918680; cv=none; b=g1Hy8aEXsRknd5pXb9b3sCPd1H1R0tyRhO+hpFWYS2z7+xfcU8l6V0N55BPwTTaQj8tmVg9HdBuaJ0Q6w8a39WlP1FFt2TkdZcaDgpCMDfIn0+xZD4DcQ8f6KbW6OB3/wlDbGm3MlKqG3Fac4s1eD81XX6hjkue0D1FLmKdnBok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782918680; c=relaxed/simple; bh=ezei1IRHtvZjlBNnHExRqtdzBYaUMDA/AQ+kgrCd2rI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fhQM3Lq+jxc7Zmk/rme0TbTWNikQL7rKIf3ue7cidq15kUzELbFiU/85QTYEU4uYx2fmqR21VCvcSKeaV3B7X7HYRRAjQRSORaZu2MRpqJlpa6mi5iDR3pzcxLcFs2axj0hqQzT9Vo0QmqhEb6q7c/kp4zmTF8FrY8jzwVAmklA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=bmYSG8aP; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="bmYSG8aP" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 6BDAFC504E2; Wed, 1 Jul 2026 15:11:26 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 6225360288; Wed, 1 Jul 2026 15:11:15 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 83A59104C9645; Wed, 1 Jul 2026 17:11:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1782918674; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=lTbkb9PNizd9LGcvfest9O/hgUQd1NGIQ+sGEr29HOQ=; b=bmYSG8aPQ1KMoP6ZmgZ1bSZof92ublO7R9gPm+t76+Y5Njw35/HF8NL9fWBX4LUVcZ/ryT 6Caxt2QsZnoYLoV7Gdz4LvdciZdayzpRxMD4jGAsmKQgBVED5om661WmI1a8sfjsu+ZxWD Aq7qAb9DOK4EKmMlMslyYVpfpHHdpqkFeXn8qHvARnsO3uw9HdZRRQunf9/wIc5sp1dbsr sc/5tppUdga8i6Xq4nJuoVTFDkSUmFWddsATN1vCT9f3K/JSOn8oUC7slzxuyp4Gynt1rI ZxgKQIvWjNbeUc29j2jG6VmcsKXa8x3S4dX4qmIclyjvC9pSDspGw0zlBpzX4A== Date: Wed, 1 Jul 2026 17:11:11 +0200 From: Alexandre Belloni To: Markus Probst Cc: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: rtc: Add sii,wakealarm-output-pin property for S35390A Message-ID: <2026070115111192951db5@mail.local> References: <20260630-rtc_s35390a_int1-v1-0-1b2239e16be2@posteo.de> <20260630-rtc_s35390a_int1-v1-1-1b2239e16be2@posteo.de> <20260701-bronze-jaguar-of-perfection-028bac@quoll> <45e8157be53c3d8827fcccece7f706968bc056d3.camel@posteo.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45e8157be53c3d8827fcccece7f706968bc056d3.camel@posteo.de> X-Last-TLS-Session-Version: TLSv1.3 On 01/07/2026 13:25:41+0000, Markus Probst wrote: > On Wed, 2026-07-01 at 09:35 +0200, Krzysztof Kozlowski wrote: > > On Tue, Jun 30, 2026 at 07:22:21PM +0000, Markus Probst wrote: > > > Synology NAS devices use the output pin for interrupt signal 1 to wake up > > > the system. > > > > > > Move devicetree bindings for sii,s35390a into its own file. > > > Add sii,wakealarm-output-pin property to enable the use of the output > > > pin for interrupt signal 1 for the wake alarm, which makes it possible to > > > set an wake alarm on Synology NAS devices. > > > > > > Signed-off-by: Markus Probst > > > --- > > > .../devicetree/bindings/rtc/sii,s35390a.yaml | 54 ++++++++++++++++++++++ > > > .../devicetree/bindings/rtc/trivial-rtc.yaml | 3 -- > > > MAINTAINERS | 1 + > > > include/dt-bindings/rtc/s35390a.h | 9 ++++ > > > 4 files changed, 64 insertions(+), 3 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml b/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml > > > new file mode 100644 > > > index 000000000000..31a578673870 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/rtc/sii,s35390a.yaml > > > @@ -0,0 +1,54 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/rtc/sii,s35390a.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: S-35390A 2-WIRE REAL-TIME CLOCK > > > + > > > +maintainers: > > > + - Alexandre Belloni > > > > This should be someone caring about this hardware. > He does have the majority of commits on this driver (excluding merge > commits and commits not exclusive to this driver), although most of > them are pretty tiny. > > Who would you suggest instead? I can take it but the point of Krzysztof is mainly that the ones working on the driver don't necessarily have to be the DT bindings maintainers as both are well separated. I mostly did clean ups in the driver, Lorenz Brun submitted something way more interesting. > > > > > + > > > +description: > > > + The S-35390A is a CMOS 2-wire real-time clock IC which operates with the > > > + very low current consumption in the wide range of operation voltage. > > > + > > > +allOf: > > > + - $ref: rtc.yaml# > > > + > > > +properties: > > > + compatible: > > > + const: sii,s35390a > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + sii,wakealarm-output-pin: > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + enum: [1, 2] > > > + description: | > > > + The output pin to wake up the system. > > > + Default will use the output pin for interrupt signal 2. > > > + : Output pin for interrupt signal 1 > > > + : Output pin for interrupt signal 2 > > > > Does that mean device generates the interrupts? > Yes. > > Thanks > - Markus Probst > > > > > Best regards, > > Krzysztof -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com