From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59E2F3624D3 for ; Wed, 1 Jul 2026 16:22:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782922935; cv=none; b=GxMPrMAKWkQth5xRAydzvV99xTxWusHij1ytucyvF2KhjJqsybfRb9r7BmBcJFvUW2KUE+QKjqcCOvVrxuNu0u43MaE1BaK+jjscG9ZuvZ6KKX76SAirfnab93GR5ys4PxLzCuqjnVbGVlgaUysdy/QpwLYQNQ5MJgX/6OU1Eis= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782922935; c=relaxed/simple; bh=ghnmSn32KA2pmz1YV1qVunziiD4cwnQVpbeGx0vFXfw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MZoCtsn9Xtc64JdvWmdphGVL9oJpZcKkIt/851dCJLw/wyTj8TvPKHzPJAV3Hhy8Vmv/wRCjKdFL9zMvIa77kAoSd4Li2o9eaMmqOt+SIxOJzcGUdcjijABAoQvvZps9ODNEf45/ik2KuowhelD7hbHNwyQBlXLueuHg5s1x7d4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V+KLNw1A; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V+KLNw1A" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-4703bc0a99aso482842f8f.3 for ; Wed, 01 Jul 2026 09:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782922933; x=1783527733; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zTl0Xrk2VL81HcsN53vqjMgr5tHj1yG6DZF1PEU0RJM=; b=V+KLNw1A4ew3X+5ItwPHGelFICgjCXwXs9ReIg5KTW/aVi2wkWETEI+tBWS2PUvWMK XP1TV7qGiHy0Cios6PezEgoCG7pGkYAUCWkMVxHplgKYsiyWBd180n+FhRkKOXhomA2d qxd4aQtKR6Tgw+bx+I51aPL35kaAJMYK5Qp8Jrz7O1DnXTUVS93zFirPsS+FaDlmEAK6 heaVpxgpOQ3bkN3v2bHbBP/cgDWuHaXbjBLvxz0Zitrkq80jjNHvVH/7mY9vrmB7OsMh 0Fj8BKE35gD5+bDTT9BRvHaFZ0/CJvaCiiodeld3BAaPihxCjUF2kIHZZgfvCi8TTC7r ZjiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782922933; x=1783527733; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zTl0Xrk2VL81HcsN53vqjMgr5tHj1yG6DZF1PEU0RJM=; b=cF0hmie0G2QWa7q4NHVu8BG1TtXdy/OP7uJRdXCtqtEGDj64jaDIxSlfV+1luaeZkp h5Em9lau6RzDynWtb0aUD6MzYsEdYPF7dj1LQ4+bD7SYYD/4I7uI7OIYSg/f4ck+4DMG qrlmpTRJo8Y2YXwKRKtcMi2cQvKJ37IbH/b4lmO9gCtHgfFVUooLu16O1swoxZkPJrm6 DFNgpPFZCjpmlhsq7NNFOUiK4tJHWpbW9rkNn0oJniPZsOzB+OzacILdwKVVKPdFSOrP AdcTggpfu4zX4xNItwWKmiuf6FfjD6UKpVkG4M/sNrkaNm4NxH/WbaVLj/uReaF5a3yO 8RcQ== X-Forwarded-Encrypted: i=1; AHgh+Rr7BZ3B3M9jm9DM/Lg9HzNcEaeVv9ApiT8puUAd1XHnmIlhP0TlizDwasc3UD3sjReFI6fk9wMGVA3bunA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzc8xcK7uPlf4AfIAlu1YFj4rHTJNZUzAbDClmjVLbS4dZ3DbQJ oKdVxP48JwwhYTlqJez6dRF3+tGGHqQIeDRPGAxNGNlcjtxVdSrG3229 X-Gm-Gg: AfdE7clhzTSTSt35eL8P3GAS8Ua5bGL5krykYJM3ehoRrMMdinKx8d+DhhCX2d1yjjx gwS4pNegJTSFekVzmTZzeCZ6AbAEEhcJ2QPJwrTxSr72lj2R+12t9eft2IKFLgcu77gJfADbqN0 jVxnwk9isQ2qM2ALiBTyPsUU8Mb8SyF5zv1iDFEjLiGb5CfRcHd/6+gd9RB3o1muvx0sNSdh58O 1BYfs7FNsbiRzWXZSgmDDBH6P8iMy9n1Wxih+jifKrRwFPU+jBS+wqVb/PEjMe294jSbzjXx715 Q6G/KiKddmzjVfE6YFo3PrO3k1lFb6vtaFW8aDL6BahLObkoe5/wLpEHDgCDvjsPQo3un2UYV68 qANws+1Pzqt9loRGLGKPTjTQIWbf8qEX35SVBArHDuuL2xNFg9KwXzgg+9F5lVfrV9wzuoM3Ody /srOKSchIPT2RSmQd5knGXlZ7XUBebnl3yJMp6XdHmfLyO74AtAOF22v1V2lXhy5hZemtA1pwV3 8FVimrQEB5G4IeOUKLVPHMbwNCaj3+jVkT2b5+GFiqm/a/Ax3UG6sxQ5eNAbNDP5g5t/6folaxT m6NDDCEjgcCiRDBv X-Received: by 2002:a05:6000:4203:b0:46f:9c9d:d7c4 with SMTP id ffacd0b85a97d-47759098536mr3837213f8f.39.1782922932621; Wed, 01 Jul 2026 09:22:12 -0700 (PDT) Received: from systembl0wer ([2a02:8308:4092:11f0::f9f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-477ddf0f27bsm840420f8f.30.2026.07.01.09.22.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 09:22:12 -0700 (PDT) Date: Wed, 1 Jul 2026 18:22:10 +0200 From: Joshua Crofts To: Kittisak Boonmapa Cc: jic23@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, srinivas.pandruvada@linux.intel.com, sakari.ailus@linux.intel.com Subject: Re: [PATCH] iio: hid-sensors: Fix poll_value sign check before msleep_interruptible Message-ID: <20260701182210.4739035b@systembl0wer> In-Reply-To: <20260701154319.23497-1-goorock.goopop@gmail.com> References: <20260701154319.23497-1-goorock.goopop@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 1 Jul 2026 22:43:19 +0700 Kittisak Boonmapa wrote: > hid_sensor_read_poll_value() returns -EINVAL when the HID descriptor > does not contain a Report Interval feature field. > > _hid_sensor_power_state() currently treats any non-zero value as a > valid delay and passes it to msleep_interruptible(). Since > msleep_interruptible() takes an unsigned int, negative values are > converted into very large delays. > > Only sleep when poll_value is positive. > > Fixes: 5d9854eaea77 ("iio: hid-sensor: Store restore poll and hysteresis on S3") > Closes: https://lore.kernel.org/linux-iio/CAPr6G1qLDrgHvCNsVxj7xHxYUKkAkyo87Hq3Lfyoj3RaZ2v4dg@mail.gmail.com/ > Reported-by: Kittisak Boonmapa > Assisted-by: Anthropic:Claude Sonnet 4.6 > Signed-off-by: Kittisak Boonmapa > > --- This bug was introduced 9 years ago! Reviewed-by: Joshua Crofts -- Kind regards CJD