From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C44B3ACA40 for ; Wed, 1 Jul 2026 21:46:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782942392; cv=none; b=i9zjMivkTv+xIMZmqbhocoog/PrFNnD0e6UpNV1s117BulSLnJgH3Ip5/wc5vrdCyQJLIexgiXW0A72KVESr694jeTDPyUYYx+FrfLRUE3TcXYNZdvALEFayPf0jBxxb7eLgSbUhxbNTIcFt9KbQ3uJ5lstsMtAJUJsoRg0vM3w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782942392; c=relaxed/simple; bh=MvVp5+wVwgh9DEeQZht414Ur64kkFwEGf7j6i+EOFIc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=s5HIQBL+wX8R8V/3uzrds1EkrL4C5lJ85yAV078JLJemxz9MXrZ6zx0Gwa0SekFDw10xJ6cMI606Cq48ZbdK5vOnhZ/P8uo+n7srLjWqsbAHpZKYXNb4eQLReF7ICPxuwl1DIIYWn84tyDayLy8tGeibL8Q4002kN1mY+GiEboE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jstultz.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=cboz6+ut; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jstultz.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cboz6+ut" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-84777e9b51bso1931149b3a.2 for ; Wed, 01 Jul 2026 14:46:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782942382; x=1783547182; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=cW7OgloRGw0AyL1Ca51Q65z/SjLImngE1k04cChGqzs=; b=cboz6+utU1gCWDhiIbrJkrpJUKcJFhMHDoFszhXQlF2DMhXqyjKzfoetyNxPV/s/vD O2lKIDkaUAbbJJVqmknblI3WTx/6pXMQYFgWxONWl0aNOr1pSLvW2Qdv9MUeSM1hKBXO EhUAWAmEmvFwZcLXIgjIzolikduvuEfXgQN3A7Ujykgsdq9LUS39P01SHKg/krsXrQEE dqlzhYhU8Gnl8DDh7Q24IYHnOJeJvtWZtGmDWDudRtsBlZiaeIp3T31aGnq/m/9yukVC b7h59y14dZG5mBsGsaGemCBs1G+lI+v+If2HFMrQXSKq6yfp0ErQKtKu4MPm1HTMuxvL QIJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782942382; x=1783547182; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cW7OgloRGw0AyL1Ca51Q65z/SjLImngE1k04cChGqzs=; b=fRDe594CNu614sQXU/cZTbLXdVsh9AY8kbss4Qa8SMSdufOokUmLlW9v9Mg+KuH3q8 4vwFCVBzC5YvzCoMEcIjsAzfLTBxyIdtS8l5AiEQK/2FHTFha0fBbFepAFwaIk5Ep2dG DH3uMXIknmcn69+P+mCIk2EA6bIOUXtuBLNge8GNP5svGHr13DBJhfWKd9jr7Z4Mi4P1 sLF/HMtk80D4usF2DHY8glZZf8b2f69A1vtU1Yj+3IxNaFWFLe4EDOIHEC6ew15nIlpU r4wo2uDEf9o2dM4xXtz15aodHGvLFw6wFf7WOyXUfmdIRK4aXh5dDx6lM3u8nbRmbanV kBeA== X-Gm-Message-State: AOJu0YztMG01JNkfLxSseWpMuO7mK9aKCtA05ubiTP4Fu6aGEQIjylI4 35jKCHw5JXjEkpAkAlqEi8Gy1gunLszqj0S6akMklrMclWB7J1Yq33TPfdTdiUdK1ABNMx7pUfY ec+cO3ejtXSe3SDULByXjhDwY5oCgdOckYJeU+ok+p1bzZMHnsDjXyuXFvNdy2Y9K2p0a1w4vA+ J6+P+NSi9gtVVYvblym6w0zyOscsRteirTPdV7nPU4wvIRhLpx X-Received: from pfbde13.prod.google.com ([2002:a05:6a00:468d:b0:847:9af3:417e]) (user=jstultz job=prod-delivery.src-stubby-dispatcher) by 2002:aa7:8889:0:b0:847:8f0d:cc09 with SMTP id d2e1a72fcca58-847c516695amr2359863b3a.44.1782942382171; Wed, 01 Jul 2026 14:46:22 -0700 (PDT) Date: Wed, 1 Jul 2026 21:46:00 +0000 In-Reply-To: <20260701214615.3773339-1-jstultz@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260701214615.3773339-1-jstultz@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260701214615.3773339-6-jstultz@google.com> Subject: [PATCH v30 5/7] sched: Break out core of attach_tasks() helper into sched.h From: John Stultz To: LKML Cc: John Stultz , K Prateek Nayak , Joel Fernandes , Qais Yousef , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Valentin Schneider , Steven Rostedt , Ben Segall , Zimuzo Ezeozue , Will Deacon , Waiman Long , Boqun Feng , "Paul E. McKenney" , Metin Kaya , Xuewen Yan , Thomas Gleixner , Daniel Lezcano , Suleiman Souhlal , kuyo chang , hupu , Vasily Gorbik , kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Pull the core of attach_tasks() out into sched.h so it can be used more generically. Suggested-by: K Prateek Nayak Signed-off-by: John Stultz --- Cc: Joel Fernandes Cc: Qais Yousef Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Juri Lelli Cc: Vincent Guittot Cc: Dietmar Eggemann Cc: Valentin Schneider Cc: Steven Rostedt Cc: Ben Segall Cc: Zimuzo Ezeozue Cc: Will Deacon Cc: Waiman Long Cc: Boqun Feng Cc: "Paul E. McKenney" Cc: Metin Kaya Cc: Xuewen Yan Cc: K Prateek Nayak Cc: Thomas Gleixner Cc: Daniel Lezcano Cc: Suleiman Souhlal Cc: kuyo chang Cc: hupu Cc: Vasily Gorbik Cc: kernel-team@android.com --- kernel/sched/fair.c | 16 +--------------- kernel/sched/sched.h | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 15 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index d78467ec6ee13..6d2fa0cd77779 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -11035,21 +11035,7 @@ static int detach_tasks(struct lb_env *env) */ static void attach_tasks(struct lb_env *env) { - struct list_head *tasks = &env->tasks; - struct task_struct *p; - struct rq_flags rf; - - rq_lock(env->dst_rq, &rf); - update_rq_clock(env->dst_rq); - - while (!list_empty(tasks)) { - p = list_first_entry(tasks, struct task_struct, se.group_node); - list_del_init(&p->se.group_node); - - attach_task(env->dst_rq, p); - } - - rq_unlock(env->dst_rq, &rf); + __attach_tasks(env->dst_rq, &env->tasks); } #ifdef CONFIG_NO_HZ_COMMON diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 56acf502ba260..56d9c09c485e6 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -3100,6 +3100,25 @@ static inline void attach_one_task(struct rq *rq, struct task_struct *p) attach_task(rq, p); } +/* + * __attach_tasks() - attaches a list of tasks (using se.group_node) to + * the new rq + */ +static inline void __attach_tasks(struct rq *rq, struct list_head *tasks) +{ + guard(rq_lock)(rq); + update_rq_clock(rq); + + while (!list_empty(tasks)) { + struct task_struct *p; + + p = list_first_entry(tasks, struct task_struct, se.group_node); + list_del_init(&p->se.group_node); + + attach_task(rq, p); + } +} + #ifdef CONFIG_PREEMPT_RT # define SCHED_NR_MIGRATE_BREAK 8 #else -- 2.55.0.rc0.799.gd6f94ed593-goog