From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1A973770B for ; Thu, 2 Jul 2026 00:03:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782950638; cv=none; b=sVlMUEp0GUb9t/AA5gqRAIt0TnfDh0IjxvJJj0CJEsee352B6MvOEgNM52/XDWoUZVL+3EdEODf2bMBMaevHbJ8hzML4xR6gRKBz6WVZHwWktebJN+BUJPQUoV5slg7cw7W/Nopxhpb6ViegVUwLIdgZX9qY3jrW6ChTrxsV+oU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782950638; c=relaxed/simple; bh=WuC6Ya8GmTTZtaLRIoU1ca2LMUwDmLF2AKQENiJ3WlA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UWSNO3YH8moY7SO7gaSwZZpsAjvxc9eMAOgVZU5jcLK81DaEkV1bsV96p+aY1tL0a2VLDBALpu3eQ9JWdzFk2uiCKIbgzXhjy4xj+vxcCQu+KUk/c80o5NlxeHu46V0iKfrRwb0uF3tdtW8t5l+zuxef/C40g0eG3ct7nK9J0VI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ftZjOKeI; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ftZjOKeI" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2c9b1edf2bdso9902295ad.1 for ; Wed, 01 Jul 2026 17:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782950636; x=1783555436; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eGvcZa6THMRepYDa0BghV2VvpfyJT/Md5Oe7Joec0Cw=; b=ftZjOKeIQW7y2F1LvjkCNPqd9W+/svhhI2pwKdQHEEKk9SRowVmsb0P/g5WfoyOXtk D9u6iT3k1iSPwv0suu4GlneSzITPLR/6B3ejhLOZWEaAdSyJlbUHAMScBUKiQ7+/F8ZX DbZ0HbV/YQompT6e6JPfIWXohBBIcr7oAiBkR4BACoZu0RqL39cOimfAGZKNnpj1WO4m iH3PFKCPrcscjVrynFndFKNi1xPVaRVdfUizdWD93+RHpSMPs/1kYfTK/lM/aOkIX+sy 10KSZzg4RwwG558IPBU/7/yHrRsOeoEa8G5enWtCHm2Xc6rgj+vd48s0yt7GSUy+mU/8 jyZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782950636; x=1783555436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eGvcZa6THMRepYDa0BghV2VvpfyJT/Md5Oe7Joec0Cw=; b=HWAEU3AwM776Hxrvklms5iCHmGgT86EUtt6U6V2cfPjYe91T9Adj8n4VamiKcOC7Tn O44VzsaO6KgyStyE9X4nnLPIbCl+k+QZy6jRjQGEJP3oLgFG6VaB50DtPPG1GKNbMOKj 9gEyl4n88WLHiZiouUGQXULdf2CXPoIlVGypU2elE8ivQtX4fYjEpfw6Y3gkVYcrJ6pZ L70Xosmo+bmLBhpKnxxS6yFLWwQUtxydu+tkIq/YZ6++TkZKWc+oY9qlBZ189w9w1MxR OvWff9hCsUtQyhOaxdejGT7c9lIzlXV4eG3YmqxH+5dl+gO2b7t+wsxIAwIIChaeVk7o UGUQ== X-Forwarded-Encrypted: i=1; AHgh+RoSjFkVw8xfAkzLa8igmiHBnmdIAdr3VdlrIj2jERL5UklVavoKuKPKJf6AGLu248VLsnLzMgaJ2fyxpt8=@vger.kernel.org X-Gm-Message-State: AOJu0YyadLC+yp4KB4BY9/M2EnJtBc7pFIiQ6JvR99QIVYUjByBUJg4/ 2aCAX/0hBn2XVZt4KLNr0105hPO8nAA77lH8gty/krYhXn96fEey8DgFHK4uoQ== X-Gm-Gg: AfdE7cmBvEeQmRb0st4Mkll4hzN2TcJbfd3VBa1J6AEvS0SjaJM/TYsZB6A7rZnvyKD RRZOiuLuGQ2UMAxsx1uKKZ7o6q+GP94+Pz/RdvBUgio4NYZ5U+AdvlLQXt7STprQVjA9shyzoX1 JG572y3uzDjerhBaXw78hR9rZGYnnaH+DEsH12ikHA29GXDIWxczHT/M7Kge798GAXWWKMEXJcx rlkfzRPP0GynO4OOQoasRNbKqDWxAefXpWWIbrnR7ZtT/ySZL0wAEyIgTBCSPLZdNDBaFFLN0aH jZnjtOnVqE5lUznSEkcscXaaILsk5cK+m/x5ljyWmmIGcYLXq3nsMlxik/tX6WB9bvAFNes7fh2 9lIooPg102EMdeSvdo49nH23gu1cM3G9h2uaHK5ByIDomyhLxLj8SGo0VNr0zSWPIIecirFjLwf m0vveM4ZjVS9YkyUbxzD00oFzPj4vZjynym5Xlr8ppka6s43dEH6vD9V28Fd/gIJ5Btu6iUe79w 9cyF2sTRF5oVT88IrW4 X-Received: by 2002:a17:903:3c24:b0:2c7:f4bd:91b5 with SMTP id d9443c01a7336-2ca7e525064mr41441765ad.0.1782950636086; Wed, 01 Jul 2026 17:03:56 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ca9a9fee7csm5023255ad.69.2026.07.01.17.03.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 17:03:55 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 3/8] ata: sata_dwc_460ex: enable SATA interrupts only after IRQ handler is registered Date: Wed, 1 Jul 2026 17:03:45 -0700 Message-ID: <20260702000350.68331-4-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260702000350.68331-1-rosenp@gmail.com> References: <20260702000350.68331-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit sata_dwc_enable_interrupts() is called before platform_get_irq() and ata_host_activate(), leaving the SATA controller's interrupt mask enabled without a registered handler. If a later step fails (irq request, phy init, etc.) or if the controller asserts an interrupt during probe, the irq line may fire with no handler, causing a spurious interrupt storm. Move sata_dwc_enable_interrupts() after ata_host_activate() so that interrupts are only unmasked once the handler is registered and the core is fully initialized. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/ata/sata_dwc_460ex.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c index 1561adea323a..43011789c75e 100644 --- a/drivers/ata/sata_dwc_460ex.c +++ b/drivers/ata/sata_dwc_460ex.c @@ -1165,9 +1165,6 @@ static int sata_dwc_probe(struct platform_device *ofdev) /* Save dev for later use in dev_xxx() routines */ hsdev->dev = dev; - /* Enable SATA Interrupts */ - sata_dwc_enable_interrupts(hsdev); - /* Get SATA interrupt number */ irq = platform_get_irq(ofdev, 0); if (irq < 0) @@ -1198,6 +1195,8 @@ static int sata_dwc_probe(struct platform_device *ofdev) if (err) dev_err(dev, "failed to activate host"); + /* Enable SATA Interrupts */ + sata_dwc_enable_interrupts(hsdev); return 0; error_out: -- 2.55.0