From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 454B473463 for ; Thu, 2 Jul 2026 00:03:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782950640; cv=none; b=LRbQ8fQhcoQv0XNDqVUxxP7+MvBUiag6hTUrvgKq7hUwBP37KJ9McgFYlgrQDl7pbiKLQ0lzBjBOkfu0mjwvAydpUnEbbcaElkCrM1GjHM1lBZ3Xt476iA35DndRDKXDdkVBsvDmSFlYQBCk9EsvBzH+g5FqOOzutsk/T5qxCYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782950640; c=relaxed/simple; bh=0c66/QOATJNJVuaMLWD+koTKUQXK5hRt7eSojJLMkws=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X35V3dZKpdFaXtHkdkovm1Eho/emC87gZv4erQIFa3gnXkW/F66fvKTbbETqLQjyklt9yZjIzvGuX6kK8LeV7Ni+UJqHOEjUJv4Dibs6b2MpDXVygyyf4sqtEJlEQOa0/c/iTgFHPjYnt4kFQl5CPR95vAQQcllYO0YkmrveTKQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F2u2j/G6; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F2u2j/G6" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2c82538b6c0so11892185ad.2 for ; Wed, 01 Jul 2026 17:03:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782950638; x=1783555438; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=njx3FT5+2XcrVfOflCbakNVVLX8Z+nm2I3XaOqh+4K8=; b=F2u2j/G6XYGZRO0bs2k32gKPo4mclt6BkIpWjfeoPeOzAueomrmfKbJjhSTzvnzxUX EKrAOm7hCNlvwVmY+y42klAn0cseSfWN8fT/rciz7vOgiFrW6fj1C/tI2EhDCNpFTdTZ GodEtCh7LxyZFx6FLieHg0xON7G9t/KBIuH00CH2XyIUZXy2eGC6DU/JSnC9xTK7z/l+ wSWIt9cunZ7tEijJDpz7ev0rvxrk9Rd5RWz/C148Lu0Y+0rfJBaO1zj9B+z7Mp56V/bG 8YAf/DYsff83dd78rIWNV5QXiJ11j8PlmGWKhSDfiQiFT4BMciGJTn+bjI2hJR/mMNAy OwNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782950638; x=1783555438; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=njx3FT5+2XcrVfOflCbakNVVLX8Z+nm2I3XaOqh+4K8=; b=jrdqEJiaLXulhz6HAw55rW8RtMLbc15OEjeR9fKPHZzQ8e6hLXMSvXpsuLnuqfWxrQ sYC+3pJlOtg0sS6sBJn/sHxbHviNpHKt8ejannVXisGljB0R73a1MBlh2BsjCpM2PO3R BAir6tplTDYAVSL3pto+kWPg81tbhse4qZhEuqiJwZDQRNWJEmDkKRso/tNbwDFWP5qa JGxHIdKRlaIV/jOb9e0aoLxKmc3566+RRo77o4GWwmnu3jImwvzhYcRZmJ7gq7thW9ut 5ph10blMHx9ZfYrFTVn9oRmnpJ0/+Q8AOn3SUymlqVosRVSsOdCnausD4zJeO1/l1fas pAqQ== X-Forwarded-Encrypted: i=1; AHgh+Rq/FLv4xl603PG49v2w6pHm7RxDUHwaVajuxNye5AmTSQ8vV2TBrDAKX+fJqlzA6PHFuOecFrEM43hXTvw=@vger.kernel.org X-Gm-Message-State: AOJu0YwS9D6RFT90K8AmS8gO1JtWMRF0QCRG5FScHFo49p3stF6gjrsP enDPnR7lwWf4C1NFYan3Xjn/fF8VPXQoBzHB0hYfdLfOwsTyqFvn2i2a X-Gm-Gg: AfdE7cn9iauS0kSVC689TvXi7peThb5OJVnJe1XWYc0+PfQskvCCd9lEHG3TQOfcOlx ujT6jCyKEWhcRdiGY2GlImxYq3o1mD1A3gTaWef7zc2Uz0psKP6enP0QChzv22LFy+dU1Uk79iA 33l4Fg5SPTeuwIOvoQPsN9f94rmNdXWZoh2BpIFLXjd1QJyq81eE0jiEfEUkiQPbNL8D5+OlagD k/A4S08mCrC08hb2OsjIE4zhPalFAMG/llH+hfrREuxERrmXbGWzZK5xbVvRAtynSNV5IEusd0s RzL9NcS5IXqJFCBbi9JGNl0dD7epKANqgP1Zjpjp/engzDITHl7yZS75/YMvx2u2Jt512Osx40j Bw+PEYdewE+Uzu1uaAow2TI6bab0Kx5zi/+TdVYZqnFdUBh+QQbyHVA0JGpzl/HvqHQgmzXcsrh Y8Ed1sIwvHXLHOcEMXploaPm3KGwwj9jEeh40eo3p/eiCPsN13fRRMZ9EzfVGGHE6aXd77ocaVW rOa5cwrUQ== X-Received: by 2002:a17:903:1a26:b0:2c9:97a8:afef with SMTP id d9443c01a7336-2ca9121e57dmr24309825ad.40.1782950638452; Wed, 01 Jul 2026 17:03:58 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ca9a9fee7csm5023255ad.69.2026.07.01.17.03.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 17:03:57 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 5/8] ata: sata_dwc_460ex: fix data race on hsdev->sactive_issued in interrupt handler Date: Wed, 1 Jul 2026 17:03:47 -0700 Message-ID: <20260702000350.68331-6-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260702000350.68331-1-rosenp@gmail.com> References: <20260702000350.68331-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hsdev->sactive_issued is written locklessly in sata_dwc_isr() before acquiring host->lock, while sata_dwc_qc_complete() performs a read-modify-write on the same field under the lock. This creates a data race that can corrupt NCQ tag tracking state. Move the zero assignment inside the critical section so all accesses to sactive_issued are serialized by host->lock. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/ata/sata_dwc_460ex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c index 2a28e6655bba..4c54c3ecd18e 100644 --- a/drivers/ata/sata_dwc_460ex.c +++ b/drivers/ata/sata_dwc_460ex.c @@ -467,9 +467,9 @@ static irqreturn_t sata_dwc_isr(int irq, void *dev_instance) int handled, port = 0; uint intpr, sactive, sactive2, tag_mask; struct sata_dwc_device_port *hsdevp; - hsdev->sactive_issued = 0; spin_lock_irqsave(&host->lock, flags); + hsdev->sactive_issued = 0; /* Read the interrupt register */ intpr = sata_dwc_readl(&hsdev->sata_dwc_regs->intpr); -- 2.55.0