From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BE202EB10 for ; Thu, 2 Jul 2026 00:04:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782950642; cv=none; b=CpA85Ieqo3Lk8gbZyppgDU7oaNu+qce1ya2+DIx+FeHzAlFF4k4RH0nuhksOGdcP7aV3c9DNg3pOG5CoSK/TdJi+hwYRo0cwfVbRIb2VhWJ/S8lpTn/7gHdeaCqfCS7zD6OT2Ow7WGleAIJvsAZLrF51QTb8Z8vxcUqHAry2OMo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782950642; c=relaxed/simple; bh=6QVXXXR7VnPCsBDa7jJHLkNn1qJRao3ES0tOJn0qU/I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TUraudxTncZArOYPQSZNFqeJ4l4LRDIH6BUSSNnIK4yF+swT7uSyuLJpCvgDZnKbonBLLH+lC4I9gaJLajIiD36E2XlP3Ns8EzRjlfbeHPyClTWY455CnHW1atp45uNsgnWWrutbB5ABXjEAMheTVUajrdem7VByoayRv8dXlt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rPmt+A8M; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rPmt+A8M" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2c9bd2f8bf7so268845ad.1 for ; Wed, 01 Jul 2026 17:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782950640; x=1783555440; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JLK7HgVTdbwsA8lqGnfEDgi+C7LFUJghOvU2vBmzBac=; b=rPmt+A8MPj0Y3IfA4M/gST0E7W0D1Kb+Nt06kF1JpeFf+iwgJlWRgEmqsCdFNjJvn4 nx2SODAUS4Ljfw1kVK0MjTjL1jmVu43IRRgiqAxDwyFgQwh/QtKGwD/ahDXP9j+z/qOr KEoT/U9L3Cll4Bo0M4dgL2O+sPuxXXeVOAXf3MCXBnIDdX245CPfGGxN/8bawcRhHpw3 n0RunW5RUV9p0u/akXi/ePWLVLIPHyHKMnVJ4gFpVW4fMAPF5Xr52jUuP2fZIDw4W3wl VOvet1A0Y5dqTMQxWkpgxIrBS9uTtJNRtsrmmoScm+vT5PPW1r+fLb3ao4F6J7L3Lr/4 lxbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782950640; x=1783555440; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JLK7HgVTdbwsA8lqGnfEDgi+C7LFUJghOvU2vBmzBac=; b=M2K8NzuqdVDkoIFMMQfXjJiSNbLcT/odKWRvrMG9WQh4Zl7kLAjYsaIS+3mVofm/M1 juwnEfQIu2CDdIEE6PhXvvt7oA5MC8XTIEdQBCp39QaGlxPijDDm1MklkDZouXQx35nc ZssV7je2pYUYol/B55A0ICX/Sbzd5U3N1YcCY2yA6rZItMr7mD9aSmIWw7vVeQ2DAOBi /CXkPJgGLkpdsbh8u+cAR27YqWfl4KvN6BGbjiyn3iKxlpc2Ecxvg2Bv6ymyfAxhWVsk Nen2EDMxzeqvoVzj4869ePk3kIaTky4i2J/44ASe+c5SYVxNAPPobS3yEsEeUCVf5Ied rMxA== X-Forwarded-Encrypted: i=1; AHgh+Rqe52RdPdud1/gXJav4mSMex16VMFUs9pS+KQLms98u9gArCZBCL745n2nVk2Kq/XOamH4OBZ7edv2yUDI=@vger.kernel.org X-Gm-Message-State: AOJu0Ywnjo0XUC6l3MH3JoMfkFeTt+Q8ZZ5rj2MYiaEzD7lkuhrHhGsH 2drq9Mp54+0DV4Aal6Acn+VcOm1qu3BlxXD07DQGIwKt0xgrgBAE0naS X-Gm-Gg: AfdE7clFTNZqxXOW2/eiPu/P3fgUKxhx1bVwcAueKsKUhFGJuQL/UYpxKbfbqwjppHu 2iJf6Z1TBmMuhwa4QdBxGHBZkzbC9ntG7YC28/EY5HYe8dy5uYPWNd0eLEM6S+TFgYWjmGceU7r UusjssJNzFx2QxVHTwHcuoAwVA7y37egWHoq5q3xsyRDpXqA8cwx7+7YfrvlTV7936OZ7niOKgP Y2s3b2JmyXw6Hnzzwrw5ECmRGqrxLnrigK+dT+qpBtwnzSsDdSIHSFdXpDFM4JoKwdjn2dQ6xLp dHl0Q471c5sXDOVD2YGFBlH+womhJWes/sepL2ZwFAdnoY4ddZwqZIS3TGGikR4BI6SYCC82BfD 5X1qeexkcmRlmlt66X0dtXSkILgAWtRE+ZpWWJnLXhg1XtYpv0ARtDrSOQcO1byMjCNHLFHoKTZ v0nT21ASHGm7dxVovkcDP0zBbx7CJvLZfdq5IG3RTfzIcFqInTJj/6fgu6AxI3RUGBV2IjIofFO 605oRXtgA== X-Received: by 2002:a17:903:178e:b0:2c9:ed2e:b8c1 with SMTP id d9443c01a7336-2ca7e754b1amr31988215ad.12.1782950639651; Wed, 01 Jul 2026 17:03:59 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ca9a9fee7csm5023255ad.69.2026.07.01.17.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 17:03:59 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 6/8] ata: sata_dwc_460ex: disable SATA interrupts on device removal Date: Wed, 1 Jul 2026 17:03:48 -0700 Message-ID: <20260702000350.68331-7-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260702000350.68331-1-rosenp@gmail.com> References: <20260702000350.68331-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit sata_dwc_remove() fails to mask the controller's INTMR and ERRMR registers before tearing down the host. If the hardware asserts an interrupt during teardown (after ata_host_detach() but before the IRQ handler is unregistered by devres), this can trigger an unhandled interrupt storm and potentially lock up the system. Add sata_dwc_disable_interrupts() and call it at the beginning of sata_dwc_remove(), before ata_host_detach(). Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/ata/sata_dwc_460ex.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c index 4c54c3ecd18e..f26220cac130 100644 --- a/drivers/ata/sata_dwc_460ex.c +++ b/drivers/ata/sata_dwc_460ex.c @@ -759,6 +759,12 @@ static int sata_dwc_qc_complete(struct ata_port *ap, struct ata_queued_cmd *qc) return 0; } +static void sata_dwc_disable_interrupts(struct sata_dwc_device *hsdev) +{ + sata_dwc_writel(&hsdev->sata_dwc_regs->intmr, 0); + sata_dwc_writel(&hsdev->sata_dwc_regs->errmr, 0); +} + static void sata_dwc_enable_interrupts(struct sata_dwc_device *hsdev) { /* Enable selective interrupts by setting the interrupt maskregister*/ @@ -1210,6 +1216,8 @@ static void sata_dwc_remove(struct platform_device *ofdev) struct ata_host *host = dev_get_drvdata(dev); struct sata_dwc_device *hsdev = host->private_data; + sata_dwc_disable_interrupts(hsdev); + ata_host_detach(host); phy_exit(hsdev->phy); -- 2.55.0