From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0214131355D for ; Thu, 2 Jul 2026 03:57:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782964641; cv=none; b=A5+ZeUeXP+BwXXaNLBYsuuxpKaxinXL0RiazamCiAEym/jsUT28206l/cPberShmLJLN5sNWfeyrtB5+0wHsFM/YiHuWWRmqA1J5HvMIpr0WoLxQ7wWp/2m3PPgwdx7frFnZEKORNzk9rHSHGE/mux5Gb4QonhIoS9M1aDIDj4A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782964641; c=relaxed/simple; bh=Dea0npz6HPZLl0DOuyuNssrfQBzDEQWoBZO0gFRkntA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=o2d578iFIRfDwdZo43vM8CJrWYvbeKeXt4YdJzup32hHkhk4Usfrex3qvD7l+Ibj9c22op/zGNZfoTUzqJh0UtGr478XnbHJltzj8eX2iGfk3QSZbPus8THbHWPNu/FKkotHkDhblFgGBS0qBuODrLkH9zluZP0pwjPoDaXoILg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p8F9KJpx; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p8F9KJpx" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-37ff8e0ad0fso1072337a91.2 for ; Wed, 01 Jul 2026 20:57:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782964639; x=1783569439; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5ShZJ2sm5lR2QN8PCgV20vECR5rK36eWk9DejWlPzgM=; b=p8F9KJpxy5caDa4D72S5giB5/8xz7N4b93I9JU80rzUg35V5gyGjXcG6adO9+TgM7u 0lZTPCpiXmqCKMkR6cjKQMfHSMcL48sWs1jd1LhRxh9rRJrDgPaYab0uzWjFEWSEGTBX qLbskxxN7B31t+CdWynQd5as0tArRf/5HpAlSYx52H2McbR5BhhSIFJqnWxVM42OMB02 AY/X+oIy/kZbIluuONJwoy1Wm/GRmqARbRdB7NZCqULkKSa0iZPHz2W6mhzLz8eeWJqc /vZWrXK7rPk/QLrdDdeL43IBCjjUTrBVmgNcCRgnsKpoZwPHFpkW7flapWJ9Eu7dosAs JCcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782964639; x=1783569439; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5ShZJ2sm5lR2QN8PCgV20vECR5rK36eWk9DejWlPzgM=; b=UkK1XoVYoAxjzqqT2qoyIkbEIFD4JI2hDKNsBNZ9+CbSCmOeEhvaMhjYgZda74GqPd SfpRTPk5zI8XNyljsoiwmC2oLf19VRvdUBimROSuzoKFyB3W7BZbYJ+SFHrLUlojIzqi 4/eUP/KpCroYo/akuaTRn43VH8UZsigmAL3NeGiK2J/TCaIzY4+IUSxYYzpNK7kWgfr/ DxBUhjU/Wsv0JstgEsOqH0I7qXlw0wRqeIZfZZfexTcMwNjajGg85VItzEb6cnNqVCbM QWTHe/fY/SSY7zUX3psS8UC2JG8/OlBRS7/4+IwgvFo8iVJOQTtVkUnyTAVZgqE+Vd/y QDcg== X-Forwarded-Encrypted: i=1; AFNElJ+KqIwahPv0IMQQIWZxkfSimksjQuyQyU14m9XLMY0V8YlFdW7ZVga18kv2mlmLzA+wtI95BSggTwMbS/s=@vger.kernel.org X-Gm-Message-State: AOJu0YwjY6rvMJ6x3BVyHQLBDBFzobOcE40KZzdueXWkAMXwDkb5HNuY 4SwkN08cTbjctTQ2ADS6UEWUyZFYLpfIgnFrvTgO5wNseFUL4ubjmXq+ X-Gm-Gg: AfdE7clZKxF7oJXHXZc8NvviPHDcp1SlhrDxZeN8sN+dTtgfFTVSiENk4YbApzkWpIV 3zR4g/2MKob7F3iydksj+e67kODELTkczwtsfUEEAxN4SZRinHQRup7VXPJyCqddDWRYGqf2AG6 EGUKZdgjX9KONkN/DEydA0HX4LZife/+P85umtBKKF01yHU9rek0CU5K5PpFpUnUOvycpZHb5rs lp5gC2BgMSbeCFYTxagL2WRzLFW3JQ/FK1+y7QXcvZq/H3y/4LzOdMFE0QtfKvJJhKXovjAcbGN Okp5vdzuVYte/ULdNkZciCo+4Tp9gPtTjixjE0M+ph1DLGmMmypnotb6iXICFF4XIIodRqf62mw mIlOKa7VhkM9attZ9qPzFLO1365bu6H8Uq+e5y6zhVi6W6ASPwI8ABBNCuBP+g+iL9fZn42VC3l Wcd4oEGP1vY4YfRPB3y3P+rcFZebVdX2su/Ye4Stcv3+4S/Mg= X-Received: by 2002:a05:6a21:4d92:b0:3b2:8685:118b with SMTP id adf61e73a8af0-3bfed16993cmr4852957637.20.1782964639077; Wed, 01 Jul 2026 20:57:19 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c9e8eb0ef50sm678879a12.6.2026.07.01.20.57.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 20:57:18 -0700 (PDT) From: phucduc.bui@gmail.com To: Jaroslav Kysela , Takashi Iwai Cc: cassiogabrielcontato@gmail.com, Cen Zhang , Kees Cook , Mehul Rao , Nathan Chancellor , Sebastian Andrzej Siewior , Mark Brown , Kuninori Morimoto , eilaimemedsnaimel@gmail.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH] ALSA: pcm: Drop reduntant nonseekable_open() return check Date: Thu, 2 Jul 2026 10:57:04 +0700 Message-ID: <20260702035704.27092-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc nonseekable_open() always returns 0, so the error check is unnecessary. Remove the dead error handling path. Signed-off-by: bui duc phuc --- sound/core/pcm_native.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index 7dc0060617f1..b245b596d95a 100644 --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c @@ -2874,8 +2874,7 @@ static int snd_pcm_playback_open(struct inode *inode, struct file *file) { struct snd_pcm *pcm; int err = nonseekable_open(inode, file); - if (err < 0) - return err; + pcm = snd_lookup_minor_data(iminor(inode), SNDRV_DEVICE_TYPE_PCM_PLAYBACK); err = snd_pcm_open(file, pcm, SNDRV_PCM_STREAM_PLAYBACK); @@ -2888,8 +2887,7 @@ static int snd_pcm_capture_open(struct inode *inode, struct file *file) { struct snd_pcm *pcm; int err = nonseekable_open(inode, file); - if (err < 0) - return err; + pcm = snd_lookup_minor_data(iminor(inode), SNDRV_DEVICE_TYPE_PCM_CAPTURE); err = snd_pcm_open(file, pcm, SNDRV_PCM_STREAM_CAPTURE); -- 2.43.0