From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8E412253EC for ; Thu, 2 Jul 2026 05:03:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782968582; cv=none; b=PKW7nMmAIMvSi19eTcCq2KgYm2Y2fSyZeImRP9U/rXmdMOAaE0VTY0hbbjAsaJ9Ek+yFvegNdjz8sbkiRHK96Pt46e/W9gXctdYZ32/Ab0wsQvq07Q0oUAbtzcec+/eBG1a8sbJzjP0bqjPA4Tvig+OkA+TUD1x5LhvZCPmXihc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782968582; c=relaxed/simple; bh=3cZMBba94i/5R8hH7vn8i3PpOCKE7KD/nEun2UIZCnw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LB1p14bvsaNnecxtBvC61xC+byFqpemxY1sd9EF98uhqaKcSK11VrYSgq6kPFfzmYfr7YAUdTC58+EW4GLAiSQicpuJKl9abu0TTRahyuLQRK701QhGJ61NMr65pXgnq193for3lNFFY20W1CkrfXXbLCG7xRseeAR9BC8F5TZo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NUaIVuFj; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NUaIVuFj" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-8478a25f268so897867b3a.2 for ; Wed, 01 Jul 2026 22:03:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782968580; x=1783573380; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EVnJLydBr6ds5nqVLQWS01bEPiCKOptWg9PYdANnJMA=; b=NUaIVuFjOTT31RK9WslAtEojqfLV96C9z4eiMEFwuOir+K/5k6wYEJGkncoDwBYg7c IaPfU+25hi4UbBDV57w3RM3715ZVRfznJXPf083JXHnFCs6pZmZ+Ec/gT8kkGJy4w5hb Jr3dJvEnzj0kZDnCg8BaPDK/qVYuPU79+6j8qwOGX6UZzQ6tTOEbEvtmAf+VAARVTZgv A+jWiuShiIXMOTa+2HCo6gwPiCxFh/tMJqsSwiSeg/NfFFJTGU9SXi+/xkIoSGmPyS1O RC9/QN4MIgGtFA+pccAcmgbYK1xYoDJcGROm7GKx5woiHuXdO4nedNfoIpbZ1r4TkCHp dm6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782968580; x=1783573380; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EVnJLydBr6ds5nqVLQWS01bEPiCKOptWg9PYdANnJMA=; b=MFV8QHQAbl4KsqaFCIPTld7d9s9KgAenX0zCKpUMCWnjSmsfQN2oBzLK7+oIUX240f jcewl5nvZwxCBtIouvhSMOaTFORVi6IQHarYVmJsUv+Xd8d/N5OVqqQ0ZazTWl1UkXXs cabMr0OjkmZXE+L1QeQtx1a0HeeBsITu2zYRZ+hqcY5thckDsgVcfDdy2K6SKF5eN21Y HFyK1M5uXpu8bQLLMGUiUyI2JaweF/aOS47V//FJsYPfeR5Ny+/4eR9jFOZ+rPTEtpBq JjEwS6v1bzjtd5spE3EowJMDQyHA0xl+pBYc/Qp3N9t1+MnFP9W5feurP/2R3V+OO2Ad LaAg== X-Forwarded-Encrypted: i=1; AHgh+RpeW6GSwhiPcr78W3r5PzeHlAA9GzGqKwY7Dvwmyl2gQUfIKaO3cy3P57EiqeX2BgPL0+a8JyVxv28yA6k=@vger.kernel.org X-Gm-Message-State: AOJu0YygKncufkUxeclVm07Qs1vCMSdRKJ253/mq5DrhO8ZKRwNBDfCz 7uBc67+qLAMmNYI0Grqci6wTdhxj08OFTB8Q5hqr3iMf9hHMVhISuRUX X-Gm-Gg: AfdE7clm2bSPTC8yIwQoYx5LQf3d3Tn0vKijDRxbtGFjjiyx17ngRSodYn4PETLIFpw KQorqq1Y+6HnPrG4NA6Kuc1CZ0XVgHoF+3yqk9DoZoI69Yk7781dzSH1FWl1+iXdC4rGRY5r6GR xO2IhEsIC+q9/sE3VVNOAYgAeHus9VFCBXZU3BXcym+BIxripzb9xnhlxPBwvD+nObi450RAleQ WwfZ5yerxr5hoGIxxFkFzlhShTD3NJaaFkMYSCd4WyJIRo25Wdqk+RNKUNpiMFQONkW6ZfCYO3J Zp6tejpb8Hz/QLDWBGLpLKqGat+ptZZFuVhcvdixrMrD5aeQx67oR3XBuecnHo/doqMTNspTTKu EGKsQeczrmrfvI88lNwOd5MYqL0RSI4EbSZPN864dcCSZMXPwq09EUp9j9FYeG9Wid0UZQIoOW4 18BgDlZy0FwY/zuXrZuFVfBGzOM3ijOvY7s0/IFZ2NgE+uKSM= X-Received: by 2002:a05:6a00:8008:b0:847:968d:b0ff with SMTP id d2e1a72fcca58-847c51ea69fmr4408906b3a.55.1782968579876; Wed, 01 Jul 2026 22:02:59 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847cb98806esm734869b3a.44.2026.07.01.22.02.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 22:02:59 -0700 (PDT) From: phucduc.bui@gmail.com To: Jaroslav Kysela , Takashi Iwai Cc: cassiogabrielcontato@gmail.com, Kees Cook , Dan Carpenter , Cen Zhang , Len Bao , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH] ALSA: oss: Drop redundant nonseekable_open() return check Date: Thu, 2 Jul 2026 12:02:36 +0700 Message-ID: <20260702050236.30751-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc nonseekable_open() always returns 0, so the error check is unnecessary. Remove the dead error handling path. Signed-off-by: bui duc phuc --- sound/core/oss/mixer_oss.c | 2 -- sound/core/oss/pcm_oss.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/sound/core/oss/mixer_oss.c b/sound/core/oss/mixer_oss.c index 591cff800329..6161740f67fa 100644 --- a/sound/core/oss/mixer_oss.c +++ b/sound/core/oss/mixer_oss.c @@ -31,8 +31,6 @@ static int snd_mixer_oss_open(struct inode *inode, struct file *file) int err; err = nonseekable_open(inode, file); - if (err < 0) - return err; card = snd_lookup_oss_minor_data(iminor(inode), SNDRV_OSS_DEVICE_TYPE_MIXER); diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c index 9826d9a0be6d..a0bbfa0a7ec8 100644 --- a/sound/core/oss/pcm_oss.c +++ b/sound/core/oss/pcm_oss.c @@ -2496,8 +2496,6 @@ static int snd_pcm_oss_open(struct inode *inode, struct file *file) wait_queue_entry_t wait; err = nonseekable_open(inode, file); - if (err < 0) - return err; pcm = snd_lookup_oss_minor_data(iminor(inode), SNDRV_OSS_DEVICE_TYPE_PCM); -- 2.43.0