From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 978D7360EF5 for ; Thu, 2 Jul 2026 05:29:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782970170; cv=none; b=g4t5ISeLyGIhnlYIAh1vuEzrhibbs8IzE59KsBzx/wzh9gUGD0EQufX69lms8yoxczbj+MH27jqJFEqQoiRkCdhc16UUesqlyZgeX6J9Jmwf5CrVuX8FlqEzr6kgNvcJvWxFrJzTzwxIZ0GIETSk6icDknVfNCho4qiN7jdksvM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782970170; c=relaxed/simple; bh=0UBAs8GFxSD+zNRCAUGHu4PYPrZacqlrRTel1GoW6zk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=WhkX2obVE9y6wGupO5cOJHSSPs48KM9dyZOnVgh1AKm6xzZ/nowKsagSTAKCHNWmPhyOOBYwPxjB20yi3bDtZ+YJa9anF1SxJWFzw2FzjY2OBcTkF1qmIAoN7a78wuQcag+5nKMXz5aC6T0IoYUBwWwmLWk6aff7sE93vyErchI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y5nlS4Ur; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y5nlS4Ur" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-37f7a5a217fso1107345a91.0 for ; Wed, 01 Jul 2026 22:29:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782970166; x=1783574966; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=+ruFjDhoaXJQkokcbjLpD7A+2yXhuFwXH3/7PsBDPQY=; b=Y5nlS4Urdu99tUGBXYzwOWRbHUns5ngWRufPh4kbgQdN1JLJExYGAXx1zvBFaxtLP3 qdQXY861u7FlSX+J9PgFsUZk7/Jzofik59BUeASsTRhHUmpFIAgSZkoykeVy65qISJsZ ZFxnnBm13FyhDiywtB46lMT9sib9lzysTzach+1pr/i4Q8QsyWXdTDoUsJTwh+CZ7Wmc QXMxPO2Vs6cAujAOk+0tTGaISfVOaohfbZe1c5Yx65vcG4rYkxSe4ozVaz6Memc4oh6U WXIQcjX43RPFghYNVP7Fje7tfr3CKBWULTaVUpv0L27Ko2E6nW1z5GdnDgzzUL/KyVsH Os3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782970166; x=1783574966; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+ruFjDhoaXJQkokcbjLpD7A+2yXhuFwXH3/7PsBDPQY=; b=LBrDlFIhFqw18WiMKTo1zGltIKsTBw0Na2znyqk0ZtgbuGb9eZZnmQG4fSwJ/J/uE2 qJavC8hmHn8ToZjdlm9Lx1jWhntZ0GfyeEDohKglyGSujDttDZMWD1XAEZiJhbP+nwfZ Wqlhn6KNX1evuKcsdYk+rZgSnWBUzSbtCqDWAA8h8j2QaI7MuA6ph+Sm4FRGx9NnCYSu I9LNAV/vAn20ihcdnqCS27Eldvxw3PY9OpvocSHylZaze6J/O7P80bEgv5lW+7KR6sYu xUgjjGWalnoCBgYHvGm6YiJCNYZezVrEAFyYrzBx3Dw0O6q3kZGhzCByKMYA/OrG0vlm eD3Q== X-Forwarded-Encrypted: i=1; AHgh+RpWOsaP6ODkT2BJUIrLh7VvNK1/Bm2XIttRfii/og4hwAomyhOSJeUQ5gVGAiiHffuiCh6HdKS/4LE5Rq4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3CGqF+InsTVyBp2ZkzBFarJmgH8IDlpYk9FUBqjOdmj7ZbcgI 9274kTrrMn+g42LAYg5nFhImSim7LMVh4s5vqeNfJMU9ZvufLCVp5Vk4 X-Gm-Gg: AfdE7ckG1/SVMmEQL2Uyd3/XroSXhiJV+3HkJG1hOtIfFwsl9IcCH7riJMRhEm7vDoF b88J/74dviXKIdLz4olB4X8NFk1jCZ16Jzqzj07FN6TVVRU/qkSSzf8CFODTSRjzwrT16sWa71w i/hPBoQfd8PYNrTiyA5X5NfFPPqoIKb1KjoCUlqyVdJdzxqhzmyAyRZVqnBCYpIyEYYGxRjazXD nPxHH7LoZE/G5fKulJ7STkvUoA0DfVgoGePMBnxP0cSgGLoH1/YCK5/v1hAVtPL7Uk1R5RYZdlV auhwq3NUG/zaC8SsxTQNWMeT3anGi5whn2Jcg/sKqVIB0aNktWYycX5wmqFwQUSeRi0fLrxTy1I hng3uKV2K8pyPC/vpvqHc8LAwX2zaNrSLdCs17IU61qHV+GS70QthqoYWqFLAn4/nVhSJL95dvN JzwwBAGYR8TYgI2wOaSMev+f67rRofM/Rkyt6fdkk1gcjgN9spdns= X-Received: by 2002:a17:90b:2652:b0:37f:9ce1:735a with SMTP id 98e67ed59e1d1-380ba91c157mr2861802a91.27.1782970165714; Wed, 01 Jul 2026 22:29:25 -0700 (PDT) Received: from primary ([223.181.23.42]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0b7b9a1bsm4770046eec.3.2026.07.01.22.29.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2026 22:29:25 -0700 (PDT) From: Vidhu Sarwal To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , linux-kernel-mentees@lists.linux.dev, Vidhu Sarwal Subject: [PATCH] iio: light: al3010: fix incorrect scale for the highest gain range Date: Thu, 2 Jul 2026 10:59:13 +0530 Message-ID: <20260702052913.114130-1-vidhu.linux@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit al3010_scales[] encodes the highest gain range as {0, 1187200}. For IIO_VAL_INT_PLUS_MICRO, the fractional part must be less than 1000000, so the scale 1.1872 should instead be represented as {1, 187200}. Since write_raw() compares the value from userspace against this table, writing 1.1872 scale never matches the malformed entry and returns -EINVAL. As a result, the highest gain range cannot be selected. Reading the scale in that state also reports the malformed value. Fixes: c36b5195ab70 ("iio: light: add Dyna-Image AL3010 driver") Signed-off-by: Vidhu Sarwal --- drivers/iio/light/al3010.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c index d603b4a6b8e8..cc39f8af4ea3 100644 --- a/drivers/iio/light/al3010.c +++ b/drivers/iio/light/al3010.c @@ -42,7 +42,7 @@ enum al3xxxx_range { }; static const int al3010_scales[][2] = { - {0, 1187200}, {0, 296800}, {0, 74200}, {0, 18600} + {1, 187200}, {0, 296800}, {0, 74200}, {0, 18600} }; static const struct regmap_config al3010_regmap_config = { -- 2.53.0