From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CCC01F0991 for ; Thu, 2 Jul 2026 08:45:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782981911; cv=none; b=QNJKZ0lJUDNlC53Ikaz80M3ihfRlA8uSCU9Xya/q5u/UkunYj5s0M4szqbfWveiVRFH7T0VBfthcQplmHJitWl/KjPoe2bCqtuxXT10BwReRi0qUrli9dDrxpFKwT1bb1wKPJo/T2o2l5EbGvZkSFNJ5S54Mno9cy8Zt+panFgw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782981911; c=relaxed/simple; bh=4wUOlaRIbhKBaxGXz7dOQvYCJ3ALv11ugMrbqSWl/Og=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lhGWt4nzWFrm17WnALKtBN1aTNPkN6q52r7O9gsAyVs6Hixprk5ZvWuVLJQsrP4cks9rbdxaRzCZmo7YsU/MimlEY2q7CA28ZR55H7L8VqRXJiIBsnY1YCxGI84qNmeD4P+3GVk4CITPRixI68rskX/qgpgSocnePtm9VsDxPgg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sY4IFNcl; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sY4IFNcl" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-380d9481551so615602a91.0 for ; Thu, 02 Jul 2026 01:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782981909; x=1783586709; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fcRYwuw5PQQfqSUU5fD6q6zAC9xCDDszrpykhw3M5xc=; b=sY4IFNcleA0l4kkm5WJ+L8uiRKeOeeGautuLzuNjhW+50inl49CMC0DQBoM9uJkwiE 7aqI1IHJvJ/RWYc29TY4fOVY03l2tWHPj3qlDnAdca0Z2qS9k6qS6d2o34mpdFG7Zxo6 HPgt+ZjgvTXV34XqbCqqOu0OixK8gwS/P7qGUUnuUJz+dkjaB2WtCg5oG5S3jtOp2FW6 6u7p002tArw9Ms0I4YXoldRYYFGflduaIFnBWmy6b64WOrdcQ0LSgXBm3MJ0K0mqbPr4 JPmUwzCIUmGc+yU80byv4wOct8KDbMNPBvpjBXjxZpAk8un5m59B9xt/sZFhJUN6oHMD E5AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782981909; x=1783586709; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fcRYwuw5PQQfqSUU5fD6q6zAC9xCDDszrpykhw3M5xc=; b=IKf3zpmqGu/zISAzL+DTJaD2DrKvi6bOOKUfi2cPC1SMzH5V6/3Nu8EuDDsa8V6Eno vw1mJvCZhExaoiSF2ylhyyf+xpA4VkMrPVzBFl1BDzo+MB3STcEbNWXPWQsvAx181Gel tmAzTfqNu+kCgr/MRPR8crnuJ+1oRcrzeFDVucuxFgwe8ePCVGf9Oeg8vxgDeilPmRX6 ahkT6C9IrupmqAJG9Jl+DcsDPg+2wyDHM9gvTEX7tkD9qzEr9CNyUfY8hcnOeUOJj+sP N97VP7QW/uvPmURdTxKCCH/Kc9zA1/a3FpxczlEFQBDetUPkujoG09WJDhF3y1OH7a30 xofA== X-Forwarded-Encrypted: i=1; AHgh+RoxUmOg4ejPoEjCh6Fn+uZp6kYS/X6tFEvgCw/MJV4/W6oT6PA2EHEOAkFA9ZZNoTVa1aiXNqzkOv9mujU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/ijSNO8MgW3+yBnmIekmBQafADmXx2MXwRR/Is4wR+DmtolbB r2QlO6QqWQDuvpr7tQarX/xUeJmhoy8b+HJtGOa40RlE634Nd8kuXEk9 X-Gm-Gg: AfdE7cnMwiLasmJwWCDFc0O3fG0NbDiv6thStLu6Z9LN414Yx1D0zbPaFjlf23C8WY9 bGKjokPOy/B2l8MhDjH1yY6hc4cHR0sl3vLHjwjuSaPdp0rEPfe1YjUzYuW6c07mUZqGrw5IfQ+ 4ouVnSRPF3EC4C5jMlnMtvyUsKVlMAOzEtTDg3OuGeCwvTjI3AdCuYXMy7KSFuEc/86OwAMwWll 2TWRyp4UcxrZnKo2BQ3S3aPtYdAItarqaDwOcDW28wHhP2S0BAA8tDBiZIJ9flKTxW6/TrBGely KQemMNTHxDU4TKiWkEZGKemzPQ47/rfncQ2ak/9f+/uAbl/dtX8cEqn32kpJihnAz3LUAXktjRh BJ5dQXk0nuECgTbqiDkAfYuanDDiRmWRILZn/hKf0GNrSQfif1hn9FO3mVDLnOgB8pnqUnFM9El a+/00LQULB4Y7pHY9vGWGWAyc6DFDO6Gqx9Gm/uKzfSPHo0E4= X-Received: by 2002:a17:90b:2d90:b0:380:9d0d:7af4 with SMTP id 98e67ed59e1d1-380ba86979fmr4587276a91.12.1782981909211; Thu, 02 Jul 2026 01:45:09 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-380e18fbdb4sm693955a91.17.2026.07.02.01.45.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 01:45:08 -0700 (PDT) From: phucduc.bui@gmail.com To: Jaroslav Kysela , Takashi Iwai Cc: cassiogabrielcontato@gmail.com, Cezary Rojewski , Kees Cook , Ziqing Chen , HariKrishna Sagala , Dan Carpenter , Cen Zhang , Len Bao , HanQuan , Kyle Zeng , Dewei Meng , Maoyi Xie , Mehul Rao , Sebastian Andrzej Siewior , Nathan Chancellor , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 0/7] ALSA: Remove redundant open helper return checks Date: Thu, 2 Jul 2026 15:44:37 +0700 Message-ID: <20260702084445.519669-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Hi all, This series removes redundant error checks after calls to nonseekable_open() and stream_open() in the ALSA core. nonseekable_open() always returns 0, so checking its return value is unnecessary. Several users were later converted from nonseekable_open() to stream_open(), but the original error checks were retained. Since stream_open() also always returns 0, those checks are likewise unnecessary. As a result, all patches simply remove dead error handling paths with no functional change. Change in v2 : - Drop the unnecessary assignment of the return value from nonseekable_open()/stream_open(), as suggested by Takashi. - Merge the individual patches into a single patch series. Best regards, Phuc bui duc phuc (7): ALSA: control: Drop redundant stream_open() return check ALSA: mixer: oss: Drop redundant nonseekable_open() return check ALSA: pcm: oss: Drop redundant nonseekable_open() return check ALSA: pcm: Drop redundant nonseekable_open() return check ALSA: rawmidi: Drop redundant stream_open() return check ALSA: seq: Drop redundant stream_open() return check ALSA: timer: Drop redundant stream_open() return check sound/core/control.c | 4 +--- sound/core/oss/mixer_oss.c | 4 +--- sound/core/oss/pcm_oss.c | 4 +--- sound/core/pcm_native.c | 14 ++++++++------ sound/core/rawmidi.c | 4 +--- sound/core/seq/seq_clientmgr.c | 5 +---- sound/core/timer.c | 5 +---- 7 files changed, 14 insertions(+), 26 deletions(-) -- 2.43.0