From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8424244D03B for ; Thu, 2 Jul 2026 08:45:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782981923; cv=none; b=da/hG38rB2udOsf4f5mPbdXFb8JQ2AljOKOPMrQckYG78FTa3rQ5q5sWSYmkgL5OWGzFfyfp1Rqcpa/Mkhpk8Fzsbkje4DY+iS6YR0SJZzakaQhaU1Re7qAqTVHxvp/sefh32yPGZn4bjUJrJ9uIz1i3N8bSebwgZ5qnN7ieBQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782981923; c=relaxed/simple; bh=tC0YGMm/KhJuWZyRjORcdoPTpJ4Xczzf731BO+VkT7I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s0ihn9Kc+gaYSSU2mUjvcvzyWWH+ITX+gPPlQGjoy63me0nu3B/lf+wXWxiFIHxAYprn4uBSaVHA4hdXSJe6AdjVQO45OnW/BG338b8WOSj7I1GUBw5lx8xAwPkwrf5F84l0bTy6f7WcILlYCMzD6jNewexbfZr50KmRECK6G5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E5tvz/eh; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E5tvz/eh" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-37f816d01e3so1498116a91.2 for ; Thu, 02 Jul 2026 01:45:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782981922; x=1783586722; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z2H3EPpox//CfhCeR4d3j8ebYuJ/0AFhLubgcA9uxdg=; b=E5tvz/ehOJCP5u5AHIyVC2Au0GahonUeHkYi0shDh/KYYTxXtsG1X4c6iXdDQXDSEN tU660HGkhQMKpfWuCopa+ovfcv7nzjEXtQVtdZgYDEUXzatkqatbWOCIA8X/3vNAQ2Y/ Es72+lUgXIauUMk9VfKAbZcspHJV67BxtdLtk1smFwRpiKjd4WMj4KKMCxNjKweiVcOm 4hGQ3Uz+ON3L3e5SKrL9H384M/j1pXIZd432WEWPvb6/5F2CpQmbXNaMbzLMLrm3o0j2 KQp1EtJ1nSk6QhmfyuzfGXqT1tZvXnd6GKBNHVRQ6fYW/WFEEuZjEac+RfCgyV5dBtWv Oc5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782981922; x=1783586722; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Z2H3EPpox//CfhCeR4d3j8ebYuJ/0AFhLubgcA9uxdg=; b=MV1kNU/rYc+4BSyKcnKwrZRiZzLzlAxast+O5TuKjU2hTiXZq4kQ5AtRHsJfpvP8c+ UZl2QDNBvfVdZEqI/M/Pr+upCBFD8YqlTd7JP53bKrPsEXmmutiedhZczJNvgTkK7vY+ W+gVk8HXJGySOWGgxPfhfMHGs049AQ67lvvM2cCf5+0UPtSbWsN8lonyi+jV7LZ4IDvD UOsPQ0KcOv62T5vDQQxGxVgcyXNd22qoNYLXG29QOvOC5VwUGKP6W1N7+19WudwNe0O/ 8Mw2Hs2o/B+wVkKM/ac8VGjDZNNxzEOgrbsksNPib/gQP4EgRZoTIMZslnb/l+mr21GY BjSw== X-Forwarded-Encrypted: i=1; AHgh+RoGvp3W5Hdeg3VcC3Xam/abyPaxlDGa5z3Lkconu8upUE/YBoAI71IuLNEThTE9RbngGUkJ+GE8AwBcAuI=@vger.kernel.org X-Gm-Message-State: AOJu0YwnJEZd6rOTB1IrEHSQL0e+ihj2Hg4SXsimf8EP9xzJpCeh11wf JEUi39C9o9VESOj7cd3ZWIDjlWM+wu0DdlzJ+nvphzTTuqsoIok1JZKK X-Gm-Gg: AfdE7ckKOCxbhqXXlrTnxLzA1AazpDDg+UV6/nmICleB53XoFhl3yLXdJ+BLaQJyKnU 7esCMn5hfXvSEBt+zKi0fZZeKb2CvV1yzMkmY5flvReanNF1XE+JN7zMiL2Qobs4aRx7odzgybF r6Je1OF0mysbmPsSg6kGOJKHZveQZHTaBRi6WQoeLbJpjlJuvgaS96q6Y1bsatjDVR6kMjexVhl YxuDA3C6g11taxDWgdGaFxJfttCUw64iDuqJ69I2QI5jf6RnRBZh3273KIsbB5URVHzs78hHO98 TSqPDaXVFSj3RTLuANAV3hHODJ4XtXnYfXOr6fZSwjIS/g0VYtRjSHhuUUlARwZEu35EFsX0aVY T2D3g3Sk0/j1dlv0xsykSsKIowXSqnMS4N9S3nVimgBbKCz3CefH99lZky3P97CE/emES+zR+ZH LNk8lRH6ojoUp4r8t7y0rN1WgdfVLRn/EQbv7w0H81c8ZDbXk= X-Received: by 2002:a17:90b:2dc1:b0:380:40b:f30a with SMTP id 98e67ed59e1d1-380aa0b6894mr5087769a91.13.1782981921650; Thu, 02 Jul 2026 01:45:21 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-380e18fbdb4sm693955a91.17.2026.07.02.01.45.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 01:45:21 -0700 (PDT) From: phucduc.bui@gmail.com To: Jaroslav Kysela , Takashi Iwai Cc: cassiogabrielcontato@gmail.com, Cezary Rojewski , Kees Cook , Ziqing Chen , HariKrishna Sagala , Dan Carpenter , Cen Zhang , Len Bao , HanQuan , Kyle Zeng , Dewei Meng , Maoyi Xie , Mehul Rao , Sebastian Andrzej Siewior , Nathan Chancellor , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 2/7] ALSA: mixer: oss: Drop redundant nonseekable_open() return check Date: Thu, 2 Jul 2026 15:44:39 +0700 Message-ID: <20260702084445.519669-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260702084445.519669-1-phucduc.bui@gmail.com> References: <20260702084445.519669-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc nonseekable_open() always returns 0, so the error check is unnecessary. Remove the dead error handling path. Signed-off-by: bui duc phuc --- sound/core/oss/mixer_oss.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/core/oss/mixer_oss.c b/sound/core/oss/mixer_oss.c index 591cff800329..f5bcc7896542 100644 --- a/sound/core/oss/mixer_oss.c +++ b/sound/core/oss/mixer_oss.c @@ -30,9 +30,7 @@ static int snd_mixer_oss_open(struct inode *inode, struct file *file) struct snd_mixer_oss_file *fmixer; int err; - err = nonseekable_open(inode, file); - if (err < 0) - return err; + nonseekable_open(inode, file); card = snd_lookup_oss_minor_data(iminor(inode), SNDRV_OSS_DEVICE_TYPE_MIXER); -- 2.43.0