From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09EF3466B4C for ; Thu, 2 Jul 2026 08:45:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782981929; cv=none; b=TlJcQ0TfGLKepyhTsQXQujM3NeITlojZDXYomPGaTI/9Sar8e08/pF8e+ul5q7rg3RRQKQTliR/ukmh59g3AfVcSUt429S5XjkS1dBN4hAserVrEPgqDzAoMfOek4rMm+1qLoJoyDIHDEglTVoNEbg2bzl78CJ61CBByEfd1x+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782981929; c=relaxed/simple; bh=AhD3wlmEqBAT3HlPt8IYdhE9e9qHrgsqPhmiCfPkPrM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uNhqOlnw89bHjYEwsY1VxA3YsljisO5ymqojOm+z3ZSCu+8+FQZqmqhovMjXpHH2wc2/hxMRT74y22F04wTIZLSPy89zzHMoLo77LK0Uzdo/LMuwYXICVIvFwgRP6kfMbysLHKW/g8MFd9a2PsirzJgcGgByLYnOFOJdhBOyy3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aJjuIxZ2; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aJjuIxZ2" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-37ff8e0ad0fso1325551a91.2 for ; Thu, 02 Jul 2026 01:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782981927; x=1783586727; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+ynYj3Hv1c2SwjRZ0G2WJklJeAWxlh9A39Rdw7J9Hfc=; b=aJjuIxZ2jaBF6VFNf6mLg0bM7StaowLqiKMioTMSMOG3oX3w/iVKt6YBbWOLA+ysZZ Z/P58Syk/mLOBhPhaRAuXA8BDlq6bwN9e6DKH6yS5ctVLYjYaVIvWdkpDjDBedrclZGD MW7qaFxf9mIxVDDrSpVDwxAQziB7axXsud4XzvQ5bdO7EIH+aMh4A+AcFsGKBxT3Npah UPdtC0YhRGekAK46h+fPldiqVCx3fOK7O0SFIZtNTubJKXQBHtWtmqrMDuKRVMz4Q4xk 9k0xtOTwUdrT1bpXQaUvYQo+pXeKjJG6kkb60of1gt9QfV0q4PVVBN1EyfXnMLCwdNgC ptOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782981927; x=1783586727; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+ynYj3Hv1c2SwjRZ0G2WJklJeAWxlh9A39Rdw7J9Hfc=; b=iXS9yXcmeoaAveR5sOp+jMJwx42kYeYkFZ2+nwvLvNsRGtVQG065t+nbwSDviBNVqK eJhzSh/6rmPqCkIkBc3SVCA9Rxo9KcVD1UNKA0t7ssGBItlBYEObbs4v+76AUVuszgtK 5xSeBxSeDJcf1wLd+E8LR8pvf8bWN/NQbkh1zh5KSOZcjns+sgmzEC+aRQhvdo5nJtnu lfHHV6eNeROV08fHmDxVMoaupt/p1LUc09xa6EmA5g/CMnjBv7NG/M4OgoYYqyW3+Pe2 dukVUSrzthXUzNMp7x/9kq0MShg9xiNfoV5xXbzWvtiP/fQcIwygtFlTxfsS59V4PASS uNVg== X-Forwarded-Encrypted: i=1; AHgh+Rrisu0WYvk/YOXgtdde3zHj2NpqHGGWcGFNlHrxNkQS5Af40Hqwigg1PD8bKilvRXfhjPTTJ8EgnETX9sc=@vger.kernel.org X-Gm-Message-State: AOJu0YyGyfqsOyc5PyPfHdqWDocrKeglIsZk3Gdzl4tYmUp+G7qzefMH riFWnlwefIKc/PVT4pnjs3KyutZSw4TnRNfL3LZfRyCu7rSXjNeF3muX X-Gm-Gg: AfdE7clWYhQNuxomWWN9DcmenmAH4wBuF/HgobqilNTuoDBSvJbGJ7sNDZR0zrJ7Cpf z/TYHc6rIlNIYobQbpUmLlB52RcYPREzU1eLpVltxfSZ5deDsytr2PMj+yENVqba9kULxV1xtnv KIoPG9cttxk9xbBPSYltbm8t4DWj5gyU16PjIwwWrZ30bsaP1/rrxO8dJDsY7uCR8JDaMmpSDIJ KsY7pA5HBZBwIKm5QsluR5W5F4gY3tI6Ir4xgOgHbxDd3ssxQoLiW5RO4BuT3marRPCS1jffOWg UzZxeOLXHAuPg4gEbuOhwPZu1oMmrYz9XnJBbTSyKSdkYgkQ6k0liuK2X7bc5i957pRYIOZuGAr uLeFnGze2d4tQI9tLtF1MN6lVypKnYBGBDsZuKrwWFb029qMvRVGqQHVtXJu+ntdAdnQSCJDG2w rbTnNbTnhdKlcG3/dsODrXzUw+Y4VsRbfPkwMOrcxlNcK9oKs= X-Received: by 2002:a17:90b:5150:b0:380:8b14:d8e6 with SMTP id 98e67ed59e1d1-380aa1c98afmr5379021a91.17.1782981927247; Thu, 02 Jul 2026 01:45:27 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-380e18fbdb4sm693955a91.17.2026.07.02.01.45.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 01:45:27 -0700 (PDT) From: phucduc.bui@gmail.com To: Jaroslav Kysela , Takashi Iwai Cc: cassiogabrielcontato@gmail.com, Cezary Rojewski , Kees Cook , Ziqing Chen , HariKrishna Sagala , Dan Carpenter , Cen Zhang , Len Bao , HanQuan , Kyle Zeng , Dewei Meng , Maoyi Xie , Mehul Rao , Sebastian Andrzej Siewior , Nathan Chancellor , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 3/7] ALSA: pcm: oss: Drop redundant nonseekable_open() return check Date: Thu, 2 Jul 2026 15:44:40 +0700 Message-ID: <20260702084445.519669-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260702084445.519669-1-phucduc.bui@gmail.com> References: <20260702084445.519669-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc nonseekable_open() always returns 0, so the error check is unnecessary. Remove the dead error handling path. Signed-off-by: bui duc phuc --- sound/core/oss/pcm_oss.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c index 9826d9a0be6d..0d7818eb3e14 100644 --- a/sound/core/oss/pcm_oss.c +++ b/sound/core/oss/pcm_oss.c @@ -2495,9 +2495,7 @@ static int snd_pcm_oss_open(struct inode *inode, struct file *file) int nonblock; wait_queue_entry_t wait; - err = nonseekable_open(inode, file); - if (err < 0) - return err; + nonseekable_open(inode, file); pcm = snd_lookup_oss_minor_data(iminor(inode), SNDRV_OSS_DEVICE_TYPE_PCM); -- 2.43.0