From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB4A2449EB0 for ; Thu, 2 Jul 2026 08:45:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782981935; cv=none; b=GP18IRwMPhEFU2WisDW858yFYjwALCEJZG0aQRaAP17EX5bHw1oTLHnJbUsC3fcIjsxRb6UtRHxLkzuWPV8bPW9+69A+HzhwXqzjzLyAjXIJtZUP0fHRQYhngp+M+0fXJdagstzN45zXIe3Lf/4/TTH8rU9XDk1XdKD+aqlv+sE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782981935; c=relaxed/simple; bh=Yg2Tdgg2rvnH60uIpl0zMSHAOpQkuajO2/9N2N1OIE4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K80LNWAhK7Q83lBCfWECkl9uvFzNtbpPnTTxh51ZNSOBYSYKva3RXU4kpEmCOmTxEnKCeH9psZ6e09bA6/Fs11SIN38XRFFA0pZPBHYuyh2mnkJR3vAKZHQ2uQIE4vbZTbqDapkCgGuOj6izdheRloSMdUslttHv50y4OENeuxo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ryO573so; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ryO573so" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-37dedd62b90so374905a91.1 for ; Thu, 02 Jul 2026 01:45:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782981933; x=1783586733; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nO5l0BZEJYRhzDOBjBYV6JTUzttiDF+S0SFOMJl3wEM=; b=ryO573sopNa8Y1DGm7BwwT3pL3lsClIqEtGzxQZ5jdLYJWdCEfI9f5fH832jAjQ9v2 AXbhvsD7aWNyaYkfBDT4qP40cm66IEtWn8WXeqtvaPb+rWUqENXuVhyTxIwSBRe0M3Aj fVNrZUd45/nkjnWcnPJAmkI703T0rvJSS2pUOQkEIHIQututhVQVFsb31SZrefMqvx2q 3CFZZ3wGRxE3xop3C/xkZO8TGBBWLU7MoWfu3DJCxgQqBaaPz++P5prGiAHJbZS7qRiN lUGl+KVGgHnwh0RXBFa+dQ5A2oTvW+bjj6QO0QGtedx2HLkm3dujtRMtQRsWzKShrV8K Rbvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782981933; x=1783586733; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nO5l0BZEJYRhzDOBjBYV6JTUzttiDF+S0SFOMJl3wEM=; b=gaMqCNKt0s7CAFiwm5CCI50lvk1DPbxLuzKNDyWoM7ETweZy9dM4lw2pC7ze91rprG XPRsZmYmOV67J+0dYKvmK1xvRR+o3rYmBFtctit471ha5VzkKXMvQXI0guyw1s9UDhh4 QcnDnyca303qc2jCvBD5k4Nm0n3UBPvjcIX82vg8rdj9+58sBrdA/7dIKHleaTXbeAy/ 86iJm1fFCdXyk6QDCbkslZcfguB//0kLkCcx9qKlHy3NM3LdGlhPPDjPL30xqPspF+FW skRyeDwqUQuFsXgk/fZt9Dtwunte0EwhYcMRp7NYwmcgqWvsjt7RvUH+v264vrc0wWSB Jf1g== X-Forwarded-Encrypted: i=1; AHgh+RqcuGoMYKeNDE2BAa6MVdnKR+nPXqyW3+NPkwDnIKca9zUQL8519o+Vx39yWghQhzoFo38pYOL0/spghxg=@vger.kernel.org X-Gm-Message-State: AOJu0YxKPn01mZsROEqqeHSmMWWFJWUD4QpNN0FpyUm6WXhHDDKV8Dl4 vx0FG04sPSMFqZvsXEjV8KNEMdmndAukjyHh3sjK6lHRadvxkgUWn78Q X-Gm-Gg: AfdE7clSNE7wTt6u/h1d9UgQLoI1idfw8f1rBEpkpEM4biDQ8l1XI/ef3uAAHKkos+c 3/WXNKJBdHKRtfO8h3/iW1kF47Cp9Ws8l9WGQPf6myl5K43R7bXGKVtd4/FnRj3us46xZyzunAc hExBqUDXxEgF/thYB7HwhiV4NemjNPWbyzOD6CwNp330RQ63XwgUxofAGi7Rx/kSqACp7n6WGIw uE5xfiLzsB+P+ZMRvoAZjbux47Bw3shEPHRN4rCMWX+/KujuQmez72RS8lMR37qEd4q/2oTZABD MRyygEw6gTt7pe3ujmEaKySni7+CGMOjda4Ll2j6MLhtQLIrN05Pys85/6ugoDg4DWLM/BbqnPu NUy78WwUJBH/dmgeJgJ0/qKCuE64Sw/R+1Mu4WMe/cXxzoDJ05z8XHEzy1zbvUjA9TOaIisTtsS 1Slb+PDU0NMX+B2I8t83Mxdxk6UnvViqvP7PJt+Ob0DcMEZ14= X-Received: by 2002:a17:90b:4b87:b0:37c:8df2:9f58 with SMTP id 98e67ed59e1d1-3806754f735mr9236343a91.7.1782981933060; Thu, 02 Jul 2026 01:45:33 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-380e18fbdb4sm693955a91.17.2026.07.02.01.45.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 01:45:32 -0700 (PDT) From: phucduc.bui@gmail.com To: Jaroslav Kysela , Takashi Iwai Cc: cassiogabrielcontato@gmail.com, Cezary Rojewski , Kees Cook , Ziqing Chen , HariKrishna Sagala , Dan Carpenter , Cen Zhang , Len Bao , HanQuan , Kyle Zeng , Dewei Meng , Maoyi Xie , Mehul Rao , Sebastian Andrzej Siewior , Nathan Chancellor , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 4/7] ALSA: pcm: Drop redundant nonseekable_open() return check Date: Thu, 2 Jul 2026 15:44:41 +0700 Message-ID: <20260702084445.519669-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260702084445.519669-1-phucduc.bui@gmail.com> References: <20260702084445.519669-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc nonseekable_open() always returns 0, so the error check is unnecessary. Remove the dead error handling path. Signed-off-by: bui duc phuc --- sound/core/pcm_native.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index 7dc0060617f1..7032f329e827 100644 --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c @@ -2873,9 +2873,10 @@ static int snd_pcm_open_file(struct file *file, static int snd_pcm_playback_open(struct inode *inode, struct file *file) { struct snd_pcm *pcm; - int err = nonseekable_open(inode, file); - if (err < 0) - return err; + int err; + + nonseekable_open(inode, file); + pcm = snd_lookup_minor_data(iminor(inode), SNDRV_DEVICE_TYPE_PCM_PLAYBACK); err = snd_pcm_open(file, pcm, SNDRV_PCM_STREAM_PLAYBACK); @@ -2887,9 +2888,10 @@ static int snd_pcm_playback_open(struct inode *inode, struct file *file) static int snd_pcm_capture_open(struct inode *inode, struct file *file) { struct snd_pcm *pcm; - int err = nonseekable_open(inode, file); - if (err < 0) - return err; + int err; + + nonseekable_open(inode, file); + pcm = snd_lookup_minor_data(iminor(inode), SNDRV_DEVICE_TYPE_PCM_CAPTURE); err = snd_pcm_open(file, pcm, SNDRV_PCM_STREAM_CAPTURE); -- 2.43.0