From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F299D35B650 for ; Thu, 2 Jul 2026 08:45:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782981941; cv=none; b=tWPqe6eELfXtTQvs4ZSTp4CO2Z6Cy0HkzT4Gsgsvrk3XOQKBMnBbTBAsthn5Hi2V2fX67wBrGpPoAwD0g7HZLyNIWDBuZsO0zx0TTv0BqyMNxU7osBtAOqWlAZ2qBtzWzKxEWRsskxJfkyJXzzblF7P32RZWrfxa5LOp/kkgqh8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782981941; c=relaxed/simple; bh=pQdclITCrFKrWuBhPVXavBjH7L6W21nfFdNXAS7DhUs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NRLU1teDVd07FPxXgSObQ6ydtItjf+1xtdjE8skbD1YAi7YSGddDDiBDpTvctFydlejEeI6OU1GXxyZJakURUYpfI+ypt0FTfzvP2XhHY9DBjXfc2rCPxKz9f4klzD/jsvZty+GJIQxvren3jNODQMBlfcYHVP3Gy4Fi0+jceOY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SC3WIvBn; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SC3WIvBn" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-37fb17e1435so1017516a91.1 for ; Thu, 02 Jul 2026 01:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782981939; x=1783586739; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vk2/IDVF4TVSmwCeh17TD0ZGHM6fkDDuMvEwZIMryaQ=; b=SC3WIvBnZhgNLkQSY86+Wed4VXvkcXRBkkLm3iJQhmZ10dQiUfR8td9pguH2sSFOyd KRTTmJjSYZM4owGiNF2EzIwHRDBeqYyGuatTicHeAlMmDuXChRe/a1AwfKCdmgufjRg7 ZSEPPVSR7P5+2xVW8Lomqmlu4V+hgO/vqblmwa9P8A0RGbB+v/VtjGmrztO30lqCaQZt KZmbS0VKR116qbavjKf//NYLD0qU9CkWSh82d9woGTKIDA6EU0D7EhrB1byfrBokXzMo tLGE1N8EJZvaeAKvCdX7CR/8x3uQa2Q+eVKtYcO9L60t+KQYgK38rPbHWd7YOLll/heN KU1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782981939; x=1783586739; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vk2/IDVF4TVSmwCeh17TD0ZGHM6fkDDuMvEwZIMryaQ=; b=NmkqZju1kF7vb8HlJFSLwivapHeSGM8+h5VCVrXR9bQPk1TF0IfmiWFsOcME4p31Nh sqg8DKY+2BIX/9d1mOAz4fPMA5Gn3FQUF/1Fq2sdxtTh4odu20HG+pI0eFhAqNnIG8xv bOwNEO0eViBrLRkz77o28JeNFRthmBONYwKWC1A5EVPlVlAYRpPMMq4SB+4VzsJxBoub f1vx3o/gt1a+W+fgvEbjCqWtKZpKpUikQuPs3fBRmrbs4F8WklIAT6Mjk9jpELXLI7nN nrFKenOvCDOKDUx+8UAP5wjC9jWIWfs2La8O9sVNRPbuxNTQ8oJV0Hsas7KMrpYvyyqP OAVA== X-Forwarded-Encrypted: i=1; AHgh+RqRVZs+NO9vhSLIclHLvit9UvIzbCanTnD5yB2ycXRTMMv14Qp4t/CDxhoNfgC7A244zDNUfIMRJYiwFFk=@vger.kernel.org X-Gm-Message-State: AOJu0YwZZFbgbZzhFnbPRyRJovPT3fqDVw0UWT+Uc3zMJHhORt8XfVDx mRt/eJwQSBR7uuxQyft9bv9G7M0hvSdMAsvU30YvK3PwN9rn0cuXTvSK X-Gm-Gg: AfdE7cnmSLMgciLv6d3k6xpBJQG3f/cj6n62dejBYvG3yd12lRbzdHvDAgsyK5mjWpi CgdRIxDeKGRBHCdK1Xi4qLJTo4KilBsbI6gRvg614idJ3rAas/P3W8vdybYtH5C04tZgntnILR7 eL7YrXZZ7J7GA2Lh5jzDwjPYlEsdHjC/Gc1lYZ7+Rd5n0gT46+BD9ZwB9Qc/P12TPCfPYdSj27w YQf2UF25VAgrSJUEhpTXSDBYC70prCFDaBFPxfbGfABu5XpsN6g3ONp7wDFsW3V0vmvNBRsAa4b klm+tgSJJbJ7c5jTTxOIu+voAhHmT+6SiAELHHxGfFbbGN7c2bGcg6oMh1XwyYC9Dh5YVQiXcWk xJFQHCm56qG2NuURpFQ2R/sF6mLeo1spkxpjdJnrzIutQv11HgyjbEvuCekZSNqwe7sjVrCfQ3m NI1JnyTB+OBVbjxRWCrPYz0jg4fMj3BbSzdG5u83wR4MrEA/E= X-Received: by 2002:a17:90b:388e:b0:37f:9ce0:af34 with SMTP id 98e67ed59e1d1-380aa222e0amr4901508a91.31.1782981939066; Thu, 02 Jul 2026 01:45:39 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-380e18fbdb4sm693955a91.17.2026.07.02.01.45.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 01:45:38 -0700 (PDT) From: phucduc.bui@gmail.com To: Jaroslav Kysela , Takashi Iwai Cc: cassiogabrielcontato@gmail.com, Cezary Rojewski , Kees Cook , Ziqing Chen , HariKrishna Sagala , Dan Carpenter , Cen Zhang , Len Bao , HanQuan , Kyle Zeng , Dewei Meng , Maoyi Xie , Mehul Rao , Sebastian Andrzej Siewior , Nathan Chancellor , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 5/7] ALSA: rawmidi: Drop redundant stream_open() return check Date: Thu, 2 Jul 2026 15:44:42 +0700 Message-ID: <20260702084445.519669-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260702084445.519669-1-phucduc.bui@gmail.com> References: <20260702084445.519669-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc The previous conversion from nonseekable_open() to stream_open() retained the existing error check. Since stream_open() always returns 0, remove the dead error handling path. Signed-off-by: bui duc phuc --- sound/core/rawmidi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/core/rawmidi.c b/sound/core/rawmidi.c index 4dfd9d53e6d3..789254a88e53 100644 --- a/sound/core/rawmidi.c +++ b/sound/core/rawmidi.c @@ -441,9 +441,7 @@ static int snd_rawmidi_open(struct inode *inode, struct file *file) if ((file->f_flags & O_APPEND) && !(file->f_flags & O_NONBLOCK)) return -EINVAL; /* invalid combination */ - err = stream_open(inode, file); - if (err < 0) - return err; + stream_open(inode, file); if (maj == snd_major) { rmidi = snd_lookup_minor_data(iminor(inode), -- 2.43.0