The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: mingo@redhat.com, juri.lelli@redhat.com,
	dietmar.eggemann@arm.com, rostedt@goodmis.org,
	bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
	kprateek.nayak@amd.com, linux-kernel@vger.kernel.org,
	qyousef@layalina.io
Subject: Re: [PATCH] sched/eevdf: Delayed dequeue task can't preempt
Date: Thu, 2 Jul 2026 11:01:36 +0200	[thread overview]
Message-ID: <20260702090136.GE49951@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CAKfTPtB4pHi0oQMhLqrFzauoSEZN9ETVmv5DAzk2TAY5qzNr0w@mail.gmail.com>

On Thu, Jul 02, 2026 at 09:53:13AM +0200, Vincent Guittot wrote:
> On Thu, 2 Jul 2026 at 09:43, Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > On Wed, Jul 01, 2026 at 06:49:20PM +0200, Vincent Guittot wrote:
> > > Load balancing can migrate delayed dequeue tasks to even the load between
> > > CPUs.
> > >
> > > sched_balance_rq()
> > >   -> detach_task()
> > >     -> deactivate_task(DEQUEUE_NOCLOCK)
> > >     -> set_task_cpu(dst_cpu)
> > >
> > >   -> attach_task()
> > >     -> activate_task(ENQUEUE_NOCLOCK)
> > >     -> wakeup_preempt()
> > >
> > > A delayed task with shorter slice can be dequeued during pick_next_entity()
> > > but then jump to preempt because eligible.
> >
> > Cute.
> >
> > Perhaps we can look at enqueue()'s place entity and determine
> > eligibility there and complete the delayed dequeue there. But that's
> > definitely something for after the holidays I suppose.
> >
> > I'll go stick it in tip/sched/core.
> 
> Maybe better in tip/sched/urgent because of the warn triggered in set_next_buddy

Hmm, but the Fixes tag you gave it reference a patch in sched/core; is
that tag wrong? Or do I just need to imbibe more wakeup juice?

  reply	other threads:[~2026-07-02  9:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01 16:49 [PATCH] sched/eevdf: Delayed dequeue task can't preempt Vincent Guittot
2026-07-02  4:56 ` K Prateek Nayak
2026-07-02  7:51   ` Vincent Guittot
2026-07-02  7:43 ` Peter Zijlstra
2026-07-02  7:53   ` Vincent Guittot
2026-07-02  9:01     ` Peter Zijlstra [this message]
2026-07-02  9:07       ` Vincent Guittot
2026-07-02  7:47 ` [tip: sched/core] " tip-bot2 for Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260702090136.GE49951@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=qyousef@layalina.io \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox