From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 710F747A0D0 for ; Thu, 2 Jul 2026 11:47:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782992830; cv=none; b=S6YfYjSug0udUkwvDQjCTMFBR7gXAe8XrErLHu3p+4xEqCT/4fOMWAdPe9/WHzYxLJNQ/Vw+XFpkxmAgvW9H0UxrboLAyPVRUIeckZdc0dQ5kEQs8x3E9b7HVtlnpzOKCya6zcbUWQ4UvxrJYbeW5LNg1ohrYu+qd5sXbgyeRKY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782992830; c=relaxed/simple; bh=6KwVdXym8m9VmBu/yZDbGr4sR4go0nT/ImlSsY/m7K0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=F/C+YGuCKbE20W4kPxCGQixUMKQ5VL/SlICT5z3PqP266XB84cBeCC7HnsXm0ouRN0OwhzURSOwdKPwd0iqEoITnvhPFZD8olt/jCZS5HYCxTsAPnmk482iomIAWTW4yiW5rRp5K0mvRCkpykoAtnO2u+uzdM5Zp3OrsZ3fOvjc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZVDToIpu; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZVDToIpu" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-37fc01881f2so1833618a91.1 for ; Thu, 02 Jul 2026 04:47:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782992829; x=1783597629; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EJM+v6mJ9RBfgqnA3JaL3CQXECHO5LJ7tpDsIB136Js=; b=ZVDToIpuLzePiJ5Nn9uNMlxzpz5fuAw/gYVBtHOrwx+0JtFYeugV78F3hc4t+nPm5c zOoUvuRhEKDwwRZpg6AxeiSzEvcSjhzPGbqUjgT+q2i1oaf7FZQ1ZG9GZWZylIvLPfjU mCTOBjckXeBgbVSqPoI6kXXlI7uDUVAnK8owzfum37YjcnjZamKkv407vs4L/QIMYXXS bQLMrYKrRziNmud1tglSQKTw9RdEra5ykum01Zc1zBlbUErFFEMnSetPjtF8c396nAJU 6WzRt/wnh70S0YYJIRDrsCoymkjiA5tcxPVrL+c/wHS13/f8wYnx/Xf67F7niy11ZsXu oMWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782992829; x=1783597629; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EJM+v6mJ9RBfgqnA3JaL3CQXECHO5LJ7tpDsIB136Js=; b=cDnSL6TVLgj9ceNis+arjsu2q80qEBDgV0lsSxHcPjlEwAULCpmYlFtAiucsw8yUlF e/DVdEN2TuAXhRtToGeAw4GK6J9khKek3EKg73G44x2NX1Jjzc81F196BdYvmX06Ygjo 4Ov5DqTCZrfk7Q8r7mkDORGWUVxfnho/M5C0z4aoSG9i1RgSLYqPrUOH9thdTXgOoSrl 3YtAkUTF//L3kIKrPcQ7Izb6If1umDQwCijyI8twbaDr4PM5SC6bHKsVLZFBTptRhz5N pNvmxCLKbo1ttAXIwYrG7hJ2WY/mMu2Qc/2XSUrFcpOQDs5QTFNlsrPFQktY+juvHnPj eGBQ== X-Forwarded-Encrypted: i=1; AHgh+RrxufuFX6MVta80VQ0KSIAh6yuQ/o7FflHKPs4StOSQDvuYGh0ZvdSnN0oZmm057zxNP833idifGrveDi4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8t0rNwbrDbbw9dHYnxF83Lb9RUMRrNNqyqcF77520zPBDYF/Q k7ibhkxdAKp8hn6I99Y81L9X5cPzzmrB1y3M7xo/z1V2uJr3VVQSC97B X-Gm-Gg: AfdE7cljApHAsiIOfiXDaOk/FF24//uD4/tWC3tXb2NuSCWI+TvPUfyE1WMeLUZE7ia 2fUUlFCTE2FpFx3GTs5ClYXAvFPyIjFxGmgkW/pOiKQGsr2c5ilWgrttJD4JRO+S+Fj1viqk/Zh ICLW3RB1RAphwTmP1e9qGZzshyfdXHE8ZWm7eyatBbETUVZiBVcslmcF4uz8gi8eTEJL8X5u0X7 LPGtioJMEwEZTWjPBiUEFCamQ071Id2cF0Av0SEcnaBaQjn8CYjrhWL5KUX8b1PTZ13VLk3iZCt 4c4XAJt0jiX3C1n2/VXv49mFmFY1PY4c8EtyD1HybsGBYMdbCKyeQlt3fx8Dl7ktlluMHvDbBQ9 boBbrTVF7/EpG/23hVlqAy+QRJAkSKMJkoOj0swzLKAS5FkdQwfau+hFTpnjSi594JNoS8GMBiU EcvWiuRawv//2+SZbr6zgMMF+Qd7fxppCV+nZDvoLnVnNM7H9Kk0fkvptC97FmAuZ+3+m2 X-Received: by 2002:a17:90b:4d05:b0:37f:c2a8:ce45 with SMTP id 98e67ed59e1d1-380ba84ba5bmr4978091a91.4.1782992828439; Thu, 02 Jul 2026 04:47:08 -0700 (PDT) Received: from moksh-Nitro-ANV15-51.. ([2401:4900:c12e:fec4:e7a1:6f69:20dc:cd96]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0bb84405sm12313834eec.17.2026.07.02.04.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 04:47:07 -0700 (PDT) From: Moksh Panicker To: jic23@kernel.org Cc: nuno.sa@analog.com, Michael.Hennerich@analog.com, dlechner@baylibre.com, joshua.crofts1@gmail.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, Moksh Panicker Subject: [PATCH v3 2/2] iio: adc: ad7779: Remove redundant dev_err_probe() after devm_request_irq() Date: Thu, 2 Jul 2026 11:46:49 +0000 Message-Id: <20260702114649.9758-3-mokshpanicker.7@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260702114649.9758-1-mokshpanicker.7@gmail.com> References: <20260702114649.9758-1-mokshpanicker.7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit devm_request_irq() already prints an error message on failure via the IRQ core, so wrapping its return value in dev_err_probe() results in a duplicate error message. Return the error directly instead. Suggested-by: Joshua Crofts Signed-off-by: Moksh Panicker --- drivers/iio/adc/ad7779.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad7779.c b/drivers/iio/adc/ad7779.c index c1a99b4c1256..a5b8bfa99a74 100644 --- a/drivers/iio/adc/ad7779.c +++ b/drivers/iio/adc/ad7779.c @@ -842,8 +842,7 @@ static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev IRQF_NO_THREAD | IRQF_NO_AUTOEN, indio_dev->name, st->trig); if (ret) - return dev_err_probe(dev, ret, "request IRQ %d failed\n", - st->spi->irq); + return ret; ret = devm_iio_trigger_register(dev, st->trig); if (ret) -- 2.34.1