From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5719381EB0 for ; Thu, 2 Jul 2026 14:49:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783003778; cv=none; b=R5y7nxnql+ikzi7AuT1sHbaLDDcZbfNg6Ao5wjN6keEoVbRXlZBc35LcwepPPLwOTRqIy7vxBmfRfpluVIhqb4YFo0tMS+2Nt1uci+LvYV5gKhGTH49EQbmZMQ7MK1uyEEOlSvh22CcJ1bNypLWPx+x8yMPq2N7nLlfa85boZug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783003778; c=relaxed/simple; bh=E1DKv1zWMYA4DFk3hmqLlCOGhxl4FdyLa/Rx8tHLo+c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YEzvfci1QgUq9eSQSfx0xhPTbePDMqgSb5LV3/zXeVTOzI6bo2EJAVijXMLa4Arg2srtdT6FRZD4Lr8tUTvrHaY1BFR6hA9NKnYfgKuiCA+vhwKBDx58Zuo5rsmEllldDHiP1bgq7WFEK+z9GxGxZS7uoQ5rNUiStSzktB2hAo4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CO+wOzfl; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CO+wOzfl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783003776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NahzdypL9w7RySKlcv+DTp0PkyrUPrVJ3XH0FwVcdO8=; b=CO+wOzfl1QAw2T9z2w/q2cPFIWmC6W/vTLQ+KRfbB0tEiDeEMg7eD27+iWtIfpNaoq0SBM loGfzvTtf5QlKPRaiPFDNkYb5iOdwedu/k4yQ+bs74Hl2XxEK15gAHa3cvsjqq7+PV1SML qLaLhg8dIlqSQULga8TQhmOzeBhUxxM= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-82-AodXvi4NOXmwn1iJ3A2IRA-1; Thu, 02 Jul 2026 10:49:33 -0400 X-MC-Unique: AodXvi4NOXmwn1iJ3A2IRA-1 X-Mimecast-MFC-AGG-ID: AodXvi4NOXmwn1iJ3A2IRA_1783003772 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 70C47186BF35; Thu, 2 Jul 2026 14:49:31 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.44.33.159]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CDBCC3002D2B; Thu, 2 Jul 2026 14:49:27 +0000 (UTC) From: David Howells To: netdev@vger.kernel.org Cc: David Howells , Marc Dionne , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, Jeffrey Altman , stable@kernel.org Subject: [PATCH net 1/4] afs: Fix NULL deref in afs_deliver_cb_init_call_back_state3() Date: Thu, 2 Jul 2026 15:49:15 +0100 Message-ID: <20260702144919.172295-2-dhowells@redhat.com> In-Reply-To: <20260702144919.172295-1-dhowells@redhat.com> References: <20260702144919.172295-1-dhowells@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Fix afs_deliver_cb_init_call_back_state3() to avoid a potential NULL deref should call->server be NULL (ie. afs_rx_new_call() failed to find a matching server record) when it checks the server's UUID. Fixes: 40e8b52fe8c8 ("afs: Use the per-peer app data provided by rxrpc") Link: https://sashiko.dev/#/patchset/20260624163819.3017002-1-dhowells%40redhat.com Signed-off-by: David Howells cc: Marc Dionne cc: Jeffrey Altman cc: Eric Dumazet cc: "David S. Miller" cc: Jakub Kicinski cc: Paolo Abeni cc: Simon Horman cc: linux-afs@lists.infradead.org cc: stable@kernel.org --- fs/afs/cmservice.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/afs/cmservice.c b/fs/afs/cmservice.c index 5540ae1cad59..d579a665e3da 100644 --- a/fs/afs/cmservice.c +++ b/fs/afs/cmservice.c @@ -364,7 +364,8 @@ static int afs_deliver_cb_init_call_back_state3(struct afs_call *call) if (!afs_check_call_state(call, AFS_CALL_SV_REPLYING)) return afs_io_error(call, afs_io_error_cm_reply); - if (memcmp(call->request, &call->server->_uuid, sizeof(call->server->_uuid)) != 0) { + if (call->server && + memcmp(call->request, &call->server->_uuid, sizeof(call->server->_uuid)) != 0) { pr_notice("Callback UUID does not match fileserver UUID\n"); trace_afs_cm_no_server_u(call, call->request); return 0;