From: Jason Gunthorpe <jgg@ziepe.ca>
To: Edward Srouji <edwards@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Gal Pressman <galpress@amazon.com>,
Steve Wise <larrystevenwise@gmail.com>,
Mark Bloch <markb@mellanox.com>,
Neta Ostrovsky <netao@nvidia.com>,
Mark Zhang <markzhang@nvidia.com>,
Mark Zhang <markz@mellanox.com>, Majd Dibbiny <majd@mellanox.com>,
Yishai Hadas <yishaih@nvidia.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Patrisious Haddad <phaddad@nvidia.com>,
Michael Guralnik <michaelgur@nvidia.com>
Subject: Re: [PATCH rdma-next 1/8] RDMA/core: Add rdma_restrack_begin/abort/commit_del() operations
Date: Thu, 2 Jul 2026 14:46:51 -0300 [thread overview]
Message-ID: <20260702174651.GT7525@ziepe.ca> (raw)
In-Reply-To: <20260701-restrack-uaf-fix-resub-v1-1-c660cda4df2a@nvidia.com>
On Wed, Jul 01, 2026 at 03:28:15PM +0300, Edward Srouji wrote:
> +static void restrack_drain_res(struct rdma_restrack_root *rt,
> + struct rdma_restrack_entry *res)
> +{
> + struct rdma_restrack_entry *old;
> +
> + old = xa_cmpxchg(&rt->xa, res->id, res, XA_ZERO_ENTRY, GFP_KERNEL);
> + WARN_ON(old != res);
> +
> + rdma_restrack_put(res);
> + wait_for_completion(&res->comp);
> +}
> + */
> +void rdma_restrack_begin_del(struct rdma_restrack_entry *res)
> +{
> + struct rdma_restrack_root *rt;
> +
> + if (!res->valid)
> + return;
> +
> + if (res->no_track) {
> + rdma_restrack_put(res);
> + wait_for_completion(&res->comp);
> + return;
> + }
> +
> + rt = res_to_rt(res);
> + if (!rt)
> + return;
> +
> + restrack_drain_res(rt, res);
Why the duplicatin of the put and wait? Maybe
restrack_drain_res(NULL, res)
should just skip the xa part? Same for the other functions.
Jason
next prev parent reply other threads:[~2026-07-02 17:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 12:28 [PATCH rdma-next 0/8] RDMA/core: Fix restrack UAF in destroy flows Edward Srouji
2026-07-01 12:28 ` [PATCH rdma-next 1/8] RDMA/core: Add rdma_restrack_begin/abort/commit_del() operations Edward Srouji
2026-07-02 17:46 ` Jason Gunthorpe [this message]
2026-07-01 12:28 ` [PATCH rdma-next 2/8] RDMA/core: Fix use after free in ib_query_qp() Edward Srouji
2026-07-01 12:28 ` [PATCH rdma-next 3/8] RDMA/core: Fix potential use after free in ib_destroy_cq_user() Edward Srouji
2026-07-01 12:28 ` [PATCH rdma-next 4/8] RDMA/core: Fix potential use after free in ib_destroy_srq_user() Edward Srouji
2026-07-01 12:28 ` [PATCH rdma-next 5/8] RDMA/core: Fix potential use after free in counter_release() Edward Srouji
2026-07-01 12:28 ` [PATCH rdma-next 6/8] RDMA/core: Fix potential use after free in ib_free_cq() Edward Srouji
2026-07-01 12:28 ` [PATCH rdma-next 7/8] RDMA/core: Fix potential use after free in uverbs_free_dmah() Edward Srouji
2026-07-01 12:28 ` [PATCH rdma-next 8/8] RDMA/core: Fix potential use after free in ib_dealloc_pd_user() Edward Srouji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702174651.GT7525@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=edwards@nvidia.com \
--cc=galpress@amazon.com \
--cc=larrystevenwise@gmail.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=majd@mellanox.com \
--cc=markb@mellanox.com \
--cc=markz@mellanox.com \
--cc=markzhang@nvidia.com \
--cc=michaelgur@nvidia.com \
--cc=netao@nvidia.com \
--cc=phaddad@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox