From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5AF03A6EF0 for ; Thu, 2 Jul 2026 18:29:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783016955; cv=none; b=GQoT9bM20vCgUzCEDpP/xX0qP1Mo9Tscq49yjJLbCBhhPG3dTijsdDJHVst027yHNKCqX/NcgTmHxbaWGhGQ+jZEj8JI72ud3gpspqMRorTPbSsKbkXPX9ZoWFGkMOlDXuZtQZHp+GrLmENYYHDMeXyH9IewVORWIZvIMN0nqt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783016955; c=relaxed/simple; bh=5e2sEyGr8ZQ8aTHEwreqsM6afows340ubUe6h8rafo4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CxE12ALrSb4SUDhg1mxfVfayb0aWqp6qFKhRHBnFDhNU3JaC2ui4FTIrEIwB+hZdJQxYSCGhkofFkXWEDkrgeqijzypw03NhxzYiAliQiDfwxKGWEfyvnuR/kgarMUNmP3vIIWWvxcy9aimaO08oU05g92ux/yMqhD7atVbSb3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ajhccwe9; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ajhccwe9" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-92e5c9211d2so157611185a.1 for ; Thu, 02 Jul 2026 11:29:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783016953; x=1783621753; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JcsRcsJGmZMOhMWhiuKwk24L9Av5D/xJ8HUZ2uB1lXY=; b=ajhccwe9i+juMJmkMGNJDG1cV1K7bxKt9Xx55qURdvuZLZLQzHnQwNnHToefej8MYM 9RO3PI0kNtQRFKQ1zGD7Ae9CJCqiDqPV8qTQzJvPJevkH6GfpdhzAVkp1YtL0ivC55Z5 NeHXwrgpRDhcgIpE7rm/g/SbXQjNY+bvhpmgvdCiU5veXP5GitXdx1Gpyh/XFF+32Cuv 4roxiQHuDbGFVG2lWyb7LVJxcwBEEXyVD2XlrUCnJmva8OT7RszOi0e6CpL492kx8mLq 9UN/flXYqwraBq6ouV2RbJovqfSEEkryvTkbfvR5OSaqMkRHBF3XmcABS/0myppt585L 3mUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783016953; x=1783621753; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=JcsRcsJGmZMOhMWhiuKwk24L9Av5D/xJ8HUZ2uB1lXY=; b=kHxFYXaxx4QXVp47YAmid5Eem3ujUXGRPix6hpVndlJqgmjT50FrUElGiuA0cjh2wr I69KmAbjWSmRflhxJbtRRcw0N5ZxfUdattvpGkNaUE1rfYvT5ZOOVBTOf8xGMHWPUZJ/ IdpeByFcbbwBwk9R0jU0ebLtTqtNpkV15oYxpQcIey+FVWqHq+D+u2aYaWtLpADI8vnk VwVhmOGbLvinvEl/c/XxgexxgfMi6TAziqonLXZXXIY9abwG1gqCu7axNWhijTndtkK5 9js5YySD1W5PJ1m4H5jKdZ3taHkJ8mZancUy6KSBR09OXhbuOhNTPsMsyH1YpCpX2a7h uAVQ== X-Forwarded-Encrypted: i=1; AFNElJ92urg4fxv44bIeagdAJWrmP52bFigBm6REe9ndzs0SukMgOVmk3ZNW96Dn2EchhGXJL3h+qG0/Vd6z2zA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7gHEsEU/puTv+A1fd6bi/mdBg2DxilNjk8nSgPLOp1Kn3tvFd RU+5StqMTP0VmcD/UJjiEJA+h8dcvklkH5WXZqyrIiqma3ORnBRxVchvI8GDRw== X-Gm-Gg: AfdE7cnKxPHsa97Phn3C9sSkfjZc4SbEdMj3nw2wFRTJAfXXdkqvb+5ZMxz/NPoCrCq OejGpxkVwmpqLGQwCOA9pkHENp4pwn9Ofe3kr56OoYDwv+nrJF7kQFKHkjVzdt8aa/C0Wu7+FuC 48bthB+AsfT+1zQkftKYTxQdBi74qHoMkl5AW44prheIb9DDpQX0t9kAmrnfcsE9qYR8S5jpurN ce1wLVninMvderuVE+GoVfTwnz5lxXg0BdgjGzZeJXmNnQQUkYtaDxgIq7F/PzXhZz6RjCX3nDf sheW91205k7fmzNA6INLvGX+YKqhUuzhh/BMISP95MKii6cr7VRYH8zuEcNSHC9oZRaWq8a4JwB FeFY1hFpRq0oXD63/IKbYw/ecBII7iqbhn7G5iOjAHwxF3XKzBfafqtCV6cWp4TqAopPpubIllg pPJzE03gDr+4BemzqfGaFbwM/dXwieDKFj7wOcB5NO8A== X-Received: by 2002:a05:620a:6888:b0:92e:6122:130c with SMTP id af79cd13be357-92e784cb8d5mr1004367385a.34.1783016952777; Thu, 02 Jul 2026 11:29:12 -0700 (PDT) Received: from i4-l-hqh5357-03.ad.psu.edu ([130.203.139.71]) by smtp.gmail.com with ESMTPSA id af79cd13be357-92e7ffdff5asm293326585a.3.2026.07.02.11.29.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 11:29:12 -0700 (PDT) From: Shuangpeng Bai To: mchehab@kernel.org Cc: kees@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Shuangpeng Bai Subject: [PATCH] media: ttusb-dec: detach frontend on registration failure Date: Thu, 2 Jul 2026 14:29:06 -0400 Message-ID: <20260702182906.2613718-1-shuangpeng.kernel@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ttusb_dec_probe() calls dvb_register_frontend() after attaching the frontend. If dvb_register_frontend() fails after allocating fe->frontend_priv, the DVB frontend core has initialized the frontend refcount and drops only the registration reference before returning. The remaining detach reference must still be released via dvb_frontend_detach(). Calling the frontend driver release callback directly frees the ttusbdecfe state, but bypasses the DVB frontend core cleanup and leaks struct dvb_frontend_private. Use dvb_frontend_detach() on frontend registration failure. Fixes: a574359e2e71 ("media: dvb-core: Fix ignored return value in dvb_register_frontend()") Closes: https://lore.kernel.org/all/D1EE37E7-8CCB-4621-8105-0229FADF5855@gmail.com/ Signed-off-by: Shuangpeng Bai --- drivers/media/usb/ttusb-dec/ttusb_dec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/usb/ttusb-dec/ttusb_dec.c b/drivers/media/usb/ttusb-dec/ttusb_dec.c index 825a3875989d..8566fb074092 100644 --- a/drivers/media/usb/ttusb-dec/ttusb_dec.c +++ b/drivers/media/usb/ttusb-dec/ttusb_dec.c @@ -1694,8 +1694,7 @@ static int ttusb_dec_probe(struct usb_interface *intf, } else { if (dvb_register_frontend(&dec->adapter, dec->fe)) { printk("budget-ci: Frontend registration failed!\n"); - if (dec->fe->ops.release) - dec->fe->ops.release(dec->fe); + dvb_frontend_detach(dec->fe); dec->fe = NULL; } } -- 2.43.0