From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE94E37A845 for ; Thu, 2 Jul 2026 19:14:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783019643; cv=none; b=MiVfqnkpWrnbN6si5UpXnx+SXj1Sa3VIRo3lKxCwbNRLyGX7SV2k4lWx0+F09QlnYVuzjs19Y/T/kS/iHCCmUFDlnQYy7cQJ9KS9hbn217dUN2OHgsyJwIjHnqUxANzpX+FzoeO2E+ptEVCs5PyM4pPfJ/f/SOgOMIL+DQ6RPz4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783019643; c=relaxed/simple; bh=W8ivqy79EFzNA2Ezx20CfLZ6HP4m2lPjNmQN4QglcI0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MH3tCp5YnYmwOrp0+cec4nPPhzPnhppl4ALqGiTjRlx58ARLHVsruz09y5LNzWP/TDP05Zh9HjlJgcmugGx/I3wSshSFJWFSv3dNgGu/3osC9rj3r9PkyuExOON5NWZ9vFkaU/vXdLRx8uVPujOMpaevhi0qke2WonXedJkgL10= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p0kOaBLi; arc=none smtp.client-ip=209.85.219.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p0kOaBLi" Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-8eaa7b5e31eso6511616d6.0 for ; Thu, 02 Jul 2026 12:14:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783019642; x=1783624442; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VgXZ8nPMmK/Y7f5cDka+f0jwbicN2i3iuL4UpZ5H8qM=; b=p0kOaBLi3DhG9nq938bKI89qYaXN4r4FRlRPQHUhvckIxrAxtvKcOWhw+257bweQyD eUzcdcQ/7+xfmzboBl5qZVoZFIBKqOcWmgsr97f/GZt6GMF4OrfOznKXdWUF2+qtrqMS sz+2MVOgtpFAp4rfMu2MJVvG24XckFxpyWC/WNqX8tF6Uok/+xMCZ1rwzF7WRzSo5tw/ 5ih62YDdsXNFvFjsEbC+rHfIAFXbZIy6Q6fSlqcLHoihG9jksDRqUC69kunSd4y1FYw9 5xjEywqY1akcXGOf62zfl4a8wquCd/J0hlk6sIKjwh/BJkFu+YPsi0uItoii8zIC+lNZ rOPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783019642; x=1783624442; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VgXZ8nPMmK/Y7f5cDka+f0jwbicN2i3iuL4UpZ5H8qM=; b=ooUpK3cogXDdLoKs/x+YBkmtZKwCRpGQi5EHMvSuRhpHqQPdPN9UDTKL63QIxmMF5T vZpGXMDWq7Qgegr8CsvqfYWtP+rkr74SE7yDFWv1+rkbWiqN+GIj3/GHN5MxV1YVd2CV kWnq6p8o9y3cy8q70TuCRE39fWJOJzGMbcARjWutCOX0m77alFk+MwUZcMFpsVZedeDJ 5a2pi24blubgLf+25L6qXG3Ni7NofdgZsdtppsrgJ2zolyFl7zaUC2nQRb/0ahLZNRw0 NYgD5v+we4CDwSK0CjMxWTM2Ik+Pg49pOlDJIDXPIq1SwT+5/WE/BL7OzUOqIys2uAQp /5Pw== X-Forwarded-Encrypted: i=1; AHgh+RrdnBzM5yZNiabHMQuZB9JYYyBGWb8IPxxzoBs3G4bVZpLpbmyPR6hDSzJelnXAxZg+hyDnTebKmAtsPMk=@vger.kernel.org X-Gm-Message-State: AOJu0YwkcNbhDsR5+18RtmjT5nbUG29OyqnI1rKe8O/Yu2pxNHkxkbTU EPYtFBb76o8t/CbosEkNwrz04aVM3J5tRHTK8017j/M9dawPiDldmORC X-Gm-Gg: AfdE7cl9Iab8C57eANsJ+xLYm3HsTXmVYpuH9Acxs10gqXhX/DM99AP/6R03+5UdMQz pOJNwP902NLxxRSHBmCBLCGSR3y6+eSD2b8uRAVhPMkrwkQsEd66lNFa5ZYWPtaDnKTvEsenAUR y3qU37ITFMOXo7ZnkAnT/7luZoAbxOzQnjtkMfml7BvpKJJRkcD+diuoDaiZoaCALdaL1Dq10pN mvubCmcwCaDhglXSJKBs5AEfEvnNP9DXpsVYJ89pacjA3gNLh1plXg22GYA3qP9O2e1qDhB2IIM b76SaDavcAqeGh/cIHzeLFkjX+sjalVG95Xk43Tval/CS9VV4gSDVMn0s25MByctY1OpKht5EUT /UXsRZ9fbOfS7AlxDcdwmQvh2Iop4sU2M/jCatEPYIIDDcZJOOPe7S+bl+ea1iXNKTDlbkUiFJd IvqeznkC6NW5//gmiamUVpoY7BiyDOS65JKg/db5afLXwf3svazMpo X-Received: by 2002:a05:6214:300f:b0:8f1:505c:1d2d with SMTP id 6a1803df08f44-8f5bce7c7camr16033426d6.14.1783019641478; Thu, 02 Jul 2026 12:14:01 -0700 (PDT) Received: from i4-l-hqh5357-03.ad.psu.edu ([130.203.139.71]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8f4724bab9esm32580696d6.42.2026.07.02.12.14.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 12:14:01 -0700 (PDT) From: Shuangpeng Bai To: Heikki Krogerus Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Shuangpeng Bai Subject: [PATCH] usb: typec: class: drop PD lookup reference Date: Thu, 2 Jul 2026 15:13:29 -0400 Message-ID: <20260702191329.2648043-1-shuangpeng.kernel@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit usb_power_delivery_find() wraps class_find_device_by_name(). That helper returns a device reference that must be released by the caller. select_usb_power_delivery_store() only needs this reference while calling the pd_set callback. Drop it once the callback returns. Otherwise the sysfs write can pin the selected USB Power Delivery object and prevent it from being released on unregister. Fixes: a7cff92f0635 ("usb: typec: USB Power Delivery helpers for ports and partners") Signed-off-by: Shuangpeng Bai --- drivers/usb/typec/class.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c index 0977581ad1b6..0595e8cb83aa 100644 --- a/drivers/usb/typec/class.c +++ b/drivers/usb/typec/class.c @@ -1619,6 +1619,7 @@ static ssize_t select_usb_power_delivery_store(struct device *dev, return -EINVAL; ret = port->ops->pd_set(port, pd); + put_device(&pd->dev); if (ret) return ret; -- 2.43.0