From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A312833985A for ; Thu, 2 Jul 2026 21:17:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783027033; cv=none; b=ogGdnE/6eURib6C7VIUC79w0SxE5WecdopVqNbq5CA/wP2primAtpLVd7F295fDdGtbr0wKITR1RHHMkGkkuPXBdZ+Xk1BlACCgzD84fJWsofFuqGzdF7xAqWwObssdzXJsvHGL6aZuIiaAzslQolVYHdMWfCDjWxNtRSXXr5tI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783027033; c=relaxed/simple; bh=9Sn25FnbiEMbxkyXXHqkcaiGtgo2gNftmAFG7WgBEzk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u5wxUdt4tUhwEu1DhWS1FWkVa5/iYo2Issu6bckAr8i7KOdOsXMx44AuKNd5O0QiJe18Iz9ZZJ9bYU/XOoNgQkJ5XNEktGa4H0eT3kU6nazpOz/5cw27k4whsper7j/z5CTmAGLGJPDg8RRKkQ7J8I2zlspg4Adn2I4yvqvCokg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Aao4xjaY; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Aao4xjaY" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1783027031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fdbhQEhhgd8YmJtNTQqroJJmTLAfWQpRu6N000lRrlo=; b=Aao4xjaY4Kqa1CusFpOdWSK8uzskctIuZ1JcZfkxdXahh6u85zxWeDo1a8SeSK16gYfHq6 WwI9am568NfC9LLJh4L1G7jEl3ydOcwIPXuEwFH5aCkOLU60w2DIJJ23k6bDNbXzeQfSA5 5+FzeUtXuuj5xCRDaE0P2R3cxDeylq8= From: Thorsten Blum To: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Josh Boyer , Grant Likely , Tony Breeds , Alistair Popple , Benjamin Herrenschmidt Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Thorsten Blum Subject: [PATCH 3/3] powerpc/boot: Fix treeboot-akebono CPU node lookup check Date: Thu, 2 Jul 2026 23:15:57 +0200 Message-ID: <20260702211554.56923-6-thorsten.blum@linux.dev> In-Reply-To: <20260702211554.56923-4-thorsten.blum@linux.dev> References: <20260702211554.56923-4-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=884; i=thorsten.blum@linux.dev; h=from:subject; bh=9Sn25FnbiEMbxkyXXHqkcaiGtgo2gNftmAFG7WgBEzk=; b=owGbwMvMwCUWt7pQ4caZUj3G02pJDFluV7kmenUxuv0t/Cyz6eX520KZkz6kfj5yN41v951k7 pTIpXu9OkpZGMS4GGTFFFkezPoxw7e0pnKTScROmDmsTCBDGLg4BWAiXEWMDHPYv5dfKrzhkLZt gywXz62S7Vy3gl6ecCgQ+XQpIuxqoxXDb9apwdzhJmYb9LQvrr3a0FVom6rip7mxbaLQ7U/J/Rd 2cgMA X-Developer-Key: i=thorsten.blum@linux.dev; a=openpgp; fpr=1D60735E8AEF3BE473B69D84733678FD8DFEEAD4 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT fdt_node_offset_by_prop_value() returns a negative error code on failure - fix the check accordingly. Fixes: 2a2c74b2efcb ("IBM Akebono: Add the Akebono platform") Signed-off-by: Thorsten Blum --- arch/powerpc/boot/treeboot-akebono.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/boot/treeboot-akebono.c b/arch/powerpc/boot/treeboot-akebono.c index e3cc2599869c..1b529037480f 100644 --- a/arch/powerpc/boot/treeboot-akebono.c +++ b/arch/powerpc/boot/treeboot-akebono.c @@ -146,7 +146,7 @@ void platform_init(char *userdata) node = fdt_node_offset_by_prop_value(_dtb_start, -1, "device_type", "cpu", sizeof("cpu")); - if (!node) + if (node < 0) fatal("Cannot find cpu node\n"); timebase = fdt_getprop(_dtb_start, node, "timebase-frequency", &size); if (timebase && (size == 4))