From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 510AD38C2AA for ; Thu, 2 Jul 2026 21:28:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783027730; cv=none; b=HsjLisnQU07YOdFLE8zmjsoxaZ9L18umlJIHtSnTmxA/X6SvhSK2PJXMkrOG4mNvo47wtHwWqegDDIXdJ4QH0r4D/g3trwfhpANf1+cBoKwPDmzH+GldEfSlxtOKKyGk0lFsIVC3SSB5S22WgTVoOr7kwc0zrDmoBQubS8wMllw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783027730; c=relaxed/simple; bh=73RU4BFPZ+ziZEgh3dTbggroeRBnv/kmvyGdxSTxVdw=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Xiee/BlanqH0JLgCMHOievMgYZX2JLErBfyE0GDa4Z6ANgFdd/EuLir3dX6p2bZjscvVxQgiOSFqie8IBiiWKmzQ14PnVmKVVN89ii3Ut+cBaXIhljlmLwxkW2sZ6AWUpgnDyHCePcbDyp1aX++2LQwJFpjyRQt6GZ3thgucVZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=3MqwE6Rv; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=3mepuSfL; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=3MqwE6Rv; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=3mepuSfL; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="3MqwE6Rv"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="3mepuSfL"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="3MqwE6Rv"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="3mepuSfL" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8AF487453A; Thu, 2 Jul 2026 21:28:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1783027727; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l6hqCE48NWr2zSTjKjo0R1SNTOdlH3SWb6MuD6zzlUw=; b=3MqwE6RvQowmAelRUNGsiUiipuqv08BD6rFZwkL/BxP64bWgXp/VigdtdpUo3K5g35nBke ygDzdZBLBuu2TOSqPOsswX/E8SOqtoaIrzoV2JQUyHr7WdlREX8Ivz558dWe/WDm/xnIkc HSL2ab2kId6l+SOKr8KyBIsl4PZH/u0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1783027727; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l6hqCE48NWr2zSTjKjo0R1SNTOdlH3SWb6MuD6zzlUw=; b=3mepuSfLeh39i1bDKwLC2uIDQOsjKun26ypLqy6Ro9OQzl+XB1LEgnQ0w2momXgFamXXmu diTCBoEVSfeFX6Bw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1783027727; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l6hqCE48NWr2zSTjKjo0R1SNTOdlH3SWb6MuD6zzlUw=; b=3MqwE6RvQowmAelRUNGsiUiipuqv08BD6rFZwkL/BxP64bWgXp/VigdtdpUo3K5g35nBke ygDzdZBLBuu2TOSqPOsswX/E8SOqtoaIrzoV2JQUyHr7WdlREX8Ivz558dWe/WDm/xnIkc HSL2ab2kId6l+SOKr8KyBIsl4PZH/u0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1783027727; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l6hqCE48NWr2zSTjKjo0R1SNTOdlH3SWb6MuD6zzlUw=; b=3mepuSfLeh39i1bDKwLC2uIDQOsjKun26ypLqy6Ro9OQzl+XB1LEgnQ0w2momXgFamXXmu diTCBoEVSfeFX6Bw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8562F779AA; Thu, 2 Jul 2026 21:28:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id mtCTFw7YRmphTAAAD6G6ig (envelope-from ); Thu, 02 Jul 2026 21:28:46 +0000 Date: Thu, 2 Jul 2026 23:28:35 +0200 From: Petr Vorel To: linux-kernel@vger.kernel.org, Joe Perches , Simon Glass , Dwaipayan Ray , Lukas Bulwahn , Andy Whitcroft Subject: Re: [PATCH 1/1] checkpatch: Skip CamelCase cache for --no-tree without root Message-ID: <20260702212835.GA359084@pevik> Reply-To: Petr Vorel References: <20260519161436.79801-1-pvorel@suse.cz> <20260528130952.GA261301@pevik> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260528130952.GA261301@pevik> X-Spam-Flag: NO X-Spam-Score: -2.00 X-Spamd-Result: default: False [-2.00 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; TAGGED_RCPT(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_TO(0.00)[vger.kernel.org,perches.com,chromium.org,gmail.com,canonical.com]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCPT_COUNT_FIVE(0.00)[6]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo]; RCVD_COUNT_TWO(0.00)[2]; REPLYTO_EQ_FROM(0.00)[] X-Spam-Level: Hi, > > Running outside tree (--no-tree) without git root (--root DIR) is not > > doable because we have no include/ directory which could be cached. But > > 3445686af721 expected that we are always in Linux tree (w/a git). > > But --no-tree does not require --root. Therefore skip whole caching in > > that case. > > This fixes perl and find errors when running checkpatch.pl *with* > > --no-tree --strict and *without* --root: > > No structs that should be const will be found - file 'scripts/const_structs.checkpatch': No such file or directory > > Use of uninitialized value $root in concatenation (.) or string at scripts/checkpatch.pl line 1213. > > find: ‘/include’: No such file or directory > > Fixes: 3445686af721 ("checkpatch: ignore existing CamelCase uses from include/...") > > Signed-off-by: Petr Vorel > > --- > > NOTE: I found that running checkpatch.pl on projects which vendored > > checkpatch.pl (e.g. LTP or u-boot). > > scripts/checkpatch.pl | 2 ++ > > 1 file changed, 2 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > index 0d18771f1b01..939d2b9ecebd 100755 > > --- a/scripts/checkpatch.pl > > +++ b/scripts/checkpatch.pl > > @@ -1208,6 +1208,8 @@ sub seed_camelcase_includes { > > my $git_last_include_commit = `${git_command} log --no-merges --pretty=format:"%h%n" -1 -- include`; > > chomp $git_last_include_commit; > > $camelcase_cache = ".checkpatch-camelcase.git.$git_last_include_commit"; > > + } elsif (not defined $root) { > > + return; > > } else { > > my $last_mod_date = 0; > > $files = `find $root/include -name "*.h"`; Gently ping for a review. Kind regards, Petr