From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9352D3D9029 for ; Fri, 3 Jul 2026 12:32:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783081970; cv=none; b=OyCyM70rtrfHZLe/RMj9ByU+ZX3H/RPiCMKHVAHWMvkR2DhEW/WK3esAS8bOMoWZ98E3A0ZsSsV4R68fi57Nw2DCeKcJSjhySZX+vKBGW9BcAhfFZN7y0jme4Sp537abYC+Q9p/J9liz55GMXWeEfz/PfK8g1Hn2rqwkZUZoooY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783081970; c=relaxed/simple; bh=cbhrnwky3M1OQ4/1gR5owBLQRKaVFV0YFMBztYNU3MQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ejWWVj7ybJHiqO+9wRJPv6D7InemLsOvbqNXB1+UNJTJVYccKXIdMIj1LB/zSQzTcGdKhq4YrZdhUsCHqddElyFbQjX3ciOyXtAmObvugm6SFVCLnO4jp+OF1MMFoz1AmiipEN1yRHjRkx9bIFaqmg2oIRKNbmao2RR8n1He4CU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=D1yvsuD6; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="D1yvsuD6" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-493b21b1fe8so4155155e9.0 for ; Fri, 03 Jul 2026 05:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783081963; x=1783686763; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qmGplZPZ08UUT4GJp4VHEL7joXJ434YzWEyzXagN1Q8=; b=D1yvsuD6Q06OXew7sqEsON8PqanBiKGLRPOMenn8Yq44f5k3Z+9DP97x15oSrQO7bE 176eH86kMpGwGRm6OlKJ5NwiGE17cnRGlkh9RJlXNJ7fXIbnWRPPIrXGYq3S1jiIOXcZ LjMHWOE4j0eXf1BJvGSjabdsMxzEJLFZOnfOPtb/BSQ5Nt/3wu9G8NhzIzbW//jvFy8V SiVPmln/5Gagra9BPOD9PePRzcj4gHTU1ZxnayL/b/pPFcqA3Y/WKpGOEzaRMxUnlj3K Pr2cCflZuEU10Sn8vLDSRzWWOMIzcp2kLEVYEO3gu3AtrofBBcCIdVPfzK7+8rErp3Y6 n7yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783081963; x=1783686763; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qmGplZPZ08UUT4GJp4VHEL7joXJ434YzWEyzXagN1Q8=; b=gIntKWJmT3kk6GOiWzkvDzSmsqqFXnlrQmrClOPAMhtKwXtlyjBSBbxH6W+0ONLMJc O+LiMakNqCTk4hCI+HIznmNfAW3trubUnsB66ngpfmLMbFEsA8GfeBxBvYOsMeoNcWhG 6sK6UmcIQfBFlo6VC4AhtlWPVL6qGus6ovDVttjdl7jFmKlCrrHOux7wFlqnAfPZ89KX UyrE4MO5E9SffypplB+WGfEXKZVExLd+bxoV+/JPTPxRXS9x15IPmCHoZq8JhU9C0rbv WCo2d6iPPFJQzGLvCeU0+JHnvdNwJ/Kxrx2r6Gn6Ym8U6WAHyQ3mdXABl2H76Gx1tD0r rMmw== X-Forwarded-Encrypted: i=1; AFNElJ9yHRSfo4F78dRWsRceDpXtUap1D4Eizzl78a2zKLZy119jb6jpQiNehGZgGxtK5OwV6O5+CSEufDhwGLU=@vger.kernel.org X-Gm-Message-State: AOJu0YywUXywkM1MpzouVleRsiTMHnuhVnvhEJx65V01kWUuMNu9msbJ humSrhZuFIDXwd0tUZQgtdlLRcOH/wa5ggISmRQ7nQTL32Bw3kLCEiBVmvmXqBe7ZpBAZ4MGUQ+ L5VCXWSgXVMawTQ== X-Received: from wmok15.prod.google.com ([2002:a05:600c:478f:b0:493:b78f:716b]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:35d2:b0:493:c3f9:65a2 with SMTP id 5b1f17b1804b1-493c3f9664bmr156103915e9.5.1783081962154; Fri, 03 Jul 2026 05:32:42 -0700 (PDT) Date: Fri, 03 Jul 2026 12:31:58 +0000 In-Reply-To: <20260703-alloc-trylock-v5-0-c87b714e19d3@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260703-alloc-trylock-v5-0-c87b714e19d3@google.com> X-Mailer: b4 0.15.2 Message-ID: <20260703-alloc-trylock-v5-18-c87b714e19d3@google.com> Subject: [PATCH v5 18/18] mm: factor out can_spin_trylock() From: Brendan Jackman To: Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Johannes Weiner , Zi Yan , Muchun Song , Oscar Salvador , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Mike Rapoport , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , Hao Li , Christoph Lameter , David Rientjes , Roman Gushchin , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt Cc: "Harry Yoo (Oracle)" , Gregory Price , Johannes Weiner , Alexei Starovoitov , Matthew Wilcox , Hao Ge , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, derkling@google.com, reijiw@google.com, Brendan Jackman , Yosry Ahmed Content-Type: text/plain; charset="utf-8" Deduplicate checks for whether the current context is safe for spin_trylock(). Does this function really belong in mm/internal.h or is it generic? Not sure. If someone ends up duplicating this logic elsewhere in the kernel, that would be a shame. But if it goes in some generic header, someone treats it as documentation about where it's guaranteed safe to spin_trylock(), and then it emerges that there are other subtle preconditions that didn't affect the mm usecase, that would be worse. So, just be conservative and keep it local. Suggested-by: Harry Yoo Link: https://lore.kernel.org/all/397859cb-b127-4cc6-9c71-044afc99bf0c@kernel.org/ Reviewed-by: Vlastimil Babka (SUSE) Reviewed-by: Harry Yoo (Oracle) Signed-off-by: Brendan Jackman --- mm/internal.h | 23 +++++++++++++++++++++++ mm/page_alloc.c | 17 +---------------- mm/slub.c | 10 +--------- 3 files changed, 25 insertions(+), 25 deletions(-) diff --git a/mm/internal.h b/mm/internal.h index 7e3b2386e274b..0ae6ad2265125 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -1716,4 +1716,27 @@ static inline void mm_prepare_for_swap_entries(struct mm_struct *mm) } } +static inline bool can_spin_trylock(void) +{ + /* + * In PREEMPT_RT spin_trylock() will call raw_spin_lock() which is + * unsafe in NMI. If spin_trylock() is called from hard IRQ the current + * task may be waiting for one rt_spin_lock, but rt_spin_trylock() will + * mark the task as the owner of another rt_spin_lock which will + * confuse PI logic, so return immediately if called from hard IRQ or + * NMI. + * + * Note, irqs_disabled() case is ok. spin_trylock() can be called + * from raw_spin_lock_irqsave region. + */ + if (IS_ENABLED(CONFIG_PREEMPT_RT) && (in_nmi() || in_hardirq())) + return false; + + /* On UP, spin_trylock() always succeeds even when it is locked */ + if (!IS_ENABLED(CONFIG_SMP) && in_nmi()) + return false; + + return true; +} + #endif /* __MM_INTERNAL_H */ diff --git a/mm/page_alloc.c b/mm/page_alloc.c index c3b246e67ed14..a63733dac659e 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5291,22 +5291,7 @@ static inline bool alloc_order_allowed(gfp_t gfp, unsigned int order, static inline bool alloc_nolock_allowed(void) { - /* - * In PREEMPT_RT spin_trylock() will call raw_spin_lock() which is - * unsafe in NMI. If spin_trylock() is called from hard IRQ the current - * task may be waiting for one rt_spin_lock, but rt_spin_trylock() will - * mark the task as the owner of another rt_spin_lock which will - * confuse PI logic, so return immediately if called from hard IRQ or - * NMI. - * - * Note, irqs_disabled() case is ok. This function can be called - * from raw_spin_lock_irqsave region. - */ - if (IS_ENABLED(CONFIG_PREEMPT_RT) && (in_nmi() || in_hardirq())) - return false; - - /* On UP, spin_trylock() always succeeds even when it is locked */ - if (!IS_ENABLED(CONFIG_SMP) && in_nmi()) + if (!can_spin_trylock()) return false; /* Bailout, since _deferred_grow_zone() needs to take a lock */ diff --git a/mm/slub.c b/mm/slub.c index 3989b4758ae0a..b19dc46de73c5 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -5408,15 +5408,7 @@ static void *__kmalloc_nolock_noprof(DECL_TOKEN_PARAMS(size, token), gfp_t gfp_f if (unlikely(!size)) return ZERO_SIZE_PTR; - /* - * See the comment for the same check in - * alloc_frozen_pages_nolock_noprof() - */ - if (IS_ENABLED(CONFIG_PREEMPT_RT) && (in_nmi() || in_hardirq())) - return NULL; - - /* On UP, spin_trylock() always succeeds even when it is locked */ - if (!IS_ENABLED(CONFIG_SMP) && in_nmi()) + if (!can_spin_trylock()) return NULL; retry: -- 2.54.0