From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 720FF414DEB for ; Fri, 3 Jul 2026 15:17:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783091840; cv=none; b=nL8+aobGfw2R5VFA865R/DoOa85BKWiNND5sVPzTIDgwExLcvpKdTlaJpuztX9QK4zw0La73wx5C1RIBL7RvHDk6KPuVhJnvkHBwNuSNAmhfB4f3tlJUNMIUuL4GjUwJQ6j7zMWTOvKWqLl9Z1C8IG2E2ZLH8TK/hyi/a1JN1c4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783091840; c=relaxed/simple; bh=XFFg61obA3qsjXJjqH4r33ESGnevy+fzfPZQQs8QGPk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VV1YsOwhRzrra8SoNsSVKfrCAWBXVv0a+c3uIrNazrB6U/7VBcFe75n1pkZ+tmlvQloLA7x/GQs4c0FiJ8M/AnVtn0OdYaGhGDwkqMIXXLMaI/mJZeiFHDeLjs3/JsPpSVXICMEVzITJyX3hzyOxUgK2RNKfJAS11wSIUM+o7vE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Yx3AUNm2; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Yx3AUNm2" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-493be0fbcc5so184225e9.0 for ; Fri, 03 Jul 2026 08:17:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783091837; x=1783696637; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8s+kQBALUfBmxcLdBRHfyiAZoSnCeSt/tQ8n5wZfgzY=; b=Yx3AUNm2e2vC68NN2OyCd12c2TscOjdYjAWxX+wSL7JmnWn3BlrYxyJb8J8n4+CgzK MlISIbXmnNojAKEkrOdsSXvullvd08Ax1GC+UG7jcxoF9h7mVGUWjLtQssXLrUm7ahzp asqid1lVOwNW9UbRqqjwd8dXcroCzmHUWJ2SuEetUetj5QkZO/Z84N5Y2QcFPLCJ5f29 UUzU8uzy16JyTNTMsgvx2nRkhYYynyweqbKqtG+8m+abGBKMq5D5Vpnatgvnryb9Ojnk dnzFof9eEF9Sfik2nbEwmFDzfKncIv15jCFTGg04QslUrP9OtFK+VpXHSn6K3A1L9n1A omow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783091837; x=1783696637; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8s+kQBALUfBmxcLdBRHfyiAZoSnCeSt/tQ8n5wZfgzY=; b=JCD9DhyRaQsDR4FR0r5L6UkkI3RKu0lG2xFg79chKDQb1Zh32CUan/dYDaOWSfZ2sw K9AFUKZoFaMf+dh+X/tNW0nmAutHMGxBGbuYsgqyunGIAsugy9kYhIPSQ7tKMAjuIXbZ za8mrLuGaPpg9LKTDzcQ0pzxgum+ypaBw+9PZcM5N3ysBhY7mSeL5sWgEq116UzZ7IUI JBHBaD3vwsyt/qZQhSM04IQlwtbJzCs5nLmdsuYQDUXbDYlK6jU8hPhx7Os067g8jzlc L4ihWqqe7vgmHBxIeLkDtMa/UgPINuu2NX3wntRkG4OgkS5qxNngqiQKmULFQXSrfgKj h4uA== X-Forwarded-Encrypted: i=1; AFNElJ92qvbBHuK4OJ2BXsYK6DKI8YhX1HKWzvx/X7ANotzvoowQqhDfOjIRg4DO37ww3aPyHoKEZTaIib75pcM=@vger.kernel.org X-Gm-Message-State: AOJu0YwuUPSK7ZdqQ0xCemu/wRqdgFZk4x3e1t2Q/sYt/gRGGg3c6hV7 eR/trVjBkjt+vGL2Ww23J/yzz23PdqrgZjlvdy81ttmyli/Om0zwjF3biAnqHvqgvg== X-Gm-Gg: AfdE7cmY/Vej9bDqZeNI8guZUFDv9YIv6A6WScYTb+GnSQJ2UwlYfYjAsr4JHH5YO0+ VAJvEupMhXt2U1PB4xZr+lKdgUudgG6Oqlo5vaeFJZj+pIln+RhbcWg8439S9scjrNjnhixqwcy AsY1ygN44tfPHqxPTMxZHjuM6zHHQyKaF0mFkeNuM+ay9a5jpmtK76aig1n0iT9Dt4U9cifYDrb /XUzqvk9lC+ehdIAZ3Kwn84AoZiPBdaqukHfYmayDnqDO8pWjFidvUpn9oGRVAc8PbMeUiudIBi +LSE0wCXNC9NtxKc0aeK7OTDrVQJJMGNBo5RYluS3xA/MeW0Y/fVzmtNHbN+ogOiAGnBENjMw6c 5+I6qrOmw7eQCdggOWYgocuZ/nHCj97x1Xy0ZDopwbJllCERAbiIwoeEvhVuGxAV4YVGU5gf9y5 c7p05H/3Z8kmmQKBVjTmivUNmpKciw4HvX2D+2Ryj4OeY4jG+eU7qu1UkTul7ITbH7PI/pZXk= X-Received: by 2002:a05:600c:b4e:b0:493:c1a0:7fdc with SMTP id 5b1f17b1804b1-493d0fe58a3mr22775e9.0.1783091836475; Fri, 03 Jul 2026 08:17:16 -0700 (PDT) Received: from localhost ([2a00:79e0:288a:8:c0d:89b8:4c51:d7de]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0a55be4sm8843f8f.31.2026.07.03.08.17.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 08:17:16 -0700 (PDT) From: Jann Horn Date: Fri, 03 Jul 2026 17:16:48 +0200 Subject: [PATCH 2/3] HID: huawei: fix missing hid_is_usb() check Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260703-hid-usbcheck-v1-2-e80259ff625d@google.com> References: <20260703-hid-usbcheck-v1-0-e80259ff625d@google.com> In-Reply-To: <20260703-hid-usbcheck-v1-0-e80259ff625d@google.com> To: Jiri Kosina , Benjamin Tissoires Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Mario Limonciello , "Luke D. Jones" , Miao Li , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Jann Horn , stable@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1783091826; l=1562; i=jannh@google.com; s=20240730; h=from:subject:message-id; bh=XFFg61obA3qsjXJjqH4r33ESGnevy+fzfPZQQs8QGPk=; b=nhtictv0Odwlgk6Awml9jwFofS+SYnOW+CcJLL4GvrTICK+lA1ED+SbtsWfno6SVm/lP0qFn/ 0Vwse06VGsrCALRWKfQjqDXA4HuhHRRn8lvINQBmwTB16wnGhoS67hy X-Developer-Key: i=jannh@google.com; a=ed25519; pk=AljNtGOzXeF6khBXDJVVvwSEkVDGnnZZYqfWhP1V+C8= to_usb_interface() can only be used on a hid_device whose parent is really USB; uhid can create devices that identify as being on BUS_USB, but don't actually have a USB parent. Fix the use of to_usb_interface() without a hid_is_usb() check. I have verified that it is currently possible to trigger a kernel splat due to this bug in an ASAN build, and that this commit fixes the issue. Fixes: e93faaca84b7 ("HID: huawei: fix CD30 keyboard report descriptor issue") Cc: stable@vger.kernel.org Signed-off-by: Jann Horn --- drivers/hid/hid-huawei.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-huawei.c b/drivers/hid/hid-huawei.c index 6a616bf21b38..ee3fc6f68475 100644 --- a/drivers/hid/hid-huawei.c +++ b/drivers/hid/hid-huawei.c @@ -44,11 +44,12 @@ static const __u8 huawei_cd30_kbd_rdesc_fixed[] = { static const __u8 *huawei_report_fixup(struct hid_device *hdev, __u8 *rdesc, unsigned int *rsize) { - struct usb_interface *intf = to_usb_interface(hdev->dev.parent); + struct usb_interface *intf = hid_is_usb(hdev) ? + to_usb_interface(hdev->dev.parent) : NULL; switch (hdev->product) { case USB_DEVICE_ID_HUAWEI_CD30KBD: - if (intf->cur_altsetting->desc.bInterfaceNumber == 1) { + if (!intf || intf->cur_altsetting->desc.bInterfaceNumber == 1) { if (*rsize != sizeof(huawei_cd30_kbd_rdesc_fixed) || memcmp(huawei_cd30_kbd_rdesc_fixed, rdesc, sizeof(huawei_cd30_kbd_rdesc_fixed)) != 0) { -- 2.55.0.rc0.799.gd6f94ed593-goog