From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07A9623D7F0 for ; Fri, 3 Jul 2026 02:09:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783044574; cv=none; b=geqE9P8tL6h2PGahtais7a8QEJnLMuiW7CJzGuImJVsTvy5YJgodV028XTMz0Zioyt7Q8C+D4xGTakvs9kRG5MgFuGhp/bjczMzfM2HyftJKvD72zmclRr8y3HfmKE1QKmIn+Gi2aZCheJrHwK0Vhz+O6UKu4Zu2CAAGqkSDQ80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783044574; c=relaxed/simple; bh=AwHh06WUuyhBQBoDOa1+i90MPPyULcw/U/Rkk+ADDxI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=udoFgsF+Aj0bSPuUwcVEJPacF3iJeuxQkt4or+MliO4aCPntrp4TCJO6tXir0TYxLtvBimfl1J1Fnx6WGS9eCwBBfcQcYd/NZ3oYKxBaJp4cJvUIzrdastGpBJLzYIkldIPtkMllKTAmk5cGDV+G404b+InjFrvX2ZUSZfqsMQ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kSgsRia+; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kSgsRia+" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-847a483e344so62878b3a.0 for ; Thu, 02 Jul 2026 19:09:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783044572; x=1783649372; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mpHH2Bk0G92IhA+zOEFgRvW9nM8wHQ+j2eGIv35HORI=; b=kSgsRia+DRIWEjldJTdjyWFm3qZ9/0SDoWV7msd+SMaYxQjpJmupf7C1/pBf45x7tT BPCWtCqBtztF+zdNx8B0p+B3yOOjeF+XpDwzGwNKj7dDqSuV4p6IQVTqANa5JTounjfM Kn+udghMWTgaXC2ujb43QyZAM/Do9dfj/nO9HGdlPotXfAE1AOE/8ZsUEU+CLBIDOX2G xRbS4MPiBIl+64Sa2bqzOculOcW2nloyUnj1VzGQl565snPu3cwv5QR0ChoBN/vlKj+w yBzzpa2GNY9dIo8egIEviczSLBsWXzgz050PXb2a2teNoXvlCUlq5I2Ffsnq10BpXiCg JM3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783044572; x=1783649372; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mpHH2Bk0G92IhA+zOEFgRvW9nM8wHQ+j2eGIv35HORI=; b=kvxaucdFNVK2Rto9YORI/bCOG9iTL8wnjI5mGPztCoWpZPsQf+Gku8fYYc2j9ZxAuc WP7iD8JayEJEnZctAUWriddhyH6UAURPgBqHV3SItcn90gdBqcomEIXtKRYs/CQURZaB 0wTX54ievlh9JkGqSEBqi03qfmN6WYNBoOt6PwbEmOJwEdcb/YGLNr600m2jqpTe69pC mHIVW0X5RnfVATKf0fe81Megm182kxJbSfF/e2gc64OedEICkXfLv5bSPk0xD6Dw9cFg jiOyObJbAFlWBQmpzmAiEhSTBC8g6wsLiKJKGFWZBQmCtFsDW2Z4lcJRsqB6GzSz06jM 46jA== X-Forwarded-Encrypted: i=1; AHgh+RpsgFsMeKjwbg3AyoSq/UXQGj6lPnb8jbxUoc4GrPEWDQkpKZhfQKmdTqhl2mAWpspMEC5mFWsHntkSdoQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwzuNUFIw1T/P7WOv3xUvDtqks+tQ5JPEvr992zw1MIRl1cm5ed zxGH4/0j+y7PqkW1wqLfbOieEQiB51hm579Q6QJf3myA1qjbom6XdvN1yUBMSA== X-Gm-Gg: AfdE7cmtnsW6R8yD1HppXo5p/qhO47DQnuZImUyp6pKxqtFIJiME4zB436/OgHt7HsX 3t891zXkhth2P3MD8lAkyyRwpmKzb7Xd/uLzgY42xmPRPmiln3SFnJVvRtVkEYhSbHVyQDh8FSs obKybcaER/5KbIZipG72Kzs296WH/znJEH+CGbS568RNQDKEZksf+Yl7P8aZAr6Pp4l5vqHiuD5 q7tjmMH/RIEwjkKjLf/JcwERzabQl54/rnOS3QRGurNIiOj6qb8sYwgw9e//hTrmbTTRKF0Nd3l 3jyLpBvA+/imf8MUKvB3YUQkA2FYSAmLYmLwBTF90MtZCkZk2JQpMclia9IuNbfpGhwMtuK+J3o jH8jMpaeC84yPaXF9XkjXCuOhqItRziFHGs5Djle62xux/2II2zjovemdFE4GOKXepSpar3BRPL yZ6zSY+FPmlSta/5EEmYPiNyuW546cHWgmhq5MKipb7++e4FexYQgOhvpNAQ== X-Received: by 2002:a05:6a00:2912:b0:845:df4a:2a2c with SMTP id d2e1a72fcca58-847e1769167mr2030708b3a.8.1783044572045; Thu, 02 Jul 2026 19:09:32 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847cb6dcd7esm2178310b3a.11.2026.07.02.19.09.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 19:09:31 -0700 (PDT) From: phucduc.bui@gmail.com To: Alasdair Kergon , Mike Snitzer Cc: Mikulas Patocka , Benjamin Marzinski , dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH] dm: Drop redundant nonseekable_open() return check Date: Fri, 3 Jul 2026 09:09:18 +0700 Message-ID: <20260703020919.7958-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc nonseekable_open() never fails, so the error check is unnecessary. Remove the dead error handling path. Signed-off-by: bui duc phuc --- drivers/md/dm-ioctl.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c index ac77dc0ca225..11574b1e2017 100644 --- a/drivers/md/dm-ioctl.c +++ b/drivers/md/dm-ioctl.c @@ -2273,12 +2273,9 @@ static long dm_compat_ctl_ioctl(struct file *file, uint command, ulong u) static int dm_open(struct inode *inode, struct file *filp) { - int r; struct dm_file *priv; - r = nonseekable_open(inode, filp); - if (unlikely(r)) - return r; + nonseekable_open(inode, filp); priv = filp->private_data = kmalloc_obj(struct dm_file); if (!priv) -- 2.43.0