From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 865FF31714B for ; Fri, 3 Jul 2026 03:39:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783049969; cv=none; b=J5hXFR1JhZfBHakYUm6AQ/mStIFBjHKhmqiTsCpEs+Uc7/1dm7eRg3MJXS/L3w79RrX/8SENHm5XJuuxfMinitwcri5xjOQV+gHXvXWBT/e1THmWkOFz5xIeohFt56kitA3+zI4cAEUOBhER5uPG6noiDk1JMEObTh45Zk5sSKk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783049969; c=relaxed/simple; bh=EmOCe3dlmsY/xqj/qF3riy9y/Z0aLuKXGFjXqRSS+rw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iLuqw5E4vbgPMm5RNLVgDbIxd4BZKwBHIgnnzYDJaaloZiJxifeqnaLQjHiLdRsQpL159JDaErGAQ4bvA/4+xbLI1xS/d6Ht0f5ebMKdRpAH79yu1T1ZWP1kr7anuDvNVOil2mzHJlckUGEpQduXzCdLgQtk/7mDNEUm/YG07JI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZZFvXZE1; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZZFvXZE1" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-3810e733d85so111859a91.0 for ; Thu, 02 Jul 2026 20:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783049959; x=1783654759; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LGEbmGBP95wGa6K79zSaf3K/rpb1ObdZEZ70xmn01LU=; b=ZZFvXZE1BFoZEamCiMK1NBl+Y3rhpPSD9pr3qvZOOTabVfDRoVfEDi0MwUQxPyoo+x 2WtOqpj4biO8dfXVp7jwGqt6AlAH4LJcj7nS4OhJ2vy96nQzbV5akKwUVqeuKkl4mGbS HANdLp+eraffZHVc3b32ZzpBhiFPX2Rq+Ya+MgjOMWaw01VB9DA1l+nGb0KSLyyVwC58 A16SY9qB5aQsFmXCqRLeslbEMcS/1HIX2Uw+1Wha1ba649Wx3KF0uC7QfPUg4QVft4gX 3du/k4jW2hu+QPeUF46LltqmR1nrzjgxUtBL8LkBMMTe8kSlxlvKTY+Cv9/bdPi5blLH aNzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783049959; x=1783654759; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LGEbmGBP95wGa6K79zSaf3K/rpb1ObdZEZ70xmn01LU=; b=a62Zrt1FIM8pfIYnGIthe3DCfai0oUE3CYIwDqh61VxBWGhjrEMDEme6Gv0o3VX02r n8ydDdOyvk4R7hRbkIXs6T0bguu4+pQagKZhbb4Qo3kYwc6hRqrKkq/M0U6twNIHrOxc dtpvqx5InL/X5o+boaNFsvaUYS4JcDioI2bcKRLZDoYm4hcvoUSqAam4zjEdYGvpibXj K5vJkQkbtfZNqgziI6+WUv02nCqXqXcED46jVFo3FilfUXKl0lFJXtbxoTwdJYqMeRwq 4YUFMWvqkwAf35yZlwC2LK+0NTzQROotnZ/k3L/WORyn9Y+LVJja/fs1RODuFdqRRTyZ UDVQ== X-Forwarded-Encrypted: i=1; AHgh+RpxzXI1ps0BK9afvcMRY9jYbvd49qJz17bpGCu5z5ta67CFIYUZFyoq5KceQLYs1MWfuozN4CrjLrhY6v0=@vger.kernel.org X-Gm-Message-State: AOJu0YzBvbceBd4GBa0G3Qkueg5IVPlxKmik9yhg+ozEu3uPq1YR1tfE DgvKmYZn+uUaTqe8e1MLLhtiVg3oautaQHPJzy57gGcptesL/FLOJ2dZOsGyYoS8 X-Gm-Gg: AfdE7ckyq/u3lVRpvNfODu6zeJhLVpOvZ9PifitckR+NRq9inPTAnMOIxIB+9YuMMex SQBRhCeQ4krl6pV4WSCOY3G+mLNPV+hJacqKy8+eBX0/dkMnkwsh8xsoEOrxBoSwFMUFGEa8Vys FXuvoDEXDsFkkJIqj5UnU44l5LKkfBqb4ybs7zFLDrB1tcTZu4iTgjDQxCPNDgklDfBF7qFa994 pbDTqUPOYf4GlxDPXCOc3UVNf+k3BKHgcM4s2+tdtehkhTwfWGnT1IRE/zJ5SGq7EgFT4zcZ+yQ asEf1wVbtW9hr70kiuyfFqro3v4z78t+b9GmIsyBacujoM4NFYpP9UOND26kbKgpeQub5kWdxyO 6kZ16MzOYKRHL3rf+TJ1Pnxz/n3Zn8yde20X3r5KvlHKLT78X1GP22sRm2fwFvlD3AxLE/KKIVg dSWYbjQCDaRgJTMan3sOOvdyHqA7rL7jNHxjw8rBwLflRn1g9/EdaxPjY0E4dvN2Q= X-Received: by 2002:a17:90b:4d12:b0:36d:66d4:270e with SMTP id 98e67ed59e1d1-380aa0a8048mr9587437a91.5.1783049959073; Thu, 02 Jul 2026 20:39:19 -0700 (PDT) Received: from DESKTOP-L3Q0GIV.localdomain ([203.230.195.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38127c56b7dsm294728a91.9.2026.07.02.20.39.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 20:39:18 -0700 (PDT) From: =?UTF-8?q?=EC=9D=B4=EC=83=81=ED=98=B8?= To: Namjae Jeon Cc: Sangho Lee , Hyunchul Lee , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [BUG/RFC] ntfs: crafted image triggers WARN_ON in ntfs_map_runlist_nolock() Date: Fri, 3 Jul 2026 12:39:14 +0900 Message-ID: <20260703033914.98698-1-kudo3228@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20260701221237.822167-1-kudo3228@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Sangho Lee Hi Namjae, Thanks for the patch. I applied it to my NTFS test tree and rebuilt the kernel. I then reran syz-repro with the same syzkaller crash log that reproduced the original WARN_ON in ntfs_map_runlist_nolock() on the unpatched kernel. Result: - unpatched kernel: the same log reproduced the WARN_ON in ntfs_map_runlist_nolock() - patched kernel: syz-repro ran through all extraction phases for 29m28s and failed to reproduce the warning: - 15s single runs: no crash - 15s grouped/bisect: did not crash - 1m40s single runs: no crash - 1m55s grouped/bisect: did not crash - 6m single runs: no crash - 6m15s grouped/bisect: did not crash - no kernel WARNING/Oops/BUG lines were observed The change also matches the root cause I saw: when ctx_needs_reset is true, ntfs_map_runlist_nolock() can reach the runlist mapping path for a resident attribute. Returning -EIO before using the non-resident mapping fields avoids triggering the WARN_ON and prevents the invalid path. So yes, this patch fixes the issue from my side. Tested-by: Sangho Lee Thanks, Sangho