The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "José Expósito" <jose.exposito89@gmail.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
	simona@ffwll.ch, boris.brezillon@collabora.com, kees@kernel.org,
	"José Expósito" <jose.exposito@redhat.com>
Subject: [PATCH 1/2] drm/tests: shmem: Set DMA mask to 64-bit in drm_gem_shmem_test_get_pages_sgt
Date: Fri,  3 Jul 2026 08:34:26 +0200	[thread overview]
Message-ID: <20260703063517.6346-2-jose.exposito89@gmail.com> (raw)
In-Reply-To: <20260703063517.6346-1-jose.exposito89@gmail.com>

From: José Expósito <jose.exposito@redhat.com>

drm_gem_shmem_test_get_pages_sgt intermittently fails on ppc64le and
s390x CI systems with a DMA address overflow: [1]

  DMA addr 0x00000001b6110000+65536 overflow (mask ffffffff, bus limit 0)
  WARNING: kernel/dma/direct.h:114 dma_direct_map_phys+0x298/0x300

  drm_gem_shmem_test_get_pages_sgt: ASSERTION FAILED at
    drivers/gpu/drm/tests/drm_gem_shmem_test.c:255
    Expected sgt is not error, but is: -5

The call chain leading to the failure is:

  drm_gem_shmem_test_get_pages_sgt()
    drm_gem_shmem_get_pages_sgt()
      drm_gem_shmem_get_pages_sgt_locked() [drm_gem_shmem_helper.c]
        dma_map_sgtable()                  [mapping.c]
          __dma_map_sg_attrs()
            dma_direct_map_sg()            [direct.c]
              dma_direct_map_phys()        [kernel/dma/direct.h]
                dma_capable()              Checks addr against DMA mask
                  -> FAILS: addr > 0xFFFFFFFF

The root cause is that KUnit devices are initialized with a 32-bit DMA
mask (DMA_BIT_MASK(32)) in lib/kunit/device.c. On ppc64le and s390x
systems with physical memory above 4GB, page allocations can land at
addresses that exceed this mask. When drm_gem_shmem_get_pages_sgt()
attempts to DMA-map these pages via dma_map_sgtable(), the DMA layer
rejects the mapping because the physical address overflows the 32-bit
mask.

The failure is intermittent because pages may or may not be allocated
above 4GB on any given run depend on memory pressure.

Fix by setting a 64-bit DMA mask on the device before calling
drm_gem_shmem_get_pages_sgt(), following the same pattern already used
in drm_gem_shmem_test_obj_create_private().

[1] https://s3.amazonaws.com/arr-cki-prod-trusted-artifacts/trusted-artifacts/2643976103/test_ppc64le/15128551933/artifacts/jobwatch/logs/recipes/21561041/tasks/220716705/results/1014628163/logs/dmesg.log

Fixes: 93032ae634d4 ("drm/test: add a test suite for GEM objects backed by shmem")
Closes: https://datawarehouse.cki-project.org/issue/3184
Assisted-by: Claude:claude-4.6-opus
Signed-off-by: José Expósito <jose.exposito@redhat.com>
---
 drivers/gpu/drm/tests/drm_gem_shmem_test.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tests/drm_gem_shmem_test.c b/drivers/gpu/drm/tests/drm_gem_shmem_test.c
index 44a190109249..c217a9ec7240 100644
--- a/drivers/gpu/drm/tests/drm_gem_shmem_test.c
+++ b/drivers/gpu/drm/tests/drm_gem_shmem_test.c
@@ -250,7 +250,11 @@ static void drm_gem_shmem_test_get_pages_sgt(struct kunit *test)
 	struct drm_gem_shmem_object *shmem;
 	struct sg_table *sgt;
 	struct scatterlist *sg;
-	unsigned int si, ret, len = 0;
+	unsigned int si, len = 0;
+	int ret;
+
+	ret = dma_set_mask(drm_dev->dev, DMA_BIT_MASK(64));
+	KUNIT_ASSERT_EQ(test, ret, 0);
 
 	shmem = drm_gem_shmem_create(drm_dev, TEST_SIZE);
 	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, shmem);
-- 
2.54.0


  reply	other threads:[~2026-07-03  6:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-03  6:34 [PATCH 0/2] drm/tests: shmem: Fix intermittent DMA overflow on ppc64le/s390x José Expósito
2026-07-03  6:34 ` José Expósito [this message]
2026-07-03  6:34 ` [PATCH 2/2] drm/tests: shmem: Set DMA mask to 64-bit in drm_gem_shmem_test_purge José Expósito
2026-07-03  6:53 ` [PATCH 0/2] drm/tests: shmem: Fix intermittent DMA overflow on ppc64le/s390x Thomas Zimmermann
2026-07-03  9:00   ` José Expósito
2026-07-03 10:32     ` Thomas Zimmermann
2026-07-03 14:30       ` José Expósito

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260703063517.6346-2-jose.exposito89@gmail.com \
    --to=jose.exposito89@gmail.com \
    --cc=airlied@gmail.com \
    --cc=boris.brezillon@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jose.exposito@redhat.com \
    --cc=kees@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox