From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Maxwell Doose" <m32285159@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] iio: temperature: Add STS30 temperature sensor driver
Date: Fri, 3 Jul 2026 08:42:56 +0200 [thread overview]
Message-ID: <20260703084256.00001f7f@gmail.com> (raw)
In-Reply-To: <20260703003159.44850872@jic23-huawei>
On Fri, 3 Jul 2026 00:31:59 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> On Sun, 21 Jun 2026 19:09:11 -0500
> Maxwell Doose <m32285159@gmail.com> wrote:
>
> > On Sun, Jun 21, 2026 at 7:05 PM Maxwell Doose <m32285159@gmail.com> wrote:
> > >
> > > On Sun, Jun 21, 2026 at 1:33 PM Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> > > >
> > > > On Sat, 20 Jun 2026 19:46:24 -0500
> > > > Maxwell Doose <m32285159@gmail.com> wrote:
> > > > > +#include <linux/array_size.h>
> > > > > +#include <linux/bits.h>
> > > > > +#include <linux/cleanup.h>
> > > > > +#include <linux/crc8.h>
> > > > > +#include <linux/delay.h>
> > > > > +#include <linux/device.h>
> > > > > +#include <linux/errno.h>
> > > > > +#include <linux/export.h>
> > > > > +#include <linux/i2c.h>
> > > >
> > > > I am a numpty as I also forgot to mention a missing
> > > > mod_devicetable.h header.
> > > >
> > >
> > > D'oh, I ought to look at my includes a lot more closely as well.
> >
> > Forgot to mention, I'll be away for 2 weeks starting tomorrow so it'll
> > have to wait :(
>
> Don't add mod_devicetable.h. There is a series from Uwe that splits that header
> up and puts the tables different headers. i2c.h is now enough.
> (It's causing merge conflicts)
Cool, one include less to worry about.
--
Kind regards
CJD
next prev parent reply other threads:[~2026-07-03 6:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-21 0:46 [PATCH v2 0/2] iio: temperature: Add support for the STS30 temperature sensor Maxwell Doose
2026-06-21 0:46 ` [PATCH v2 1/2] dt-bindings: iio: temperature: Add STS30 devicetree bindings Maxwell Doose
2026-06-30 15:41 ` Rob Herring (Arm)
2026-07-02 23:36 ` Jonathan Cameron
2026-06-21 0:46 ` [PATCH v2 2/2] iio: temperature: Add STS30 temperature sensor driver Maxwell Doose
2026-06-21 18:33 ` Joshua Crofts
2026-06-22 0:05 ` Maxwell Doose
2026-06-22 0:09 ` Maxwell Doose
2026-07-02 23:31 ` Jonathan Cameron
2026-07-03 6:42 ` Joshua Crofts [this message]
2026-07-03 0:05 ` Jonathan Cameron
2026-06-22 15:45 ` [PATCH v2 0/2] iio: temperature: Add support for the STS30 temperature sensor David Lechner
2026-06-22 15:51 ` Maxwell Doose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260703084256.00001f7f@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m32285159@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox