From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12CF13CC7EA for ; Fri, 3 Jul 2026 12:21:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783081293; cv=none; b=ffr+tJx2FnmO2uzgmC5sTrpbkgC2zVJVv8ZA3seNLrq8Uzh4Omy9HC0ExK+CJ4vAue6tU75crAJFkp1GrN6Y+iAoGZa0V5pBMOAfdW/tq1PCSV1Lab3y0sEwd3jGf85EiTWQz6aFa1g3VQ6W8WuZ/SdekZ2LbsDQJ0sJYuYD6xU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783081293; c=relaxed/simple; bh=NM0qdi/U1SW17ipI8zJAG47GqlYWil/CAlavCXQuq84=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kCjHYjDOFqdO20xrR+5hzVTwbI416ZArFfFb7MQ+B+ysLnkCD2C0V6io0B45Z8lihyTLvsnwv/rqm0tZypsCwtd/oW1s8wA1y+duZR9/z66N/kmm96j2uin9ILHUgQxkr4WKOO/koH6QfJ4iqpSKz/UD0lCLYaVqHShTahnnMwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NCuXOgT1; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NCuXOgT1" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-37fc01a7835so423926a91.3 for ; Fri, 03 Jul 2026 05:21:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783081291; x=1783686091; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=37rS3S15ZKgHXdlCeYBDdqpX9m5LHn58JhbTp1kkqUw=; b=NCuXOgT10lDmaeirjVzb2kCkJowz2ERgNPdHuPS6/ENPWxxd6bdil0QWspUtm6R5// t5u1Z1wWg+01dmW1YHpxRA8ayKoO7MHfnw8lVrwowosblCs0JcApqLLRetwvGhS72ptu SbXHsc83JQ7SPrzkWn07wikv4sxf92fj4FnoXQa8DxkWoYv1v98oIO9OPkUlTDAwOUG5 Bb6IIQsZpyWaGkVcppS76tCD0RUB6m/G3gefzvyJYf6Rm4sZGdgT71e6iNO7YlxRprE7 9DC0L4ZYFbITod6m+JSjCC/6cPdQffAmfEdeWQ2WbLuyowo/ilErNJG/kKVfh2s8u7UR uzLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783081291; x=1783686091; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=37rS3S15ZKgHXdlCeYBDdqpX9m5LHn58JhbTp1kkqUw=; b=Ae7MZQ2l4uceNnn05LdnN9dxmgE7abwZnkBUygu3gFeX1O8vdHmBDdRMCdLDiZDKWe 9dnM2i0iu8QUUgusFaT06qjuWfcgfl2JLszrCKJkurgK/vqf8AL76I/w2M7SMKEj6VgH RwcRih7Cixr7+fjp5lmQfN40bubWi88DQVA62iBnwa4UZVY1w0Sf6ylsjX7BVEhf4ORu 1tAS+J7UuOS0WjZ70owMGv3YXyJr4Pj9Cpyv8/7T2V0sCuxrGWOSttTNDEzGsczI6D0b J6nzvHwQp2AtmuZQmj3sRYtmjqpVwb9q3MXr8wf4RFdmvQfV1VSWaHvCgowsjkLIqfM2 oosA== X-Forwarded-Encrypted: i=1; AHgh+RoWSmO4ldoXq4PvBUcBNWh8BbuB3iLef4fgqPpJKAPkikg4VVCcWUuHaZg3buY0UhUM6T74J2iJN7DNAdA=@vger.kernel.org X-Gm-Message-State: AOJu0YwkyOYDNQMZAQGaxw0uPZsd9740qzBi4ayWSbZBR3gGe2FIiAdj 1WKWxoEvFWkcrKjcFv/idQqAEIG/fXZdmnk+FG6cbPbdz29jFIMs7gOV X-Gm-Gg: AfdE7ckz+XcE+SS1RrdtfwOmCwwwhWT5JoeIZ3I+CYGjkNfX0gvZtPQmLdwP/hWZijv h1LJj26g6CaVUD3AfBW+HRthgWOyNMPrwDzvN530ArJXxc+6oe2KSjVsAwvpO7Gj4hLp+eYNrrG MGQW15d2G6WBMHINlRyAE/TqMYFyOumay1MHgCkTf6K5NGn+ubn6CPNQJ9NEps9LsPRLVpthzC3 ao534FJMIarPzDf2YRsQ1BuuZuED1hDnqSsenRbsuvDQSNLPyFWuz4fxbIzJf5WagkioX7hA8l/ +wbyJtPJOm24+G+y9XXb2KwFgNPFVmEThnA77q8WLlL+whDe7C33X+DHb5+MXW2DkKk8tfFWCWa VcjLH/6xoDsyR6cLphL7Hr5vLl/M2r0g540nNoZJb+nUYwGFCaQk2FRWLgfqrMtrlX+SdY0Vi7B J4pSOXL40IalI= X-Received: by 2002:a17:90b:5547:b0:37f:fd1f:d30f with SMTP id 98e67ed59e1d1-380ba8d00eamr9530789a91.12.1783081291046; Fri, 03 Jul 2026 05:21:31 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:185d:def2:c823:8e8c]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0b816a42sm34656381eec.9.2026.07.03.05.21.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2026 05:21:30 -0700 (PDT) From: mdshahid03@gmail.com To: Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH] smb: client: remove redundant NULL check before kfree() Date: Fri, 3 Jul 2026 17:51:04 +0530 Message-ID: <20260703122104.69788-1-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid kfree() safely handles NULL pointers, so the explicit NULL check before calling kfree() is unnecessary. This issue was reported by ifnullfree.cocci. Signed-off-by: Mohammad Shahid --- fs/smb/client/ioctl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/smb/client/ioctl.c b/fs/smb/client/ioctl.c index 9fa743be3652..2f152d76be7d 100644 --- a/fs/smb/client/ioctl.c +++ b/fs/smb/client/ioctl.c @@ -133,8 +133,7 @@ static int cifs_set_compression_by_path(unsigned int xid, struct file *filep, close: server->ops->close(xid, tcon, &fid); - if (tmp_cfile) - kfree(tmp_cfile); + kfree(tmp_cfile); cifs_free_open_info(&data); out: free_dentry_path(page); -- 2.43.0