From: Liang Hao <haohlliang@gmail.com>
To: hoan@os.amperecomputing.com, linusw@kernel.org, brgl@kernel.org
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Liang Hao <haohlliang@gmail.com>
Subject: [PATCH] gpio: dwapb: Add robust error handling in interrupt handler
Date: Fri, 3 Jul 2026 21:48:33 +0800 [thread overview]
Message-ID: <20260703134833.21110-1-haohlliang@gmail.com> (raw)
The current interrupt handler silently continues if an interrupt
handling fails, which may lead to interrupt storms. Add proper
error handling to gracefully recover from failed interrupt
handling.
When generic_handle_irq() fails, the following recovery actions are
taken:
- Write EOI to clear the pending interrupt
- Mask the interrupt to prevent immediate re-triggering
- Disable the interrupt to stop further interrupts on this line
These measures prevent the system from being overwhelmed by repeated
unhandled interrupts while logging a rate-limited warning for
debugging purposes.
Signed-off-by: Liang Hao <haohlliang@gmail.com>
---
drivers/gpio/gpio-dwapb.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index 7b92b233fafe..dec700e3cfb0 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -209,8 +209,20 @@ static u32 dwapb_do_irq(struct dwapb_gpio *gpio)
for_each_set_bit(hwirq, &irq_status, DWAPB_MAX_GPIOS) {
int gpio_irq = irq_find_mapping(gen_gc->gc.irq.domain, hwirq);
u32 irq_type = irq_get_trigger_type(gpio_irq);
-
- generic_handle_irq(gpio_irq);
+ int ret;
+ u32 val_intmask, val_inten;
+
+ ret = generic_handle_irq(gpio_irq);
+ if (ret) {
+ dev_warn_ratelimited(gpio->dev, "Failed to handle irq %d\n", gpio_irq);
+ /* Clear the interrupt */
+ dwapb_write(gpio, GPIO_PORTA_EOI, BIT(hwirq));
+ val_intmask = dwapb_read(gpio, GPIO_INTMASK);
+ dwapb_write(gpio, GPIO_INTMASK, val_intmask | BIT(hwirq));
+ val_inten = dwapb_read(gpio, GPIO_INTEN);
+ dwapb_write(gpio, GPIO_INTEN, val_inten & ~BIT(hwirq));
+ continue;
+ }
if ((irq_type & IRQ_TYPE_SENSE_MASK) == IRQ_TYPE_EDGE_BOTH)
dwapb_toggle_trigger(gpio, hwirq);
--
2.50.1 (Apple Git-155)
next reply other threads:[~2026-07-03 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 13:48 Liang Hao [this message]
2026-07-03 21:21 ` [PATCH] gpio: dwapb: Add robust error handling in interrupt handler Linus Walleij
2026-07-03 21:40 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260703134833.21110-1-haohlliang@gmail.com \
--to=haohlliang@gmail.com \
--cc=brgl@kernel.org \
--cc=hoan@os.amperecomputing.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox