From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013059.outbound.protection.outlook.com [40.93.196.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A7A33D890B for ; Fri, 3 Jul 2026 13:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.59 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783087170; cv=fail; b=HVkjVfOgDH5dj6gzYT6T2iYtB7HCOOQXmymqD+x2qR/wzrJhHuf3f8dTWqym7bVCzYfElS0lN+t9/LSSy6I5hlDbuyYUwfdp4OlMW8bdNXv1UIl4ow7Oacm3q2lrlcl/OS/AHyTslxakPMzuJGsNfu9xpIOWKkn8AJ/zI24YevI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783087170; c=relaxed/simple; bh=AWfYsuUc43oX03goscYmJ7nWY/VuCf0+lWAc20aMpNg=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=ANB/m7RIOr1VYG3907r8zAipO5el9D+NBAx6acVSXrWmbxwBSi5M6Fd4zjNhuDbmbixInH0FrmHEJY2G31Do36S2yuEnwVcWNBpR5P8HVQyshwDIgZ8mzEkTJWnPW2/TUuozBBLKMxdehxE/ZgJY1ShlvITRsommc/Soo6yVxo0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=PJCKGoPG; arc=fail smtp.client-ip=40.93.196.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="PJCKGoPG" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kmY/sin2dmr5CBFWphJKWGWPrn0rxsYi4fNY6Pz2hDWHwhbX4k/VHcS8xtsqNwM80xt1kAhZUwBVd4n1Hz2qVgc3V0NIMylXeSt7dRE7uyj7ZK4G3u94BckVXtMOY54Y+crx0Ydqm3NO05aBX9Oh2CaE1MvwceNbrJbXe+bB6CAONfahP8dLknR5A3M5iqgklC2zjlMgHG1g6tZ62fejwN91zEsEPZYL1AJAgxcufuWyY+FDW6Fyr73cJ5IdKbOd0YilZEiISDcWIFVSbRmAG85jezpUnyN/LY5SfTq/bULZOFZg6L9KnMTc0ov/fhT40/hLQDsbKX0PJ1U5vwByYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BWogQGjoQk7aPnuAhRenIMplCZxStSYXdoGHdmVdL7Y=; b=iQ6+qI1LlARuxmOAM/JIFLcwTbLQ0xJ8RmTTl2hnT5aeNF5Oy3x7t8IWVWfZUHQA7SI9Viy6MKUc3r95ytF53iyy75JEPmygzFCut88wa6Ala6JAMuP0vCCPFS9e0YV9QiKKYshLqCrX/KNRYO+dkOs49d92LNoIZ6CxXk+ls7p2TUeDXlnXifTE4HPdgYK8/c6RWBBZvnj+CtFntD3GqTkbtur+wyZ5kEMdoCgZqw4roB6KXag+m3IQc8/smOZyjcchWjGP6JSRTzaZ7iUeOQ6S8EmBhh2lloNcy0OP2KOME/ZD8AkhRL0cG7z7JunFJUd5JFFftr1xAtwvOPIj4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BWogQGjoQk7aPnuAhRenIMplCZxStSYXdoGHdmVdL7Y=; b=PJCKGoPGivvYb2m5y9dyLeNYKWCFXnAbHVi+ILtRrUR34FCWBQqsI0GTJfRFwWxmrHAoTCYQz3SdesBw1AJEk9YZq+bp9YMK/41c7jmcBu/6xWWIBRwtIQUdUC4cx1MMrcdhMdHUTDIrPGtKJycgwrHdPFbim8hKuOajxF+hMS+yPVKWN1SD9d8sygncZ/uTi4YOXp3R/5e2InSxdtE6GWDNX09ukg/HiaBDtlprMFCAuNHyBkmOd4G/68tOswMWdDSeQ27BjQ5IZBDeWoLOsLI9YuulmyYNlzuzdHbMS1wYON+xz8+DS3+IDwgj1Am8hflujlNtkGw/NYoK2GyGLQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by MN2PR12MB4047.namprd12.prod.outlook.com (2603:10b6:208:1de::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.11; Fri, 3 Jul 2026 13:59:26 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%4]) with mapi id 15.21.0181.008; Fri, 3 Jul 2026 13:59:26 +0000 Date: Fri, 3 Jul 2026 10:59:24 -0300 From: Jason Gunthorpe To: Armin Wolf Cc: Ankit Agrawal , gregkh@linuxfoundation.org, jai.luthra@ideasonboard.com, ilpo.jarvinen@linux.intel.com, alex@shazbot.org, vsethi@nvidia.com, mhonap@nvidia.com, mochs@nvidia.com, clg@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] platform/nvidia: Introduce nvgrace-egm driver and enumerate EGM regions Message-ID: <20260703135924.GP7481@nvidia.com> References: <20260702192532.455400-1-ankita@nvidia.com> <20260702192532.455400-2-ankita@nvidia.com> <19799c78-f9ac-44e0-aedf-6c7bca77c15d@gmx.de> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19799c78-f9ac-44e0-aedf-6c7bca77c15d@gmx.de> X-ClientProxiedBy: YT1PR01CA0039.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2e::8) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|MN2PR12MB4047:EE_ X-MS-Office365-Filtering-Correlation-Id: 188ecd9e-96b3-4219-82fb-08ded90b4a94 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|23010399003|4143699003|11063799006|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: QHZUk2xwu7+iG94j9tQI7jvB2CDR5tkvVgAAekQbjunNsWV3F3o/sI141USveIjrpHntYKTnXwl6oLj2ODQcKqHBiLshRuVDlH87arSucqsiyuEcvTbvNFRLcmoLDYLxpmyh1JquNtNpi4gjFyTzmsiS9IuiX37C6sOFOx260VcUI+tvM/wScLo+AbnHbtvsFcPy2mLcYh9xANM8bC4PxkwsR7J0XCZ8WCE/nrTyF9e+ANAx0BPtB8rZkpRE92p1uhb02ckdRWHU8PMijH3qqx8gUCk8913C+wD/qLJdQU8yquFBfwdj05oIybyiYykT1PuNl2HLDXCe+HiBHB5zqHrO3Pd0lNSPjLNq00dzqEs1HdVmgTts2mznXtUWf1EewWiQJI68zK5FYLpMVpeP6Tqh2K8dThgnO/TkV25Y9pTIoW7nupq6MA4sOFYRQsx83QV3XqCuTF81UacPlW53fiyVFqSEzyPk534jiG7Cr/LO4s9RPejwSNJ6fE8fIlGpj0+YgV8pNDncQEyV4T7L9BHkF4REEauJB53JM4y0XQgLSZX9h+GIrhm/0E5q7FFyd3hVmdDNsNWPQEGlU7OBJZ2E0lY7EcOyOT2y60/rxKYlTY2AbyOkTQehl0E+HsfFNFRfBzimVKGnaRCmZ60x1+S2vzL8X5PkfP7Qz3bJSGg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(23010399003)(4143699003)(11063799006)(56012099006)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vAh6zqhWlPBYDi5XFxHOvqcfiXIJS6osp6ckijhg7RPxCHfJpBcSEpGdzwdg?= =?us-ascii?Q?R3sKgLsQaIG3rhO30QtEeXlFs/GPX06QZWPBDBNg7X60O3D0Mcqn6+kICOZG?= =?us-ascii?Q?3v9kp9xdXNtWMnPazbmnx82tf5s70WpEumm85hFJ9EEFXaPTT5NDBdA5+hKj?= =?us-ascii?Q?lSzQkwHqNKn5Oq1ET+JjLOBZ4jQuRrxMsi0uakw7xRBFH5MWYM2yMPO24T8q?= =?us-ascii?Q?qSxSF75MUkZzJZOa4kEC2YMHve2oJYZAmUTfi77wGgsGt9O4Phj1g5eIxwx5?= =?us-ascii?Q?mp1RGgKG92glmnSyQFNaH/u+sYdV+OOzl51JXDkejKPyR1ED4egj1cnwAXYI?= =?us-ascii?Q?rGHXHGKz0iPjEpqGXrbnwy4ueqWHIyVcZjSCboEY2+ZeOfyJ6so3entIDyuD?= =?us-ascii?Q?+VpYgRMpETKJvGibPvk1rDDIQndqrq0N5+glujPmjPFJYJ6/IUETZvF64wR5?= =?us-ascii?Q?JrVZO1SH1bSZXXIIpN7qyqLuISRuz0NsxZuIteYd/xeBgrGjiAw2uwKHy9l2?= =?us-ascii?Q?K88eiNPAB3WdYj3EFRuMvWllsnThaq009KrHcs0kyaA7VpywcaQ2C+yrEco3?= =?us-ascii?Q?+rJ3b0duzwceIBXhJxddthr5ReAvXDN5gQ6sXV7x5octJ1Z20N7OcF0A5Ju5?= =?us-ascii?Q?TMfZxgg8psFKr6X23dDvkqqKs9BxP3cBYhPljXvcvsayE3iP3iQs25xlZWNM?= =?us-ascii?Q?/QhHejaIcGCn2QApRgEVIO/iFhHg34ui/aK4hoWwN0zBvNv+b7RTnhYjL+hs?= =?us-ascii?Q?+dX1VbtSuCmaVrPecPeUcWvhbpcnCZ3k9ZYc+xs8TwqqkpXiz8RiCUMaNsap?= =?us-ascii?Q?4VfBPsS432s1DAjCzo4D7opsajjQvQ9AXelT23DeUb2i6bMme/s0sXi+lcCn?= =?us-ascii?Q?Gx2HcONxPikP1vxOvC1luMg6dTuRSCOX7vUq3ICONGowpgxUnLD5R7knsSaV?= =?us-ascii?Q?LJzdcWOP/ma6wO+ylqMvcs948lAJNHSq216Mr3g1yRvEV0qBkr6i8YBmjN8Q?= =?us-ascii?Q?uG+Nc62Ypl8agn0bK+ybHfgSLoS2Znq8t3gWX1SEhEU3kvKVzdNqCBbxITfj?= =?us-ascii?Q?b+MswUSY5eZJhSnZI90tFMCCCpGZppHwiQ9JueYLmctzDPGaAaZ3taDD7syr?= =?us-ascii?Q?2b4KmGJRvGj/Tox/MbKOy8E/IWo30tz8adWKw5cdXhyK7Doyp1O/V5riGxq+?= =?us-ascii?Q?YXDT9/0GoUfmk6j+KJGs4XNbwfHkvAzQEwXIV9W/j88s+JYpzmoyh8D0/ebH?= =?us-ascii?Q?jTtggRUGilla1jn665dMZgBNjKi/lzFz3iUR5GNmZ2j324qWOVx5Uh3r+FCC?= =?us-ascii?Q?R1uIawMoqDHdt1y0pEeGS5OjrYglxsrdNPBxryvle+0+ySjz0kFKi82NnVBQ?= =?us-ascii?Q?pr8va6wn7rff2XfacOGdXt4n///O2YBmQDFGH9KonxW7erXcz1HT1XVIE3GX?= =?us-ascii?Q?CknttmuzNasH6LXwkXVAcWhYWEgFvpxY5k1e0LUneL+eVvCyOqVYBcrQ/3BK?= =?us-ascii?Q?7ScazvbhJMPRDfRoPg6/CCUkt4UqP3caB6kQSl+FiPAKXfRHtD0PXnPLlAsf?= =?us-ascii?Q?foVu0A/jCktnW8eAO31U9VKqCw/+d2pHsCXbYydg33jN3gg39ISUD+1KvhjV?= =?us-ascii?Q?bUoYWJVtmIrdgZXw99lMMSVIsfisvwyHE1qNOvBfqVEPVmQz9HNOxVksEltt?= =?us-ascii?Q?4iHYGymo+XS58feKQiBF8z6ZfWQ1IDFp/KWqAus8VcSzhoF1?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 188ecd9e-96b3-4219-82fb-08ded90b4a94 X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2026 13:59:25.4287 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yRN7jPl0zwajUyBLhs3Q+HeZRilTLV9KN5IiHbWrJmOrPwt0UHR9UPZ8/cty+3KH X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4047 On Fri, Jul 03, 2026 at 12:22:21AM +0200, Armin Wolf wrote: > > - Walk all PCI devices at module init time. For each one advertising > > "nvidia,egm-pxm", read the EGM region properties (base SPA, size and > > PXM domain) from the ACPI DSD table via the GPU device handle, using > > "nvidia,egm-base-pa" and "nvidia,egm-size" properties. > > - Maintain a module-level list (egm_chardevs) of discovered regions, > > de-duplicating by PXM so each socket gets exactly one EGM device > > regardless of how many GPUs it has (2 GPUs per EGM device in GB200). > > I assume that the PCI device itself is being handled by the GPU driver, right? > In this case i suggest that you do the discovery inside the GPU driver during probing, > otherwise you might run intro problems once PCI hotplug comes into play. IMHO the ACPI modeling placing the egm-base-pa under the PCI device is not really very good (but we are stuck with it). The EGM is an entirely distinct object from the PCI device. The ACPI is just saying that the PCI device has efficient access to the EGM. It wouldn't make any sense to involve the GPU driver since the GPU driver doesn't even run on the hypervisor. Jason