The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Gary Guo <gary@garyguo.net>
Cc: "Boqun Feng" <boqun@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Lyude Paul" <lyude@redhat.com>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Onur Özkan" <work@onurozkan.dev>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Tamir Duberstein" <tamird@kernel.org>,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	"Ingo Molnar" <mingo@redhat.com>, "Will Deacon" <will@kernel.org>,
	"Waiman Long" <longman@redhat.com>,
	linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH RFC 0/2] rust: sync: create lock class using `#[track_caller]`
Date: Fri, 3 Jul 2026 16:01:40 +0200	[thread overview]
Message-ID: <20260703140140.GE651302@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20260703-rust_lockdep-v1-0-1c21c62d0341@garyguo.net>

On Fri, Jul 03, 2026 at 02:47:25PM +0100, Gary Guo wrote:
> Currently we're adding more and more macros so that lock classes can be
> created. The only purpose served by these macros are to create names and
> static lock classes so they can be tracked by lockdep.
> 
> I've come up with an approach that uses `Location::caller` and Rust's
> `#[track_caller]` feature for this purpose instead. `Location::caller()`
> will return a `&'static Location<'static>` that lives in `.rodata`. As
> only addresses matter for static objects, the address of the `Location`
> themselves could be used for lock classes. The `Location` is of 2 * usize +
> 8 bytes, so they could host 2 lock class keys, so `DelayedWork` which needs
> two lock classes can also use this mechanism.
> 
> The `Location::caller` could also be used to provide the name; currently,
> `optional_name` just uses `file_name:line_number` as the name, and this
> information is available in `Location`. However, `Location` encodes them
> using file name as a C string plus two `u32`'s for line and column number,
> so it cannot provide a single name. I came up with an alternative method,
> which is to use a special string, which lockdep can recognize and delegate
> back to Rust to print it.

Perhaps add some sample output so us simple folk that still think rust
looks like line noise can have an idea of what it'll look like. Because
I just cannot make much sense of the above.

  parent reply	other threads:[~2026-07-03 14:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-03 13:47 [PATCH RFC 0/2] rust: sync: create lock class using `#[track_caller]` Gary Guo
2026-07-03 13:47 ` [PATCH RFC 1/2] rust: sync: introduce a way to create lock class from caller Gary Guo
2026-07-03 13:47 ` [PATCH RFC 2/2] lockdep: delegate Rust lock class printing to Rust code Gary Guo
2026-07-03 14:01 ` Peter Zijlstra [this message]
2026-07-03 14:24   ` [PATCH RFC 0/2] rust: sync: create lock class using `#[track_caller]` Gary Guo
2026-07-03 22:32     ` Peter Zijlstra
2026-07-04 16:52       ` Gary Guo
2026-07-04 17:10         ` Peter Zijlstra
2026-07-04 17:46           ` Gary Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260703140140.GE651302@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=lossin@kernel.org \
    --cc=lyude@redhat.com \
    --cc=mingo@redhat.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=will@kernel.org \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox